Skip to content

Commit e7cf792

Browse files
Merge pull request #115 from SciML/remove-get-extension-compat
Remove Julia v1.9 get_extension compatibility code
2 parents 378c172 + 395ea99 commit e7cf792

File tree

4 files changed

+68
-27
lines changed

4 files changed

+68
-27
lines changed

.github/workflows/CI.yml

Lines changed: 31 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,46 @@
1-
name: Downgrade
1+
name: CI
22
on:
3-
pull_request:
4-
branches:
5-
- master
6-
paths-ignore:
7-
- 'docs/**'
83
push:
94
branches:
10-
- master
11-
paths-ignore:
12-
- 'docs/**'
5+
- main
6+
tags: ['*']
7+
pull_request:
8+
concurrency:
9+
# Skip intermediate builds: always.
10+
# Cancel intermediate builds: only if it is a pull request build.
11+
group: ${{ github.workflow }}-${{ github.ref }}
12+
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
1313
jobs:
1414
test:
15-
runs-on: ubuntu-latest
15+
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
16+
runs-on: ${{ matrix.os }}
1617
strategy:
18+
fail-fast: false
1719
matrix:
18-
group:
19-
- Core
20-
downgrade_mode: ['alldeps']
21-
julia-version: ['1.10']
20+
version:
21+
- 'lts'
22+
- '1'
23+
- 'pre'
24+
os:
25+
- ubuntu-latest
26+
arch:
27+
- x64
2228
steps:
2329
- uses: actions/checkout@v4
2430
- uses: julia-actions/setup-julia@v2
2531
with:
26-
version: ${{ matrix.julia-version }}
27-
- uses: julia-actions/julia-downgrade-compat@v2
28-
# if: ${{ matrix.version == '1.6' }}
32+
version: ${{ matrix.version }}
33+
arch: ${{ matrix.arch }}
34+
- uses: julia-actions/julia-downgrade-compat@v1
35+
if: ${{ matrix.version == '1.6' }}
2936
with:
30-
skip: Pkg,TOML
37+
skip: Pkg, TOML
38+
- uses: julia-actions/cache@v2
3139
- uses: julia-actions/julia-buildpkg@v1
3240
- uses: julia-actions/julia-runtest@v1
41+
- uses: julia-actions/julia-processcoverage@v1
42+
- uses: codecov/codecov-action@v5
3343
with:
34-
ALLOW_RERESOLVE: false
35-
env:
36-
GROUP: ${{ matrix.group }}
44+
files: lcov.info
45+
token: ${{ secrets.CODECOV_TOKEN }}
46+
fail_ci_if_error: false

.github/workflows/Downgrade.yml

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: Downgrade
2+
on:
3+
pull_request:
4+
branches:
5+
- main
6+
paths-ignore:
7+
- 'docs/**'
8+
push:
9+
branches:
10+
- main
11+
paths-ignore:
12+
- 'docs/**'
13+
jobs:
14+
test:
15+
runs-on: ubuntu-latest
16+
strategy:
17+
matrix:
18+
group:
19+
- Core
20+
downgrade_mode: ['alldeps']
21+
julia-version: ['1.10', '1', 'pre']
22+
steps:
23+
- uses: actions/checkout@v4
24+
- uses: julia-actions/setup-julia@v2
25+
with:
26+
version: ${{ matrix.julia-version }}
27+
- uses: julia-actions/julia-downgrade-compat@v2
28+
# if: ${{ matrix.version == '1.6' }}
29+
with:
30+
skip: Pkg,TOML
31+
- uses: julia-actions/julia-buildpkg@v1
32+
- uses: julia-actions/julia-runtest@v1
33+
with:
34+
ALLOW_RERESOLVE: false
35+
env:
36+
GROUP: ${{ matrix.group }}

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ADTypesEnzymeCoreExt = "EnzymeCore"
2222
ChainRulesCore = "1.0.2"
2323
ConstructionBase = "1.5"
2424
EnzymeCore = "0.5.3,0.6,0.7,0.8"
25-
julia = "1.6"
25+
julia = "1.10"
2626

2727
[extras]
2828
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"

src/ADTypes.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ include("sparse.jl")
2626
include("legacy.jl")
2727
include("symbols.jl")
2828

29-
if !isdefined(Base, :get_extension)
30-
include("../ext/ADTypesChainRulesCoreExt.jl")
31-
include("../ext/ADTypesEnzymeCoreExt.jl")
32-
end
33-
3429
# Automatic Differentiation
3530
export AbstractADType
3631
export AutoChainRules,

0 commit comments

Comments
 (0)