Add correct calculation for pageCount when using scrollPerPage false #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysimpson
commented
Nov 26, 2018
| @@ -86,6 +86,10 @@ exports[`Carousel should decrease current slide number by 1 when advance slide b | |||
| button.VueCarousel-dot-button(type='button', role='button', aria-label='\`Item \${index}\`', title='Item 0', tabindex='0', style='width: 10px; height: 10px; background: rgb(239, 239, 239);') | |||
| li.VueCarousel-dot.VueCarousel-dot--active(aria-hidden='false', role='presentation', aria-selected='true', style='margin-top: 20px; padding: 10px;') | |||
| button.VueCarousel-dot-button(type='button', role='button', aria-label='\`Item \${index}\`', title='Item 1', tabindex='0', style='width: 10px; height: 10px; background: rgb(0, 0, 0);') | |||
| li.VueCarousel-dot(aria-hidden='false', role='presentation', aria-selected='false', style='margin-top: 20px; padding: 10px;') | |||
There was a problem hiding this comment.
This test should have four navigation dots and was wrong originally. After the fix the snapshot was updated to now be correct.
quinnlangille
approved these changes
Nov 27, 2018
quinnlangille
added a commit
that referenced
this pull request
Nov 29, 2018
* feat(standard): adding touchDrag prop to block touch dragging (#296) * feat(standard): adding touchDrag prop to block dragging on mobile devices * feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json * adding line-break space to end of file * chore(build): release for rc1 * v0.16.0-rc1 * Fix carousel failing to lock to remainder slides (#303) * Update Carousel.vue fix carousel bug * Added a looping autoplay to the Story page. (#305) * docs(readme): updated README configuration section (#304) * v0.16.0-rc2 * fix: rename event slideClick to slideclick in Slide.vue (#311) * fix: rename event slideClick to slideclick * fix(slide): disable tap highlight in Mobile Safari (#326) * fix(slide): disable tap highlight in Mobile Safari * feat: add correct calculation for pageCount (#329) * chore: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the page count calculation for the carousel and pagination to properly display the correct number of pagination dots for scrollPerPage false
Motivation and Context
The current functionality is broken and very apparent when using scrollPerPage in vue play
How Has This Been Tested?
I have only tested the implementation in vue play
Types of changes
Checklist: