Skip to content

feat(standard): adding touchDrag prop to block touch dragging #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2018

Conversation

NickMcBurney
Copy link

@NickMcBurney NickMcBurney commented Oct 19, 2018

Description

  1. Added new prop touchDrag, mirroring naming/settings of mouseDrag.
  2. Adding touchDrag to the if (isTouch || mouseDrag) onStart trigger, meaning the user can turn off touch dragging on mobile devices by setting both touchDrag and mouseDrag bool to false.

Motivation and Context

I needed this functionality for a project I'm working on, allowing me to block users from moving slides with touch drag, meaning slides can only move using builtin methods.

How Has This Been Tested?

Passed Linting & Automated Tests
Manual Testing: Duplicated build output to a local project and tested in Chrome Dev Tools and on Android Mobile Device.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
    • [x ] I have updated the documentation accordingly.
  • I have included a vue-play example (if this is a new feature)

@quinnlangille
Copy link
Member

quinnlangille commented Oct 20, 2018

Hey @NickMcBurney, thanks for this! Really great implementation, a lot more simple than what I was thinking 👍 We use yarn on the project vs npm, so if you don't mind can you remove the package-lock.json (and also, if you have an extra second can you add it to the .gitignore).

Once that's done I'll merge it in! :octocat:

@NickMcBurney
Copy link
Author

Thanks @quinnlangille, thought it best to keep it as simple as possible. I've just committed again with the lock file removed and added to .gitignore

@quinnlangille
Copy link
Member

Perfect thanks! Will merge in asap

@NickMcBurney
Copy link
Author

@quinnlangille, do you know when you'll be able to get this merged in? Could do with functionality for a project and I'd prefer to not use my local version.

@quinnlangille
Copy link
Member

Hey @NickMcBurney, I'm working on another feature for the release currently. I can merge it into a feature branch and publish as a release-candidate if you'd like to use it now though

@quinnlangille quinnlangille changed the base branch from master to v0.16.0 October 24, 2018 16:15
@quinnlangille quinnlangille merged commit eaf7890 into SSENSE:v0.16.0 Oct 24, 2018
@quinnlangille
Copy link
Member

Release and tagged here: https://github.com/SSENSE/vue-carousel/tree/v0.16.0-rc1

Available on npm as [email protected]

quinnlangille pushed a commit that referenced this pull request Nov 26, 2018
* feat(standard): adding touchDrag prop to block dragging on mobile devices

* feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json

* adding line-break space to end of file
quinnlangille added a commit that referenced this pull request Nov 29, 2018
* feat(standard): adding touchDrag prop to block touch dragging (#296)

* feat(standard): adding touchDrag prop to block dragging on mobile devices

* feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json

* adding line-break space to end of file

* chore(build): release for rc1

* v0.16.0-rc1

* Fix carousel failing to lock to remainder slides (#303)

* Update Carousel.vue

fix carousel bug

* Added a looping autoplay to the Story page. (#305)

* docs(readme): updated README configuration section (#304)

* v0.16.0-rc2

* fix: rename event slideClick to slideclick in Slide.vue (#311)

* fix: rename event slideClick to slideclick

* fix(slide): disable tap highlight in Mobile Safari (#326)

* fix(slide): disable tap highlight in Mobile Safari

* feat: add correct calculation for pageCount (#329)

* chore: build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants