-
Notifications
You must be signed in to change notification settings - Fork 504
feat(standard): adding touchDrag prop to block touch dragging #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(standard): adding touchDrag prop to block touch dragging #296
Conversation
Hey @NickMcBurney, thanks for this! Really great implementation, a lot more simple than what I was thinking 👍 We use yarn on the project vs npm, so if you don't mind can you remove the Once that's done I'll merge it in! |
…ices - removing package-lock.json
Thanks @quinnlangille, thought it best to keep it as simple as possible. I've just committed again with the lock file removed and added to .gitignore |
Perfect thanks! Will merge in asap |
@quinnlangille, do you know when you'll be able to get this merged in? Could do with functionality for a project and I'd prefer to not use my local version. |
Hey @NickMcBurney, I'm working on another feature for the release currently. I can merge it into a feature branch and publish as a release-candidate if you'd like to use it now though |
Release and tagged here: https://github.com/SSENSE/vue-carousel/tree/v0.16.0-rc1 Available on npm as |
* feat(standard): adding touchDrag prop to block dragging on mobile devices * feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json * adding line-break space to end of file
* feat(standard): adding touchDrag prop to block touch dragging (#296) * feat(standard): adding touchDrag prop to block dragging on mobile devices * feat(standard): adding touchDrag prop to block dragging on mobile devices - removing package-lock.json * adding line-break space to end of file * chore(build): release for rc1 * v0.16.0-rc1 * Fix carousel failing to lock to remainder slides (#303) * Update Carousel.vue fix carousel bug * Added a looping autoplay to the Story page. (#305) * docs(readme): updated README configuration section (#304) * v0.16.0-rc2 * fix: rename event slideClick to slideclick in Slide.vue (#311) * fix: rename event slideClick to slideclick * fix(slide): disable tap highlight in Mobile Safari (#326) * fix(slide): disable tap highlight in Mobile Safari * feat: add correct calculation for pageCount (#329) * chore: build
Description
touchDrag
, mirroring naming/settings of mouseDrag.touchDrag
to theif (isTouch || mouseDrag) onStart
trigger, meaning the user can turn off touch dragging on mobile devices by setting bothtouchDrag
andmouseDrag
bool tofalse
.Motivation and Context
I needed this functionality for a project I'm working on, allowing me to block users from moving slides with touch drag, meaning slides can only move using builtin methods.
How Has This Been Tested?
Passed Linting & Automated Tests
Manual Testing: Duplicated build output to a local project and tested in Chrome Dev Tools and on Android Mobile Device.
Types of changes
Checklist: