middleware cleaning #2024
Open
middleware cleaning #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow HTTP_AUTHORIZATION to be split just in 4 remove support for sending authorization with cookies
jerryfletcher21
force-pushed
the
cookies-auth-remove
branch
from
d29895b to
623e596
Compare
jerryfletcher21
changed the title
KoalaSat
reviewed
Jun 27, 2025
There was a problem hiding this comment.
This PR will be controversial. There are many 3rd party programs consuming Robosats API. We need to announce this with 2 versions in advance and make sure everyone is able to continue their trade after the updagre. On going orders might loose their access to the chat if they don´t have access to peer PGP. My plan is first to fully migrate the chat to nostr.
|
@KoalaSat I can help with the transition of the chat to nostr in the backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes some old code from
middleware.py.Since #1985 was merged, it removes the legacy support for splitting
HTTP_AUTHORIZATIONin 3 instead of 4.It removes support for sending authorization with cookies that really old clients pre federation were using.
I am pretty sure nobody is running such an old client that still sends cookies, but with #1985 merged these will no longer work since they were not sending the nostr pubkey.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.