Skip to content

ensure nostr pubkey is present in auth when creating robot #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jerryfletcher21
Copy link
Contributor

What does this PR do?

Since nostr is becoming necessary for the trade process, this PR checks that the nostr_pubkey is present in the authorization header when creating a robot.
It also documents the presence of nostr_pubkey in some comments.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@KoalaSat
Copy link
Member

KoalaSat commented Jun 2, 2025

This change can't be possible while some folks run old frontend versions that are not sending nostr pubkey. Fortunately for us robodats clients always force users to upgrade if they detect a major new version on any of the coordinatros. That means these changes will only be possible with v0.8.0.

@jerryfletcher21
Copy link
Contributor Author

jerryfletcher21 commented Jun 3, 2025

@KoalaSat yes I understand. But it has been reported by other coordinators that there are now problems in sending the messages and completing the orders when nostr_pubkey is not present. It think it may be better to block the creation of robots all together and force them to update instead of allowing to create robots and not being able to complete the trades for old clients.

@KoalaSat KoalaSat merged commit 0763b58 into RoboSats:main Jun 26, 2025
3 checks passed
@jerryfletcher21 jerryfletcher21 mentioned this pull request Jun 26, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants