Skip to content

RI-6540: Change message for unsupported data types #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

RI-6540: Change message for unsupported data types #248

merged 2 commits into from
Feb 4, 2025

Conversation

pawelangelow
Copy link
Collaborator

Preview

Screenshot 2025-01-08 at 11 51 08 Screenshot 2025-01-08 at 11 51 13

@pawelangelow pawelangelow self-assigned this Jan 8, 2025
egor-zalenski
egor-zalenski suggested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@egor-zalenski egor-zalenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after changing texts we should call yarn l10n:collect to update the texts lists

egor-zalenski
egor-zalenski approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@egor-zalenski egor-zalenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for future:
branches for vscode extension should start with feature/* to autorun fe unit tests

@pawelangelow
Copy link
Collaborator Author

Ty for the suggestion. Here's the action results from running the tests: https://github.com/RedisInsight/Redis-for-VS-Code/actions/runs/12673008836/job/35318351238

@KIvanow KIvanow merged commit 871385a into main Feb 4, 2025
9 checks passed
@KIvanow KIvanow deleted the RI-6540-change-unsupported-data-types-message branch February 4, 2025 13:08
KIvanow added a commit that referenced this pull request Jun 4, 2025
@KIvanow @mariasergeenko
@egor-zalenski @vlad-dargel @pawelangelow @dantovska @KrumTy @pd-redis @ArtemHoruzhenko @snyk-bot @ViktarStarastsenka
Release/1.4.0 (#289)
a004358 
* add tests

* #RI-6522 - [Regression] Long vector string is not displayed

* #RI-6522 - [Regression] Long vector string is not displayed

* #RI-6514 - Support multiple key name delimiters

* #RI-6514 - fix pr comments

* #RI-6532 - Empty value is displayed as array

* e2e/feature/RI-6514_support-multiple-key-name-delimiter

* * #RI-6581 - Empty delimiter can be applied
* #RI-6582 - The same delimiter can be applied multiple times

* * #RI-6581 - Empty delimiter can be applied
* #RI-6582 - The same delimiter can be applied multiple times

* RI-6540: Change message for unsupported data types (#248)

* change message

* update texts

* add simple running locally section (#254)

* RI-6509 - Create a free db vscode (#252)

* #RI-6509 - Create a free db vscode

* #RI-6509 - Create a free db vscode

* #RI-6509 - Create a free db vscode

* RI-6508: turn on keytar encryption for existing users

* RI-6508: revert since version for encryption setting

* RI-6508: add custom logic for handling keytar encryption issue

* RI-6508: clean up compareConsents test params

* RI-6635: Add cloud provider region selection (#257)

* enhance the store to support the plan logic (for selecting region and provider)
* create the oauth select plan component
* enable the checkbox which unlocks the select plan functionality
* open the oauth select plan dialog, when isRecommended checkbox is not checked

* RI-6931: Require login on every free cloud db creation (#260)

* introduce a REQUIRE_LOGIN_ON_NEW_DB constant, as there is no logout functionality and the user should be able to create free DBs with different accounts
* modify existing test and add new ones depending on the REQUIRE_LOGIN_ON_NEW_DB value

* RI-6835: Rename the "free" to "free trial" Cloud db  (#258)

* change `free` to `free trial`

* remove typo

* ran l10n:collect

* RI-6932: create btn open oauth modal (#262)

* when add database called from the database list - open the oauth social dialog - add new vscode actions
* close modal when successfully create db and X button on the toast notification is clicked

* RI-7027: Add JSON key -> Create free db dialog (#266)

* when json module is missing, instead of opening the try-free link, change to open the oauth sso dialog by passing the callback fn to the helper text

* RI-6967: change `free` to `free trial` wherever found

* fix: package.json & yarn.lock to reduce vulnerabilities (#263)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-AXIOS-9403194

Co-authored-by: snyk-bot <[email protected]>

* RI-7010: add logging for unidentified error responses

* RI-6910: hide cloud ads based on env variable

* RI-6910: disable cloud ads based on flag

* fix formatting

* Update README.md

* Update README.md

* Update README.md

* RI-7012: add enterprise build workflows

* RI-7012: update enterprise build pipelines

* RI-7012: refactor enterprise build pipelines

* temp: rename prod folder

* Revert "temp: rename prod folder"

This reverts commit 98378eb.

* RI-7012: add enterprise build workflows (#271)

* RI-7012: add enterprise build workflows

* RI-7012: update enterprise build pipelines

* RI-7012: refactor enterprise build pipelines

* temp: rename prod folder

* Revert "temp: rename prod folder"

This reverts commit 98378eb.

* Create CODEOWNERS (#272)

* RI-7020: add new build type in telemetry

* Update README.md to reference Open VSX

* RI-7095: change wordings telemetry (#278)

* update and remove analytics strings
* reorder some cloud strings
* update eula string
* Add Usage Data string and replace it with Analytics
* Change the analytics agreement title, label and description to Usage Data

* DEV: Allow running only E2E tests for a particular branch (#280)

* DEV: Remove CircleCI dir (#279)

* DEV: Simplify repo configuration (#281)

* remove format on save
* remove inline params suggestions
* remove configured formatters
* remove husky

* RI-7108: Fix E2E pipeline (#282)

* DEV: Cache node_modules for the linux build pipeline (#283)

* format pipeline

* RI-7155 - SSO never finishes on the VS Code extension after a 401 error (#287)

* RI-7155 - SSO never finishes on the VS Code extension after a 401 error

* RI-7155 - SSO never finishes on the VS Code extension after a 401 error

* version bump alongside the fixes

* RI-000 fix builds (#288)

---------

Co-authored-by: mariasergeenko <[email protected]>
Co-authored-by: Zalenski Egor <[email protected]>
Co-authored-by: vlad-dargel <[email protected]>
Co-authored-by: Vlad <[email protected]>
Co-authored-by: Pavel Angelov <[email protected]>
Co-authored-by: dantovska <[email protected]>
Co-authored-by: Krum Tyukenov <[email protected]>
Co-authored-by: pd-redis <[email protected]>
Co-authored-by: Artsiom Kharuzhenka <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Krum Tyukenov <[email protected]>
Co-authored-by: ViktarStarastsenka <[email protected]>
Co-authored-by: Artsiom Kharuzhenka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIvanow KIvanow KIvanow approved these changes

@egor-zalenski egor-zalenski egor-zalenski approved these changes

Assignees

@pawelangelow pawelangelow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawelangelow @KIvanow @egor-zalenski @mariasergeenko