RI-6932: create btn open oauth modal #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cesfully finished? when one of the modals closed with X button?
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to open the Add Database page and immediately trigger the OAuth SSO dialog when the create button is clicked.
- Extension changes to post a new message action to open the OAuth dialog.
- UI changes to handle the new message action and pass the necessary data.
- Updates to API interfaces and supporting modules to accommodate the new OAuth SSO flow.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension.ts | Adds postMessage call to trigger 'OpenOAuthSsoDialog'. |
| src/webviews/src/index.tsx | Handles new message action for initiating OAuth SSO dialog. |
| src/webviews/src/interfaces/vscode/api.ts | Updates type definitions for the new message action. |
| src/webviews/src/modules/oauth/oauth-jobs/OAuthJobs.tsx | Incorporates source checking to conditionally close the database panel. |
| src/webviews/src/modules/oauth/oauth-create-free-db/OAuthCreateFreeDb.tsx | Passes the source property along with ssoFlow during creation. |
| src/utils/handleMessage.ts | Forwards message.data to the addDatabase command. |
| src/webviews/src/constants/vscode/vscode.ts | Adds the new VscodeMessageAction for OAuth SSO. |
…st message only if both ssoFlow and source are set
…on compressed button create clicked
dantovska
requested review from
KIvanow,
pawelangelow,
KrumTy,
ArtemHoruzhenko and
pd-redis
src/webviews/src/modules/oauth/oauth-create-free-db/OAuthCreateFreeDb.spec.tsx
Outdated
Show resolved
Hide resolved
…on; for the normal button - check the dialog content inside the document when clicked
pawelangelow
approved these changes
Mar 26, 2025
dantovska
deleted the
feature/RI-6932-simple-create-btn-open-oauth-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the create button function action:
To open the Add database page AND immediately open the OAuth SSO dialog: