Skip to content

feat: Add Hide ADB status patch #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 16, 2025

Conversation

1fexd
Copy link
Contributor

@1fexd 1fexd commented Mar 11, 2025

Came across an app that checks adb_enabled and development_settings_enabled within the Global settings, so I made a quick PoC which hooks getInt and returns 0 statically - I think settings spoofing would fit quite nicely into ReVanced's misc patches, but I'm not quite sure how this should be approached:

  • Should this be a generic patch that allows spoofing any setting?
    • If so, what about apps which require specific settings to be spoofed? Should there be additional patches for those apps re-using this functionality?
  • How would a sensible approach to spoofing look like? Is there some infra to get the properties to be spoofed and the values they should be spoofed to "into" the extension from the patcher option?

@LisoUseInAIKyrios
Copy link
Contributor

Should this be a generic patch that allows spoofing any setting?

How theoretically is such a situation? If there are additional settings that might need spoofing, maybe change this patch to spoof all of them? If other flags are purely theoretically with no known use case, then there may not be a need for such functionality.

@1fexd
Copy link
Contributor Author

1fexd commented Mar 11, 2025

How theoretically is such a situation? If there are additional settings that might need spoofing, maybe change this patch to spoof all of them? If other flags are purely theoretically with no known use case, then there may not be a need for such functionality.

Agreed, I've made some changes

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: Settings spoof poc feat: Add Hide ADB status patch Mar 14, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as ready for review March 14, 2025 19:31
@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Mar 19, 2025 that may be closed by this pull request
3 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 1ea8047 into ReVanced:dev Apr 16, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
# [5.21.0-dev.2](v5.21.0-dev.1...v5.21.0-dev.2) (2025-04-16)

### Features

* Add `Hide ADB status` patch ([#4585](#4585)) ([1ea8047](1ea8047))
github-actions bot pushed a commit that referenced this pull request Apr 25, 2025
# [5.21.0](v5.20.1...v5.21.0) (2025-04-25)

### Bug Fixes

* `Hide ADB status` patch ([#4814](#4814)) ([dc89be0](dc89be0))
* **GmsCore Support:** Correct the description to refer to the app being patched ([2bbcf9d](2bbcf9d))
* **Wide search bar:** Fix patching `19.16.39` ([433dbc3](433dbc3))
* **YouTube - Change start page:** Add option to always override start page on app launch ([#4832](#4832)) ([5062e24](5062e24))
* **YouTube - Disable auto captions:** Correctly hide captions with YT 20.12 ([5ecbe82](5ecbe82))
* **YouTube - Hide video action buttons:** Add option to hide 'Ask' button ([#4852](#4852)) ([43bcf5a](43bcf5a))
* **YouTube - Hide video action buttons:** Hide A/B layout buttons ([4db5d3c](4db5d3c))
* **YouTube - Wide search bar:** Do not force phone layout for tablet devices ([#4827](#4827)) ([0cb38f9](0cb38f9))

### Features

* Add `Hide ADB status` patch ([#4585](#4585)) ([1ea8047](1ea8047))
* **X / Twitter:** Support version `10.86.0-release.0` ([#4805](#4805)) ([655b390](655b390))
* **YouTube - Swipe controls:** Add option for vertical progress bar ([#4811](#4811)) ([ebee07e](ebee07e))
* **YouTube:** Support version `20.12.46` ([#4779](#4779)) ([703359f](703359f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: conceal Android developer options status
3 participants