[AMD] Added Refine-Reschedule hint for rescheduling #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR:
makes Refine pass FuncOp based, instead of ModuleOp
replaces walkers with PatternRewriters
Co-authored-by: ravil-mobile <[email protected]>
Inlined refine ops functions
[AMD] Added `local_alloc` refinement
|
So this is giving us a nop which we should add to every BB that we want refined and rescheduled? |
ravil-mobile
force-pushed
the
refine-ops-pass
branch
2 times, most recently
from
3070646 to
0341d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old hint is very verbose and we don't need any arguments for the new pass - i.e., refine-ops-pass. To keep everything concise, I added a new hint-op which takes no parameters. It is easy to write lit tests