Refine pattern matching rework #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guacamoleo
approved these changes
Apr 28, 2025
|
Hi @binarman. Thanks for the PR.
I like 1) and 2) but I have a concern about 3). It seems to me that we apply refinement to all regions. I would suggest to avoid it at this moment. We can create a dedicated attribute for it. I ran your compile and ran your branch with the pure GEMM problem and bumped into the compilation crash. I found one necessary fix; I am going to make a PR to your branch. |
|
I am going to merge this PR, to unblock the rest of work, feel free to revert it if you think something is wrong. Seems failed integration test are unrelated and failed because wrong runner is used |
ravil-mobile
added a commit
that referenced
this pull request
Jun 23, 2025
This PR:
makes Refine pass FuncOp based, instead of ModuleOp
replaces walkers with PatternRewriters
Co-authored-by: ravil-mobile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: