Improve handling configuration settings #439

randy3k · 2021-06-09T00:22:42Z

Allows settings to be passed via workspace/didChangeConfiguration.
Additionally, options(languageserver.xxxx) has always higher precedence to allow projectwise override.
Also added setting rich_documentaion for less powerful markdown renderer.

Discussion: do we want to set rich_documentaion to default FALSE and enable it manually in vscode-r-lsp?

R/settings.R

randy3k · 2021-06-09T14:48:51Z

R/settings.R

+            snippet_support = TRUE,
+            max_completions = 200,
+            lint_cache = TRUE,
+            server_capabilities = list(),


Perhaps we should have an individual switch for each provider rather than to expose the capabilities.

renkun-ken

LGTM

renkun-ken · 2021-06-21T07:38:36Z

BTW, do we want to support workspace/didChangeConfiguration?

renkun-ken · 2021-06-21T07:41:10Z

Discussion: do we want to set rich_documentaion to default FALSE and enable it manually in vscode-r-lsp?

I guess we could consider this if more users complain about it?

randy3k · 2021-06-21T07:49:34Z

BTW, do we want to support workspace/didChangeConfiguration?

We have supported it already.

languageserver/R/handlers-workspace.R

Line 13 in cd4cbe5

workspace_did_change_configuration <- function(self, params) {

randy3k · 2021-06-21T07:57:22Z

Discussion: do we want to set rich_documentaion to default FALSE and enable it manually in vscode-r-lsp?

I guess we could consider this if more users complain about it?

We could also check MarkdownClientCapabilities. I assume that vscode will return marked.

renkun-ken · 2021-06-21T08:01:24Z

Here is the initialization config from latest vscode:

{
  "processId": 35022,
  "clientInfo": {
    "name": "Visual Studio Code",
    "version": "1.57.1"
  },
  "locale": "en",
  "rootPath": "/home/ken/test",
  "rootUri": "file:///home/ken/test",
  "capabilities": {
    "workspace": {
      "applyEdit": true,
      "workspaceEdit": {
        "documentChanges": true,
        "resourceOperations": [
          "create",
          "rename",
          "delete"
        ],
        "failureHandling": "textOnlyTransactional",
        "normalizesLineEndings": true,
        "changeAnnotationSupport": {
          "groupsOnLabel": true
        }
      },
      "didChangeConfiguration": {
        "dynamicRegistration": true
      },
      "didChangeWatchedFiles": {
        "dynamicRegistration": true
      },
      "symbol": {
        "dynamicRegistration": true,
        "symbolKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25,
            26
          ]
        },
        "tagSupport": {
          "valueSet": [
            1
          ]
        }
      },
      "codeLens": {
        "refreshSupport": true
      },
      "executeCommand": {
        "dynamicRegistration": true
      },
      "configuration": true,
      "workspaceFolders": true,
      "semanticTokens": {
        "refreshSupport": true
      },
      "fileOperations": {
        "dynamicRegistration": true,
        "didCreate": true,
        "didRename": true,
        "didDelete": true,
        "willCreate": true,
        "willRename": true,
        "willDelete": true
      }
    },
    "textDocument": {
      "publishDiagnostics": {
        "relatedInformation": true,
        "versionSupport": false,
        "tagSupport": {
          "valueSet": [
            1,
            2
          ]
        },
        "codeDescriptionSupport": true,
        "dataSupport": true
      },
      "synchronization": {
        "dynamicRegistration": true,
        "willSave": true,
        "willSaveWaitUntil": true,
        "didSave": true
      },
      "completion": {
        "dynamicRegistration": true,
        "contextSupport": true,
        "completionItem": {
          "snippetSupport": true,
          "commitCharactersSupport": true,
          "documentationFormat": [
            "markdown",
            "plaintext"
          ],
          "deprecatedSupport": true,
          "preselectSupport": true,
          "tagSupport": {
            "valueSet": [
              1
            ]
          },
          "insertReplaceSupport": true,
          "resolveSupport": {
            "properties": [
              "documentation",
              "detail",
              "additionalTextEdits"
            ]
          },
          "insertTextModeSupport": {
            "valueSet": [
              1,
              2
            ]
          }
        },
        "completionItemKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25
          ]
        }
      },
      "hover": {
        "dynamicRegistration": true,
        "contentFormat": [
          "markdown",
          "plaintext"
        ]
      },
      "signatureHelp": {
        "dynamicRegistration": true,
        "signatureInformation": {
          "documentationFormat": [
            "markdown",
            "plaintext"
          ],
          "parameterInformation": {
            "labelOffsetSupport": true
          },
          "activeParameterSupport": true
        },
        "contextSupport": true
      },
      "definition": {
        "dynamicRegistration": true,
        "linkSupport": true
      },
      "references": {
        "dynamicRegistration": true
      },
      "documentHighlight": {
        "dynamicRegistration": true
      },
      "documentSymbol": {
        "dynamicRegistration": true,
        "symbolKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25,
            26
          ]
        },
        "hierarchicalDocumentSymbolSupport": true,
        "tagSupport": {
          "valueSet": [
            1
          ]
        },
        "labelSupport": true
      },
      "codeAction": {
        "dynamicRegistration": true,
        "isPreferredSupport": true,
        "disabledSupport": true,
        "dataSupport": true,
        "resolveSupport": {
          "properties": [
            "edit"
          ]
        },
        "codeActionLiteralSupport": {
          "codeActionKind": {
            "valueSet": [
              "",
              "quickfix",
              "refactor",
              "refactor.extract",
              "refactor.inline",
              "refactor.rewrite",
              "source",
              "source.organizeImports"
            ]
          }
        },
        "honorsChangeAnnotations": false
      },
      "codeLens": {
        "dynamicRegistration": true
      },
      "formatting": {
        "dynamicRegistration": true
      },
      "rangeFormatting": {
        "dynamicRegistration": true
      },
      "onTypeFormatting": {
        "dynamicRegistration": true
      },
      "rename": {
        "dynamicRegistration": true,
        "prepareSupport": true,
        "prepareSupportDefaultBehavior": 1,
        "honorsChangeAnnotations": true
      },
      "documentLink": {
        "dynamicRegistration": true,
        "tooltipSupport": true
      },
      "typeDefinition": {
        "dynamicRegistration": true,
        "linkSupport": true
      },
      "implementation": {
        "dynamicRegistration": true,
        "linkSupport": true
      },
      "colorProvider": {
        "dynamicRegistration": true
      },
      "foldingRange": {
        "dynamicRegistration": true,
        "rangeLimit": 5000,
        "lineFoldingOnly": true
      },
      "declaration": {
        "dynamicRegistration": true,
        "linkSupport": true
      },
      "selectionRange": {
        "dynamicRegistration": true
      },
      "callHierarchy": {
        "dynamicRegistration": true
      },
      "semanticTokens": {
        "dynamicRegistration": true,
        "tokenTypes": [
          "namespace",
          "type",
          "class",
          "enum",
          "interface",
          "struct",
          "typeParameter",
          "parameter",
          "variable",
          "property",
          "enumMember",
          "event",
          "function",
          "method",
          "macro",
          "keyword",
          "modifier",
          "comment",
          "string",
          "number",
          "regexp",
          "operator"
        ],
        "tokenModifiers": [
          "declaration",
          "definition",
          "readonly",
          "static",
          "deprecated",
          "abstract",
          "async",
          "modification",
          "documentation",
          "defaultLibrary"
        ],
        "formats": [
          "relative"
        ],
        "requests": {
          "range": true,
          "full": {
            "delta": true
          }
        },
        "multilineTokenSupport": false,
        "overlappingTokenSupport": false
      },
      "linkedEditingRange": {
        "dynamicRegistration": true
      }
    },
    "window": {
      "showMessage": {
        "messageActionItem": {
          "additionalPropertiesSupport": true
        }
      },
      "showDocument": {
        "support": true
      },
      "workDoneProgress": true
    },
    "general": {
      "regularExpressions": {
        "engine": "ECMAScript",
        "version": "ES2020"
      },
      "markdown": {
        "parser": "marked",
        "version": "1.1.0"
      }
    }
  },
  "trace": "off",
  "workspaceFolders": [
    {
      "uri": "file:///home/ken/test",
      "name": "test"
    }
  ]
}

renkun-ken · 2021-06-21T08:03:11Z

Discussion: do we want to set rich_documentaion to default FALSE and enable it manually in vscode-r-lsp?

I guess we could consider this if more users complain about it?

We could also check MarkdownClientCapabilities. I assume that vscode will return marked.

Yes, it would be much nicer. What do other clients show?

randy3k · 2021-06-21T08:12:47Z

I believe that most other clients do not return anything.

R/completion.R

randy3k · 2021-06-22T08:21:55Z

@renkun-ken it seems that there is a problem to enable lint_cache of lintr. Specially, running lintr via callr with cache = TRUE seems to trigger this error in CI:

[2021-06-22 07:36:06.604] diagnostics_task: <callr_status_error: callr subprocess failed: cannot open the connection>
 in process 
-->
<callr_remote_error in gzfile(file, "wb"):
 cannot open the connection>
 in process 5116

However I could not reproduce it locally.

renkun-ken · 2021-06-22T09:07:03Z

Thanks for the fix. Not sure about the cache problem either.

eitsupi · 2021-06-22T15:36:38Z

README.md

+settings | default | description
+----     | -----   | -----
+`debug`  | `false` | increase verbosity for debug purpose
+`log_file` | `nil` | file to log debug messages, fallback to stderr if empty


it is nil, not null?

You are right. Too much golang this week.

randy3k added 2 commits June 8, 2021 17:20

Improve handling configuration settings

3f3296d

document()

01ddd25

randy3k mentioned this pull request Jun 9, 2021

[WIP] an option to disable rich documentation #438

Closed

renkun-ken reviewed Jun 9, 2021

View reviewed changes

R/settings.R Show resolved Hide resolved

randy3k commented Jun 10, 2021

View reviewed changes

Update README.md

cd4cbe5

randy3k changed the title ~~[WIP] Improve handling configuration settings~~ Improve handling configuration settings Jun 21, 2021

randy3k requested a review from renkun-ken June 21, 2021 06:12

renkun-ken approved these changes Jun 21, 2021

View reviewed changes

renkun-ken reviewed Jun 21, 2021

View reviewed changes

R/completion.R Show resolved Hide resolved

use cat to append to log file

3d717c6

randy3k force-pushed the settings branch 2 times, most recently from ca89d28 to 4a09b68 Compare June 22, 2021 07:46

disable lint_cache

c7b6a28

randy3k force-pushed the settings branch from 4a09b68 to c7b6a28 Compare June 22, 2021 08:14

pass cache arg directly to diagnose_file

2a8e4c4

use <at>noRd instead

4724e42

randy3k merged commit 7f9a8d6 into master Jun 22, 2021

randy3k deleted the settings branch June 22, 2021 14:53

eitsupi reviewed Jun 22, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve handling configuration settings #439

Improve handling configuration settings #439

randy3k commented Jun 9, 2021 •

edited

Loading

randy3k Jun 9, 2021

renkun-ken left a comment

renkun-ken commented Jun 21, 2021

renkun-ken commented Jun 21, 2021

randy3k commented Jun 21, 2021

randy3k commented Jun 21, 2021

renkun-ken commented Jun 21, 2021 •

edited

Loading

renkun-ken commented Jun 21, 2021

randy3k commented Jun 21, 2021

randy3k commented Jun 22, 2021 •

edited

Loading

renkun-ken commented Jun 22, 2021

eitsupi Jun 22, 2021

randy3k Jun 22, 2021

Improve handling configuration settings #439

Improve handling configuration settings #439

Conversation

randy3k commented Jun 9, 2021 • edited Loading

randy3k Jun 9, 2021

Choose a reason for hiding this comment

renkun-ken left a comment

Choose a reason for hiding this comment

renkun-ken commented Jun 21, 2021

renkun-ken commented Jun 21, 2021

randy3k commented Jun 21, 2021

randy3k commented Jun 21, 2021

renkun-ken commented Jun 21, 2021 • edited Loading

renkun-ken commented Jun 21, 2021

randy3k commented Jun 21, 2021

randy3k commented Jun 22, 2021 • edited Loading

renkun-ken commented Jun 22, 2021

eitsupi Jun 22, 2021

Choose a reason for hiding this comment

randy3k Jun 22, 2021

Choose a reason for hiding this comment

randy3k commented Jun 9, 2021 •

edited

Loading

renkun-ken commented Jun 21, 2021 •

edited

Loading

randy3k commented Jun 22, 2021 •

edited

Loading