Skip to content

[WIP] an option to disable rich documentation #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

randy3k
Copy link
Member

@randy3k randy3k commented Jun 6, 2021

it is needed for editor with less fancy markdown renderer.

Shall we actually turn it off as default and only provide the rich markdown if client to specify via
MarkdownClientCapabilities? I imagine vscode-r-lsp could enable it by default.

it is needed for editor with less fancy markdown renderer
@randy3k randy3k force-pushed the disable_rich_documentation branch from 38fd441 to e4057a7 Compare June 6, 2021 07:15
@randy3k
Copy link
Member Author

randy3k commented Jun 6, 2021

Actually, now I am thinking that we should less depend on settings via .Rprofile but utilizing the workspace/didChangeConfiguration. So ignore this PR for now, I will come back with a better solution.

@randy3k
Copy link
Member Author

randy3k commented Jun 6, 2021

We have the following settings

languageserver.snippet_support
languageserver.max_completions
languageserver.lint_cache
languageserver.formatting_style
languageserver.server_capabilities
languageserver.link_file_size_limit

I think we should find a way to consistently expose them to workspace/didChangeConfiguration as well as via options from .Rprofile.

@randy3k randy3k changed the title an option to disable rich documentation [WIP] an option to disable rich documentation Jun 6, 2021
@randy3k
Copy link
Member Author

randy3k commented Jun 9, 2021

closed in flavor of #439

@randy3k randy3k closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant