Skip to content

Go To dialog - make similar to Find/Replace #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProgerXP opened this issue Feb 10, 2020 · 1 comment
Closed

Go To dialog - make similar to Find/Replace #260

ProgerXP opened this issue Feb 10, 2020 · 1 comment
Assignees

Comments

@ProgerXP
Copy link
Owner

ProgerXP commented Feb 10, 2020

Go To conceptually is very much like Find and Replace but currently there are several differences:

  • Go To is modal while Find and Replace are non-modal
  • Go To can be displayed on an empty buffer (the menu command is enabled)

Unless there are some specific reasons, Go To should be made non-modal and its menu command and hotkey must be disabled on an empty buffer (as well as other commands in Edit, below Replace Next).

Also, according to #259 these 3 dialogs must be combined in such a way that only one of them is visible (just like currently you can't display both Find and Replace, you shouldn't be able to display both Go To and Find, for example).

@cshnik
Copy link
Collaborator

cshnik commented Feb 14, 2020

Disabled menu command/hotkey for empty buffer.
All other changes are already implemented in #259 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants