Skip to content

Find/Replace - add Go to Go To #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProgerXP opened this issue Feb 10, 2020 · 11 comments
Closed

Find/Replace - add Go to Go To #259

ProgerXP opened this issue Feb 10, 2020 · 11 comments
Assignees

Comments

@ProgerXP
Copy link
Owner

Currently it's possible to switch between Find to Replace and from Replace to Find without losing the search string via a hyperlink (and a hotkey). Add the same mechanism for Go To (Ctrl+G). In other words, it should be possible to switch from Find or Replace to Go To, as well as from Go To to Find or Replace.

  • add 2 links at the bottom of the Go To dialog (just like current links in Find and Replace)
  • add 1 link "Go to Go To (Ctrl+G)" to above "Go to Replace (Ctrl+H)" in Find
  • add a similar link in Replace
  • make Find and Replace handle Ctrl+G hotkey
  • make Go To handle Ctrl+F and Ctrl+H hotkeys

When switching to Go To - take "Search String" and set it to Line. When switching from Go To - take Line and set it to "Search String".

@cshnik
Copy link
Collaborator

cshnik commented Feb 13, 2020

Done.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Feb 13, 2020
@ProgerXP
Copy link
Owner Author

ProgerXP commented Mar 1, 2020

Bug: open Go To, press Enter, open Go To again - it will not appear (but will if you press Ctrl+G from without Find or Replace).

@ProgerXP ProgerXP reopened this Mar 1, 2020
@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Mar 1, 2020
cshnik added a commit that referenced this issue Mar 2, 2020
@cshnik
Copy link
Collaborator

cshnik commented Mar 2, 2020

Bug: open Go To, press Enter, open Go To again - it will not appear (but will if you press Ctrl+G from without Find or Replace).

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Mar 2, 2020
@ProgerXP
Copy link
Owner Author

ProgerXP commented Mar 3, 2020

Another bug (?): normally Go To's Line defaults to current line but as soon as you do a Find or Replace, Line will be set to last used search string (even if opening the dialog via Ctrl+G in the main window, not from within Find/Replace).

@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Mar 3, 2020
cshnik added a commit that referenced this issue Mar 3, 2020
@cshnik
Copy link
Collaborator

cshnik commented Mar 3, 2020

Fixed. Original Go To's Line defaults (current line index) are always used when opening from main window (no switching from Find/Replace).

@cshnik cshnik assigned ProgerXP and unassigned cshnik Mar 3, 2020
@ProgerXP ProgerXP closed this as completed Mar 8, 2020
@ProgerXP
Copy link
Owner Author

Bug: open Go To, press Enter, open Go To again - it will not appear (but will if you press Ctrl+G from without Find or Replace).

This was fixed if Go To to Line was used but it still happens if going to Offset.

@ProgerXP ProgerXP reopened this Apr 19, 2020
@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Apr 19, 2020
cshnik added a commit that referenced this issue Apr 20, 2020
@cshnik
Copy link
Collaborator

cshnik commented Apr 20, 2020

Bug: open Go To, press Enter, open Go To again - it will not appear (but will if you press Ctrl+G from without Find or Replace).

This was fixed if Go To to Line was used but it still happens if going to Offset.

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Apr 20, 2020
@ProgerXP
Copy link
Owner Author

When switching to Go To - take "Search String" and set it to Line. When switching from Go To - take Line and set it to "Search String".

Doesn't happen if document has non-empty selection:

  1. Select anything
  2. Ctrl+G, change line number
  3. Ctrl+F - Search String must be taken from step 2 but it's taken from step 1 (document selection, this should happen only if opening Find/Replace from the main window)

@ProgerXP ProgerXP reopened this Oct 28, 2021
@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Oct 28, 2021
cshnik added a commit that referenced this issue Nov 29, 2021
@cshnik
Copy link
Collaborator

cshnik commented Nov 29, 2021

Doesn't happen if document has non-empty selection

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Nov 29, 2021
@ProgerXP
Copy link
Owner Author

  1. Open new window
  2. Type anything
  3. Ctrl+G
  4. Ctrl+F

Resulting Find dialog appears at the top left corner of the main window, not centered as it should be. If you open Find standalone (not from Go To) and close it, subsequent Ctrl+G -> Ctrl+F cause Find to display in the proper position.

@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Jan 17, 2022
cshnik added a commit that referenced this issue Aug 1, 2022
@cshnik
Copy link
Collaborator

cshnik commented Aug 1, 2022

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Aug 1, 2022
@ProgerXP ProgerXP closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants