Skip to content

[Decomposition] decomposition of PCPhase as a quantum function #7591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 248 commits into from
Jun 9, 2025
Merged

[Decomposition] decomposition of PCPhase as a quantum function #7591

merged 248 commits into from
Jun 9, 2025

Conversation

astralcai
Copy link
Contributor

Context:

Description of the Change:

Translates the decomposition of PCPhase into a quantum function.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-89611]

astralcai added 30 commits April 29, 2025 10:42
@astralcai
[Decomposition] Custom decomposition rules for symbolic operators
925f8a2
@astralcai
fix doc?
fa09eac
@astralcai
tests and bug fix
95c0383
@astralcai
update changelog
8f0a0de
@astralcai
add more tests
5b074ed
@astralcai
one more test case
ff90882
@astralcai
Merge branch 'master' into symbolic-rules-01
9a57289
@astralcai
pylint
956b9a2
@astralcai
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
a8ccb91 
…o symbolic-rules-01
@astralcai
pylint
32dba0b
@astralcai
Merge branch 'master' of https://github.com/PennyLaneAI/pennylane int…
edff8d4 
…o symbolic-rules-01
@astralcai
[Decomposition] Clean up custom logic for adjoint and pow
7b37f5b
@astralcai
changelog
9483966
@astralcai
pylint and black
9a141f7
@astralcai
ooops
8551113
@astralcai
unused import
a3705e8
@astralcai
remove test
12a52c1
@astralcai
add missing coverage
7a0d0d1
@astralcai
tests and missing coverage
7188cee
@astralcai
fix test
58a3b4d
@astralcai
fix siswap and tests
499cf59
@astralcai
ooops
82c8780
@astralcai
add missing coverage
85f0485
@astralcai
missing coverage
46a18a0
@astralcai
changelog
92f0b84
@astralcai
revert some changes
2060ca1
@astralcai
[Decomposition] Clean up custom logic for Controlled decompositions
5bc807f
@astralcai
changelog
80088bd
@astralcai
rename something
92d73c4
@astralcai
missing coverage
399f7b9
@mudit2812
Copy link
Contributor

Could you remove [WIP] from the PR title?

@astralcai astralcai changed the title [WIP] [Decomposition] decomposition of PCPhase as a quantum function [Decomposition] decomposition of PCPhase as a quantum function Jun 5, 2025
mudit2812
mudit2812 approved these changes Jun 6, 2025
View reviewed changes
Base automatically changed from work-wire to master June 6, 2025 21:30
andrijapau
andrijapau requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the import clean-ups. I'm happy with the implementation just a few questions about the logic clean-up for wires initialization.

@astralcai astralcai requested a review from andrijapau June 9, 2025 13:49
andrijapau
andrijapau approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift change - LGTM!

@astralcai astralcai enabled auto-merge June 9, 2025 14:08
@astralcai astralcai added this pull request to the merge queue Jun 9, 2025
Merged via the queue into master with commit b6fe9e4 Jun 9, 2025
53 checks passed
@astralcai astralcai deleted the pcphase-decomp branch June 9, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit2812 mudit2812 mudit2812 approved these changes

@andrijapau andrijapau andrijapau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astralcai @mudit2812 @andrijapau