-
Notifications
You must be signed in to change notification settings - Fork 672
Add filecheck
tests for xDSL cancel_inverses
and merge_rotations
passes
#7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7595 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 531 531
Lines 51896 51896
=======================================
Hits 51732 51732
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Whenever you merge this, can you do me a solid and erase this line? 60cf928#diff-51b5c9761bc1138cebc4b7183e5f41a7d67d42f7833e5be5072d332681cc2558R140 In case the link doesn't work, there's an extra print on line 140 |
@erick-xanadu done in 5852fe2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I can use the same style for the tests on decompositions 👍
Shouldn't the MergeRotationsPass
be called IterativeMergeRotationsPass
as well?
[sc-92245]
IterativeCancelInversesPass
andMergeRotationsPass
.run_filecheck
fixture to make it easier to use thefilecheck
utility.Blocked by #7590 as I would like to update the tests to use the custom assembly format of
CustomOp
instead of the generic syntax.