Skip to content

Add filecheck tests for xDSL cancel_inverses and merge_rotations passes #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 5, 2025

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Jun 3, 2025

[sc-92245]

  • Add lit tests for IterativeCancelInversesPass and MergeRotationsPass.
  • Add run_filecheck fixture to make it easier to use the filecheck utility.
  • Fix issues found with both passes when dealing with controlled gates during testing.

Blocked by #7590 as I would like to update the tests to use the custom assembly format of CustomOp instead of the generic syntax.

@mudit2812 mudit2812 marked this pull request as ready for review June 4, 2025 14:29
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (a4a14be) to head (4a7f224).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7595   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files         531      531           
  Lines       51896    51896           
=======================================
  Hits        51732    51732           
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@erick-xanadu
Copy link
Contributor

erick-xanadu commented Jun 4, 2025

Whenever you merge this, can you do me a solid and erase this line? 60cf928#diff-51b5c9761bc1138cebc4b7183e5f41a7d67d42f7833e5be5072d332681cc2558R140

In case the link doesn't work, there's an extra print on line 140

@mudit2812
Copy link
Contributor Author

Whenever you merge this, can you do me a solid and erase this line? 60cf928#diff-51b5c9761bc1138cebc4b7183e5f41a7d67d42f7833e5be5072d332681cc2558R140

In case the link doesn't work, there's an extra print on line 140

@erick-xanadu done in 5852fe2

Copy link
Member

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I can use the same style for the tests on decompositions 👍

Shouldn't the MergeRotationsPass be called IterativeMergeRotationsPass as well?

@mudit2812 mudit2812 enabled auto-merge June 5, 2025 19:43
@mudit2812 mudit2812 added this pull request to the merge queue Jun 5, 2025
Merged via the queue into master with commit 04c4144 Jun 5, 2025
52 of 53 checks passed
@mudit2812 mudit2812 deleted the xdsl-transform-tests branch June 5, 2025 20:32
astralcai added a commit that referenced this pull request Jun 5, 2025
astralcai added a commit that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants