Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI Eridani: Detective content update #27512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CSI Eridani: Detective content update #27512
Changes from 27 commits
ef9139f
ba7292a
577c794
60c7b72
fc74f0d
63579e3
375121e
5bb74a0
202d2ea
0efb25b
ebde63c
2ce6282
e94d3c9
feda2ee
cc09cac
ded3080
344c16e
49f5f7a
7ca6915
5d1b0a2
8b6844d
9290b5e
fd3d7f6
8f13d75
2adaa82
4a6717f
d717549
26ce1c4
8dc4645
1c77433
938112d
b2be54f
a78c5a4
c8c4e4e
568a34f
df6dde5
3ffde65
e177887
e96137d
7175a4f
33f983c
fba6773
2fea276
d068f59
3fa0fb6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proc can be cleaned up by using a guard clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the icon state in an update_icon_state() override, and then invoke update_appearance() with the right flags here, instead?