Skip to content

Explorer Overhaul and Gateway Retirement #20855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 3, 2023

Conversation

OctusGit
Copy link
Contributor

@OctusGit OctusGit commented Apr 11, 2023

What Does This PR Do

This PR enables Explorers as a roundstart role, offering 4 slots in pre-game, like other roles. A new spawn room equipped with survival gear, such as flashlights, small medkits, picks, shovels, etc., is introduced for explorers. Consequently, the gateway areas on stations are now gear rooms for explorers and no longer contain gateways. Explorer exploration will now focus solely on space ruins and space itself.

Why It's Good For The Game

Roundstart Explorers:

A PR for roundstart explorers was proposed five years ago but rejected due to the prevailing climate of Paradise at the time.
#6431
The addition of roundstart explorer roles has some clear advantages:

  1. It eliminates the inconvenience of roundstart queueing and waiting for a HoP. Though Explorers remain under the HoP's supervision, this change reduces setup times, as the previous PR aptly stated:

This PR removes that artificial barrier of going to the HoP for access.

  1. Offering more roles enhances players' learning experiences and simplifies access to new jobs. Explorer is already a popular role, so it makes sense to officially recognize it as a job, given the existing infrastructure and code support.

  2. To further legitimize Explorers as a job, the gateway room will be transformed into a spawn area/locker room for gearing up for exploration.

Retirement of Gateway

The gateway has some fundamental issues, summarized as follows:

  1. It detracts from gameplay by providing an easy, risk-free escape from problems, favoring antagonists and reducing tension during crises.

  2. It lacks new content and proper management, resembling abandoned features like space pods. Without interest in addressing its issues or expanding on it, the gateway has become obsolete. The only available map is the beach.

  3. Removing the gateway promotes space exploration and consolidates focus on one area, improving the overall experience, as evidenced by points 1 and 2.

  4. As a bonus critique, the newest map, Farragus, lacks a gateway or portal, indicating a declining or aging mechanic.

Given these points, retiring the gateway and adding Explorers as a roundstart job would benefit both the server and the explorer role. This change would legitimize Explorers as an official roundstart role and concentrate exploration maps solely on space and space ruins, streamlining the job and allowing for a more focused allocation of resources and time for role-related content.

Images of changes

StrongDMM_4W2wSAAdU3

Testing

Tested, explorer options are available

Changelog

🆑
tweak: You can now become an explorer on roundstart, 4 slots are open on roundstart
tweak: The Gateway room has been converted into a gear room for roundstart explorers
add: Added an expedition room to Cere station inside EVA
add: added some new zone and landmark sprites
del: Removes Gateway and its unused content from the code
del: Removed bloat maps like evil_santa and example map
/:cl:

@DGamerL
Copy link
Member

DGamerL commented Apr 11, 2023

Yes.

@ParadiseSS13-Bot ParadiseSS13-Bot added BoxStation This PR will edit the map BoxStation (Cyberiad) -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Apr 11, 2023
@kano-dot
Copy link
Contributor

Removal of gateway had it coming for sure, though i think it'd be sad to lose beach party area. There's still a lavaland ruin that may aswell serve the same purpose as this one did but it's clearly not the same.

spider and USSP gateway had it own issues to not remain as space ruins but i think there's no reason to not have beach party surface area (excluding underwater and pirate camp side parts) as a space ruin like what has been applied to xenomorph station, just an opinion.

@ATP-Engineer
Copy link
Contributor

Maybe in a way, a rework of the gateway to be an actual station project varying between rounds like the BSA/Harvester makes sense, and opens for SO MUCH MORE possibilities in a fully fleshed out fine tuning of the feature.

@ParadiseSS13-Bot ParadiseSS13-Bot added the Configuration Change This PR changes the game configuration files. Please run via the host. label Apr 12, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added DeltaStation This PR will edit the map DeltaStation (Kerberos) MetaStation This PR will edit the map MetaStation (Cerebron) labels Apr 12, 2023
@GDNgit
Copy link
Contributor

GDNgit commented Apr 12, 2023

Please keep tiny test, it's helpful for testing

@ParadiseSS13-Bot ParadiseSS13-Bot added the Sprites This PR modifies the game sprites label Apr 12, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added the CereStation This PR edits the map CereStation (Farragus) label Apr 12, 2023
@OctusGit OctusGit marked this pull request as ready for review April 12, 2023 03:53
@OctusGit OctusGit requested a review from AffectedArc07 as a code owner April 12, 2023 03:53
@pismorizzo
Copy link

pismorizzo commented Apr 12, 2023

As someone who has played an intense amount of explorer and abused gateway even beach alot, it sadly does have to go. Only thing I can add is that you should add some jetpacks to the gear room so the 3-4 explorers don't have to fight over the 2 that are in EVA on most maps and can leave them for other crewmembers to use.

@Sadhorizon
Copy link
Contributor

Sadhorizon commented Apr 12, 2023

Okay, one thing that PROBABLY should be changed alongside making explorer a job, is their starting uniform. AT THE VERY LEAST they shouldn't have a randomly colored jumpsuit and black shoes, unless we really want them to feel like assistant+ (which we probably don't)

Besides it however, I do like the idea behind this PR and am curious to see it in practice.

@SynthTwo
Copy link
Contributor

My poor gateway... What have they done to my BOI!

Otherwise, good change. But I hope we add more things to Space once this is added... Because space is really lacking and tedious.

oh yeah for sure, space is a bit predictable right now. its always get cool loot, come back and get arrested cause cool loot is contraband lmfao. more stuff added would be cool. i wonder if randomizing space each round could become possible?

@AffectedArc07
Copy link
Member

i wonder if randomizing space each round could become possible?

It is

@OctusGit
Copy link
Contributor Author

It is

they prob mean like, having randomized generated ruins, which I feel would just make alot of really shitty or garbage quality ruins

@SynthTwo
Copy link
Contributor

It is

they prob mean like, having randomized generated ruins, which I feel would just make alot of really shitty or garbage quality ruins

yup thats what i meant, my bad, but yeah it probably would do shitty ruins sadly. or just insanely amazing one; pain to balance. either way, hopefully this PR will encourage people to update space exploring even more

@hal9000PR hal9000PR added the Feature This PR is a new addition to the game label Apr 14, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Apr 14, 2023
@Ordosian
Copy link
Contributor

yup thats what i meant, my bad, but yeah it probably would do shitty ruins sadly. or just insanely amazing one; pain to balance. either way, hopefully this PR will encourage people to update space exploring even more

Space uses the Nightmare system basically. Inserts ruins into the space z levels. Making it create randomized ruins is basically impossible. You would have to make different presets for each ruin so then the nightmare system could choose from that and insert it.

@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Apr 26, 2023
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config changes approved

@Sirryan2002
Copy link
Contributor

remind me to look at this more in the following week if there's not more approving reviews by Monday/Tuesday

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label May 22, 2023
@Henri215
Copy link
Contributor

image
Forgot to remove that shutter button? (Cyberiad)

Copy link
Member

@SteelSlayer SteelSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good.

Please remove the button that Henri mentioned, and then deconflict.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jun 3, 2023
@SteelSlayer SteelSlayer merged commit 98ddced into ParadiseSS13:master Jun 3, 2023
@OctusGit OctusGit deleted the gateway-removal branch June 14, 2023 20:32
@ItsMarmite ItsMarmite mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge BoxStation This PR will edit the map BoxStation (Cyberiad) CereStation This PR edits the map CereStation (Farragus) Configuration Change This PR changes the game configuration files. Please run via the host. DeltaStation This PR will edit the map DeltaStation (Kerberos) Feature This PR is a new addition to the game Map Edit This PR will modify a map Merge Conflict This PR is merge conflicted MetaStation This PR will edit the map MetaStation (Cerebron) Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.