Rover: Remove deprecated module

[chfriedrich98]

Solved Problem

Remove the old rover module. its gazebo classic airframes, the related mavros test and the documentation.
This module has been fully replaced by the new rover type specific modules for ackermann, differential and mecanum.

[sfuhrer]

Did you check if you also have to remove some documentation? E.g. for the gazebo classic rover frames?

[chfriedrich98]

rebased on main (no changes)

[chfriedrich98]

@sfuhrer

Did you check if you also have to remove some documentation? E.g. for the gazebo classic rover frames?

Good point!
Removed the documentation for the deprecated module and for the gazebo classic simulation

[sfuhrer]

@hamishwillee can you advise on this CI failure?
Christian removed an asset the surrounding text from the English docs, but now the other language versions are missing the asset.

[chfriedrich98]

rebased on main and cleaned up commits (no changes)

[chfriedrich98]

Rebase on main to fix the merge issues in the documentation caused by #25103.
No changes to the first 2 commits.

[Jaeyoung-Lim]

Does this mean that we don't support rover in gz classic anymore?

[chfriedrich98]

@Jaeyoung-Lim

Does this mean that we don't support rover in gz classic anymore?

Yes. The new rover modules never supported gz classic and the thought process is that since that version of gazebo has reached its end of life in january, it is not worth the effort to make the new modules "backwards compatible" (which is not straight forward).
What is your opinion on this?

Also I am currently working on overhauling the gz harmonic simulations for rovers by adding more/improved models and solving the licencing issues we had in PX4/PX4-gazebo-models#67.

[Jaeyoung-Lim]

@chfriedrich98 Makes sense from a maintanance perspective, but might be sad for some people who have been using rover.

However, I think this is your call and probably best for rover moving forward. Could you then please remove all the rover models from gazebo classic submodule as well?

[hamishwillee]

@hamishwillee can you advise on this CI failure? Christian removed an asset the surrounding text from the English docs, but now the other language versions are missing the asset.

Not caused by this. There was a file that should have been deleted referencing a removed asset.

I fixed in another PR and rebased this on main, and it should disappear.

@chfriedrich98 It can be useful to delete a translation along with the English version of a file. I normally leave that though and sort it all out in a post process.

[hamishwillee]

@chfriedrich98

1. Did you also search for the filenames of the deleted files? I think there might be a break in the v1.16 release note
2. Can you add a doc release note in main.md
3. Thank you. LGTM.

I think this is a good thing to do, though I would love it if it was a "swap" - i.e. new rover enabled in firmware by default and the old rover something you could add with a module. But perhaps a clean break is for the best - this is already much better.

Does this mean there will be room for the new rover modules in standard builds?

[chfriedrich98]

@Jaeyoung-Lim

Could you then please remove all the rover models from gazebo classic submodule as well?

Will do 👍

[chfriedrich98]

@hamishwillee

Does this mean there will be room for the new rover modules in standard builds?

For some boards it might, but boards like v5x or v6x didn't have the old module enabled so unfortunately this doesn't clear up any space on those.

[chfriedrich98]

Rebased to get doc changes from #25103.

[chfriedrich98]

@hamishwillee

It can be useful to delete a translation along with the English version of a file.

Deleted the translation files in e5efa2e.

Can you add a doc release note in main.md

Added in e5efa2e.

[Pedro-Roque]

@chfriedrich98 perhaps a way to address Jaey's comment would be to have a doc linked, with the release notes of the deprecated module, explaining how to get the same funcitonality from the new ones.

[chfriedrich98]

@Pedro-Roque

perhaps a way to address Jaey's comment would be to have a doc linked, with the release notes of the deprecated module, explaining how to get the same funcitonality from the new ones.

I created a complete step-by-step guide on how to setup rovers and the new modules offer way more features/costumization then the old one.
The documentation for the old module was very limited, so if someone wants to start using PX4 for rovers (or used the old module) they are much better off by following the new step-by-step guide than searching for similarities between the old and new modules.

[chfriedrich98]

Rebased on main to resolve merge issues caused by #25139 and combined doc commits into one.
No actual changes.

[Jaeyoung-Lim]

@chfriedrich98 Reminder to remove models from gz classic

Could you then please remove all the rover models from gazebo classic submodule as well?

[chfriedrich98]

rebased to resolve merge issues of the docs changes

[chfriedrich98]

@Jaeyoung-Lim

Reminder to remove models from gz classic

Removed them here: PX4/PX4-SITL_gazebo-classic#1071

[github-actions]

No flaws found