Skip to content

fix(typography): modify .lead values to match the DSM body text #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(typography): modify .lead values to match the DSM body text #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions scss/_type.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ h2,
.lead {
@include font-size($h6-font-size);
font-weight: $lead-font-weight;
line-height: $h6-line-height;
line-height: $lead-line-height;

/* rtl:remove */
letter-spacing: $h6-spacing;
Expand Down Expand Up @@ -119,14 +119,20 @@ h2,

h4,
h5,
h6,
.lead {
h6 {
@include font-size($h5-font-size);
line-height: $h5-line-height;

/* rtl:remove */
letter-spacing: $h5-spacing;
}

.lead {
@include font-size($h5-font-size);

/* rtl:remove */
letter-spacing: $h5-spacing;
}
}

@include media-breakpoint-up(lg) {
Expand Down Expand Up @@ -194,7 +200,6 @@ h2,

.lead {
@include font-size($lead-font-size);
line-height: $lead-line-height;

/* rtl:remove */
letter-spacing: $lead-letter-spacing;
Expand Down
2 changes: 1 addition & 1 deletion scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ $display-line-height: $h1-line-height !default;
$lead-font-size: $font-size-xlg !default;
$lead-font-weight: 400 !default;
$lead-line-height: 1.5 !default;
$lead-letter-spacing: $letter-spacing-base * 2.5 !default;
$lead-letter-spacing: $letter-spacing-base * 4 !default;

$small-font-size: .875rem !default;

Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/5.3/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ If you need more details about the changes, please refer to the [v5.3.3 release]
- <span class="badge text-bg-success">New</span> List group with badges has been added to Orange Design System specifications and can now be used in your websites.
- <span class="badge text-bg-warning">Warning</span> List group font weight is now bold by default. Please check that it doesn't break your design.

### Contents

- <span class="badge text-bg-warning">Warning</span> The `.lead` class has been updated to reflect the new font size values. Please check that it doesn't break your design.

### Forms

- <span class="badge text-bg-warning">Warning</span> Quantity selector has been updated to ensure a proper visible focus state and the `.input-group` class has been removed. Make sure to incorporate these changes into your websites.
Expand Down