Skip to content

fix(typography): modify .lead values to match the DSM body text #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Nov 8, 2023

Description

This PR fixes the .lead values (font-size, line-height and letter-spacing) for this class to match the body text definition in the DSM's design token (ods.web.sys.font.body.m).

This is needed for projects willing to have a less condensed rendering for articles for instance.

They are the following:

Size font-size line-height letter-spacing
Desktop 20px 1.5=30px -0.40px
Tablet 18px 1.5=27px -0.20px
Mobile 16px 1.5=24px -0.10px

The review must double-check these 3 values for each size: desktop, mobile and tablet.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Checklist (for Core Team only)

  • My change introduces changes to the migration guide

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 15ea1a5
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/654b8e55a473150008133525
😎 Deploy Preview https://deploy-preview-2363--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-jd-fix-lead-values branch 2 times, most recently from a581232 to 4ba79d3 Compare November 8, 2023 11:04
@julien-deramond julien-deramond marked this pull request as ready for review November 8, 2023 11:08
@julien-deramond julien-deramond force-pushed the main-jd-fix-lead-values branch from 4ba79d3 to 15ea1a5 Compare November 8, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants