Skip to content

Fix PHP 8 Fatal error: Uncaught ValueError: imagecolorsforindex() in Varien_Image_Adapter_Gd2 #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iamniels
Copy link
Contributor

@iamniels iamniels commented Jun 6, 2022

Description (*)

Fixes an issue which can occur using PHP >= 8.0.0 and certain images

Fixed Issues (if relevant)

  1. Fixes PHP 8 Fatal error: Uncaught ValueError: imagecolorsforindex() in Varien_Image_Adapter_Gd2 #2185

Manual testing scenarios (*)

See issue

@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* labels Jun 6, 2022
Copy link
Contributor

@luigifab luigifab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fix the fatal error for me.
I also found that: https://stackoverflow.com/a/3898007/2980105

@fballiano fballiano merged commit 45db076 into OpenMage:1.9.4.x Jun 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 45db076. ± Comparison against base commit 02bd670.

@iamniels iamniels deleted the Fix_PHP_8_Fatal_error_Uncaught_ValueError_imagecolorsforindex()_in_Varien_Image_Adapter_Gd2_#2185 branch June 8, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8 Fatal error: Uncaught ValueError: imagecolorsforindex() in Varien_Image_Adapter_Gd2
3 participants