PHP 8 Fatal error: Uncaught ValueError: imagecolorsforindex() in Varien_Image_Adapter_Gd2 (#2197)

iamniels · web-flow · commit 45db07674989 · 2022-06-06T09:21:20.000+01:00
diff --git a/lib/Varien/Image/Adapter/Gd2.php b/lib/Varien/Image/Adapter/Gd2.php
@@ -268,7 +268,7 @@ private function _fillBackgroundColor(&$imageResourceTo)
                 // fill image with indexed non-alpha transparency
                 elseif (false !== $transparentIndex) {
                     $transparentColor = false;
-                    if ($transparentIndex >=0 && $transparentIndex <= imagecolorstotal($this->_imageHandler)) {
+                    if ($transparentIndex >=0 && $transparentIndex < imagecolorstotal($this->_imageHandler)) {
                         list($r, $g, $b)  = array_values(imagecolorsforindex($this->_imageHandler, $transparentIndex));
                         $transparentColor = imagecolorallocate($imageResourceTo, $r, $g, $b);
                     }

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ private function _fillBackgroundColor(&$imageResourceTo)`
`268`	`268`	`// fill image with indexed non-alpha transparency`
`269`	`269`	`elseif (false !== $transparentIndex) {`
`270`	`270`	`$transparentColor = false;`
`271`		`- if ($transparentIndex >=0 && $transparentIndex <= imagecolorstotal($this->_imageHandler)) {`
	`271`	`+ if ($transparentIndex >=0 && $transparentIndex < imagecolorstotal($this->_imageHandler)) {`
`272`	`272`	`list($r, $g, $b) = array_values(imagecolorsforindex($this->_imageHandler, $transparentIndex));`
`273`	`273`	`$transparentColor = imagecolorallocate($imageResourceTo, $r, $g, $b);`
`274`	`274`	`}`