[backend] now also send stream message in digest notifications (#8685)

opencti-platform/opencti-graphql/src/manager/notificationManager.ts

@@ -91,7 +91,7 @@
   type: 'digest'
   target: NotificationUser
   playbook_source?: string
-  data: Array<{ notification_id: string, instance: StixObject, type: string, message: string }>
+  data: Array<{ notification_id: string, instance: StixObject, type: string, message: string, origin?: Partial<UserOrigin>, streamMessage?: string }>
 }
 
 export const isLiveKnowledge = (n: ResolvedTrigger): n is ResolvedLive => {
@@ -598,6 +598,8 @@
               type: userTarget?.type ?? type,
               instance: n.data,
               message: await generateNotificationMessageForInstance(context, user, n.data),
+              origin: n.origin,
+              streamMessage: n.streamMessage
             });
           });
           const data = await Promise.all(dataPromises);

opencti-platform/opencti-graphql/src/manager/publisherManager.ts

@@ -24,7 +24,7 @@
 import { ENTITY_TYPE_SETTINGS, ENTITY_TYPE_USER } from '../schema/internalObject';
 import type { SseEvent, StreamNotifEvent } from '../types/event';
 import type { BasicStoreSettings } from '../types/settings';
-import type { AuthContext, AuthUser } from '../types/user';
+import type { AuthContext, AuthUser, UserOrigin } from '../types/user';
 import { executionContext, SYSTEM_USER } from '../utils/access';
 import { now } from '../utils/format';
 import type { NotificationData } from '../utils/publisher-mock';
@@ -175,31 +175,45 @@
   }
 };
 
+const createFullNotificationMessage = (notificationMessage: string, usersMap: Map<string, AuthUser>, streamMessage?: string, origin?: Partial<UserOrigin>) => {
+  let fullMessage = notificationMessage;
+  if (origin && streamMessage) {
+    const { user_id } = origin;
+    const streamUser = usersMap.get(user_id ?? '');
+    if (streamUser) {
+      const streamBuiltMessage = `\`${streamUser.name}\` ${streamMessage}`;
+      if (streamBuiltMessage !== notificationMessage) {
+        fullMessage = `${notificationMessage} - ${streamBuiltMessage}`;
+      }
+    }
+  }
+
+  return fullMessage;
+};
+
 const processLiveNotificationEvent = async (
   context: AuthContext,
   notificationMap: Map<string, BasicStoreEntityTrigger>,
   event: KnowledgeNotificationEvent | ActivityNotificationEvent | ActionNotificationEvent
 ) => {
-  const { targets, data: instance, origin: { user_id } } = event;
-  const streamUser = (await getEntitiesMapFromCache(context, SYSTEM_USER, ENTITY_TYPE_USER)).get(user_id as string) as AuthUser;
+  const { targets, data: instance, origin } = event;
+  const usersMap = await getEntitiesMapFromCache<AuthUser>(context, SYSTEM_USER, ENTITY_TYPE_USER);
+  const { streamMessage } = event as KnowledgeNotificationEvent;
   for (let index = 0; index < targets.length; index += 1) {
     const { user, type, message } = targets[index];
-    let notificationMessage = message;
-    if (streamUser && (event as KnowledgeNotificationEvent).streamMessage) {
-      const { streamMessage } = event as KnowledgeNotificationEvent;
-      const streamBuiltMessage = `\`${streamUser.name}\` ${streamMessage}`;
-      if (streamBuiltMessage !== notificationMessage) {
-        notificationMessage = `${message} - ${streamBuiltMessage}`;
-      }
-    }
+    const notificationMessage = createFullNotificationMessage(message, usersMap, streamMessage, origin);
     const data = [{ notification_id: event.notification_id, instance, type, message: notificationMessage }];
     await processNotificationEvent(context, notificationMap, event.notification_id, user, data);
   }
 };
 
 const processDigestNotificationEvent = async (context: AuthContext, notificationMap: Map<string, BasicStoreEntityTrigger>, event: DigestEvent) => {
   const { target: user, data } = event;
-  await processNotificationEvent(context, notificationMap, event.notification_id, user, data);
+  const usersMap = await getEntitiesMapFromCache<AuthUser>(context, SYSTEM_USER, ENTITY_TYPE_USER);
+  const dataWithFullMessage = data.map((d) => {
+    return { ...d, message: createFullNotificationMessage(d.message, usersMap, d.streamMessage, d.origin) };
+  });
+  await processNotificationEvent(context, notificationMap, event.notification_id, user, dataWithFullMessage);
 };
 
 const publisherStreamHandler = async (streamEvents: Array<SseEvent<StreamNotifEvent>>) => {