-
Notifications
You must be signed in to change notification settings - Fork 1k
[backend] now also send stream message in digest notifications (#8685) #11004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/current
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #11004 +/- ##
===================================================
+ Coverage 65.64% 65.67% +0.03%
===================================================
Files 680 680
Lines 67304 67320 +16
Branches 7426 7435 +9
===================================================
+ Hits 44182 44213 +31
+ Misses 23122 23107 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
let fullMessage = notificationMessage; | ||
if (origin && streamMessage) { | ||
const { user_id } = origin; | ||
const streamUser = usersMap.get(user_id as string) as AuthUser; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as AuthUser
is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan neither of as string
to bypass the fact that TypeScript is telling that user_id can be undefined
it would be better to trust TypeScript and use .get(user_id ?? '')
to be sure to pass a string as argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll improve it yes you're right, this was copy pasted and refactored from what was done in processLiveNotificationEvent
before
Proposed changes
Related issues
Checklist
Further comments