Skip to content

Update "color" only when empty #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jeanlucpica opened this issue Feb 7, 2022 · 2 comments
Closed

Update "color" only when empty #235

Jeanlucpica opened this issue Feb 7, 2022 · 2 comments
Labels
channel:RC type: bug Something isn't working

Comments

@Jeanlucpica
Copy link

Observed behaviour:
I open an already created spool from the list to view it or update information. The spool has a custom color text value. Meaning the written color name does not match the hex code. This custom color name was saved when creating the spool. As soon as I open the spool with the custom color name, its value is overwritten if the hex code has a valid name. My custom data is lost when I save.
2022-02-07 18_55_41-Prusa MINI+ OctoPrint und 7 weitere Seiten - Persönlich – Microsoft​ Edge

Expected behaviour:
Once entered, a field should keep its initial value. In case of the custom color name, it should remain as is if it is filled. Only when creating a new spool, the color name matching the color hex value should be filled. If a value is already stored it should remain untouched.
2022-02-07 18_55_27-Prusa MINI+ OctoPrint und 7 weitere Seiten - Persönlich – Microsoft​ Edge
@OllisGit OllisGit added status: analysing type: bug Something isn't working status: inNextRelease Will be implemented/fixed in next release and removed status: analysing labels Feb 14, 2022
OllisGit added a commit that referenced this issue Feb 17, 2022
@OllisGit
New Version 1.7.0rc1
aad7330 
- E #246 EventBus-Events to support MQTT-Topics
- E #186 multiple templates (with field selection)
- E #191 Include PTFE tube length for remaining check
- E #221 Preview of QR-Code
- E #207 Define IP/URL for QR-Code generation
- E #220 Output of database id in QR-Code view
- E #236, B #228 Output of total spools in tab-view
- E Output of database id in QR-Code and in table

- B #245 Show last weight digit
- B #235 custom colorname not stored
- B #225 copy was disabled during printing
@OllisGit
Copy link
Owner

Hi @Jeanlucpica,

in the latest RC-Verison 1.7.0rc1 I changed a lot of stuff, maybe this issue is also solved.
Please test and give feedback

Thx, in advance
Olli

@OllisGit OllisGit added channel:RC status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Feb 17, 2022
OllisGit added a commit that referenced this issue Feb 17, 2022
@OllisGit
Preparation of Version 1.7.0
6bdfebf 
- E #246 EventBus-Events to support MQTT-Topics
- E #186 multiple templates (with field selection)
- E #191 Include PTFE tube length for remaining check
- E #221 Preview of QR-Code
- E #207 Define IP/URL for QR-Code generation
- E #220 Output of database id in QR-Code view
- E #236, B #228 Output of total spools in tab-view
- E Output of database id in QR-Code and in table

- B #245 Show last weight digit
- B #235 custom colorname not stored
- B #225 copy was disabled during printing
@Jeanlucpica
Copy link
Author

I just installed the 1.7.0rc1 and can confirm that this issue is fixed. All customer colors now remain as is. Thank you very much for fixing this so quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
channel:RC type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OllisGit @Jeanlucpica