Skip to content

"Hide inactive spools" toggle doesn't work #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarloSM opened this issue Jan 24, 2022 · 5 comments
Closed

"Hide inactive spools" toggle doesn't work #228

MarloSM opened this issue Jan 24, 2022 · 5 comments
Labels
status: waitingForTestFeedback type: bug Something isn't working

Comments

@MarloSM
Copy link
Contributor

MarloSM commented Jan 24, 2022 •
edited
Loading

Hi, great work on the plugin!

Just noticed recently that the "Hide inactive spools" toggle acts as untoggled if the page is refreshed even though it's toggled. Seems like the page defaults this setting to untoggled, rather than taking the value of the variable? Haven't dived deep, just guessing.

After refresh, before re toggle
image

After refresh, after re toggle
image
@MarloSM MarloSM changed the title Hide inactive tools toggle doesn't work Hide inactive spools toggle doesn't work Jan 24, 2022
@MarloSM MarloSM changed the title Hide inactive spools toggle doesn't work "Hide inactive spools" toggle doesn't work Jan 24, 2022
@OllisGit OllisGit added status: analysing type: bug Something isn't working labels Jan 24, 2022
@OllisGit
Copy link
Owner

OllisGit commented Jan 24, 2022 •
edited
Loading

Side note to myself:

  • total spool count in tab not refreshed
  • output spool-count to selection-dialog
  • change "hide empty" and "hide inactive" in tab-view from radio to check-box

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release status: inAfterNextRelease Will be implemented/fixed after next release and removed status: analysing status: inNextRelease Will be implemented/fixed in next release labels Jan 29, 2022
@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: inAfterNextRelease Will be implemented/fixed after next release labels Feb 17, 2022
OllisGit added a commit that referenced this issue Feb 17, 2022
@OllisGit
New Version 1.7.0rc1
aad7330 
- E #246 EventBus-Events to support MQTT-Topics
- E #186 multiple templates (with field selection)
- E #191 Include PTFE tube length for remaining check
- E #221 Preview of QR-Code
- E #207 Define IP/URL for QR-Code generation
- E #220 Output of database id in QR-Code view
- E #236, B #228 Output of total spools in tab-view
- E Output of database id in QR-Code and in table

- B #245 Show last weight digit
- B #235 custom colorname not stored
- B #225 copy was disabled during printing
@OllisGit
Copy link
Owner

Hi @MarloSM,

in the latest RC-Verison 1.7.0rc1 I changed a lot of stuff, maybe this issue is also solved.
Please test and give feedback

Thx, in advance
Olli

@OllisGit OllisGit added channel:RC status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Feb 17, 2022
OllisGit added a commit that referenced this issue Feb 17, 2022
@OllisGit
Preparation of Version 1.7.0
6bdfebf 
- E #246 EventBus-Events to support MQTT-Topics
- E #186 multiple templates (with field selection)
- E #191 Include PTFE tube length for remaining check
- E #221 Preview of QR-Code
- E #207 Define IP/URL for QR-Code generation
- E #220 Output of database id in QR-Code view
- E #236, B #228 Output of total spools in tab-view
- E Output of database id in QR-Code and in table

- B #245 Show last weight digit
- B #235 custom colorname not stored
- B #225 copy was disabled during printing
@MarloSM
Copy link
Contributor Author

MarloSM commented Feb 19, 2022

I had a look today on Google Chrome and Firefox and this issue is still around, sorry.

There's an added UI issue where if you click on the words "Hide inactive spools", it toggles "Hid empty spools". As if the active area for the first option is bigger. Only clicking on the tickbox for "Hide inactive spools" works.

OllisGit added a commit that referenced this issue Mar 18, 2022
@OllisGit
New version
75b28cc 
- B #228 hide inactive
- B #249 adding temperatur offset before starting the print
- B #207 update qr-code image during entering a url prefix
- E 'active' exchanged with 'inactive'
- E adding vendor to search query selection box
@OllisGit
Copy link
Owner

Hi @MarloSM,
new Version 1.7.0 is released and fix the issue

Please test and give feedback.

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release channel:RC labels Mar 18, 2022
@MarloSM
Copy link
Contributor Author

MarloSM commented Mar 29, 2022

Hi @OllisGit. Working great now, thanks.

@MarloSM MarloSM closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waitingForTestFeedback type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarloSM @OllisGit