Skip to content

feat: 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 30, 2022
Merged

feat: 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers #5199

merged 32 commits into from
Aug 30, 2022

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Aug 23, 2022 •
edited
Loading

🍰 Pullrequest

Implement JoinGroup, GroupMember, and SwitchGroupMemberRole resolvers.

Issues

Todo

  • set updatedAt to null
  • rename EnterGroup to JoinGroup
  • change name SwitchGroupMemberRole to ChangeGroupMemberRole
  • implement ChangeGroupMemberRole
    • add functionallity to join group with ChangeGroupMemberRole
      • test this
  • test in general
    • refactor for additinal describe blocks for in mode: XXX
  • test of JoinGroup refactor to building up mode?
  • test ChangeGroupMemberRole
    • general tests
    • check for has "updatedAt" newer as "createdAt"?
      • the GQL mutation would need this fields in the result for testing
      • !!! we decided to do it not yet
    • shall a switch to a role which the a member already has through a permission error?
      • !!! we decided to through no error
    • can an owner be degraded?
      • shall an owner can switch the role of another owner to a lower role yet?
      • or shall only an owner who gave the second owner the owner role downgrade themself?
      • !!! we decided an owner can not be degraded yet
  • switch some group members role in seeding
  • who can make a user joining a group
    • the user themselfs in case of groups of type public and closed
    • the admin/owner with an invite code in case of groups of type hidden, see 🚀 [Feature] Invite Link For Groups #5204
      • we decided that a hidden group can not be joined
        • !!! we decide a hidden group can only be joined by ChangeGroupMemberRole by an owner (no admin)
  • for changing english Authorised to american english Authorized all over the place, see issue 💥 [DevOps] Change Error Message With Authorised To Authorized All Over The Place To Have American English #5203
  • cleanup: search Wolle

Tirokk added 14 commits August 17, 2022 12:11
@Tirokk
Implement 'GroupMember' resolver, a first step
27b74eb
@Tirokk
Implement 'EnterGroup' resolver
25ed30d
@Tirokk
Add seedings for group memberships
613f91b
@Tirokk
Add tests for 'GroupMember' resolver, a start
d36f0ea
@Tirokk
Add tests for 'JoinGroup' and 'GroupMember' resolver
14620b0
@Tirokk
Implement 'SwitchGroupMemberRole' resolver and write the beginning to…
695a71b 
… test it
@Tirokk
Add test for find all member of closed and hidden groups if you are u…
0fe609e 
…sual member
@Tirokk
Resort creation of groups and its connected joins of the groups
74589d4
@Tirokk
Add tests for 'SwitchGroupMemberRole' resolver
e913949
@Tirokk
Add jest dev helper function for sleeping
29874e5
@Tirokk
Refactor tests in 'groups.spec.js' to have modes 'clean db' and 'buil…
41bf1f7 
…ding up'
@Tirokk
Add different group member roles to seeding
f9c8c9b
@Tirokk
Add URL comment for sleep
b3c1790
@Tirokk
Add test todo for 'has "updatedAt" newer as "createdAt"'
dee20c2
@Tirokk Tirokk self-assigned this Aug 23, 2022
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Aug 23, 2022
@Tirokk Tirokk mentioned this pull request Aug 23, 2022
Closed
16 tasks
Tirokk and others added 10 commits August 23, 2022 05:11
@Tirokk @Mogge
Rename resolver SwitchGroupMemberRole to ChangeGroupMemberRole
e3549d3 
Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Check permission not given for resolver ChangeGroupMemberRole if ad…
3ab33a4 
…min will change their own member role in group already at the beginning of 'isAllowedToChangeGroupMemberRole'

Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Refactor to group joining by ChangeGroupMemberRole and that `JoinGr…
95cebd5 
…oup` is not possible for hidden groups

Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Set not 'membership.updatedAt' on relation creation
9dd819f 
Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Destruction of 'mutate' and 'query' in 'groups.spec.js' in one line now
356fac9 
Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Remove local variables 'expected' and some 'variable' and put the val…
b703621 
…ues directly in the 'expect' calls in 'groups.spec.js'

Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Renamed 'GroupMember' to 'GroupMembers'
826cf5a 
Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Change GQL parameter for 'JoinGroup' from 'id' to 'groupId'
813c072 
Co-Authored-By: Mogge <[email protected]>
@Tirokk @Mogge
Change GQL parameter for 'ChangeGroupMemberRole' from 'id' to 'groupId'
fd497a0 
Co-Authored-By: Mogge <[email protected]>
@Tirokk
Refine clean db mode in 'groups.spec.js'
c7c2ebd
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers feat: 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers Aug 23, 2022
@Tirokk Tirokk requested a review from Mogge August 23, 2022 11:13
Mogge
Mogge reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I saw this very late. But I think it is really better to have myRoleInGroup on Group instead of on User

@Tirokk Tirokk requested a review from Mogge August 25, 2022 16:17
@Tirokk
Merge branch '5059-epic-groups' of github.com:Ocelot-Social-Community…
10d88df 
…/Ocelot-Social into 5059-groups/5188-query-members-of-group

# Conflicts:
#	backend/src/schema/resolvers/groups.spec.js
@Tirokk Tirokk merged commit 244cb59 into 5059-epic-groups Aug 30, 2022
@Tirokk Tirokk deleted the 5059-groups/5188-query-members-of-group branch August 30, 2022 08:28
This was referenced Sep 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mogge Mogge Awaiting requested review from Mogge

Assignees

@Tirokk Tirokk

Labels
feature project: yunite service: backend
Projects
None yet
Milestone
🏃 22/10 Oktober
Development

Successfully merging this pull request may close these issues.
3 participants
@Tirokk @Mogge @ulfgebhardt