Skip to content

feat: [WIP] 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Aug 17, 2022

🍰 Pullrequest

Implement JoinGroup, GroupMember, and SwitchGroupMemberRole resolvers.

Issues

Todo

  • rename EnterGroup to JoinGroup
  • change name SwitchGroupMemberRole to ChangeGroupMemberRole
  • implement ChangeGroupMemberRole
    • add functionallity to join group with ChangeGroupMemberRole
      • test this
  • test ChangeGroupMemberRole
    • general tests
    • check for has "updatedAt" newer as "createdAt"?
      • the GQL mutation would need this fields in the result for testing
      • !!! we decided to do it not yet
    • shall a switch to a role which the a member already has through a permission error?
      • !!! we decided to through no error
    • can an owner be degraded?
      • shall an owner can switch the role of another owner to a lower role yet?
      • or shall only an owner who gave the second owner the owner role downgrade themself?
      • !!! we decided an owner can not be degraded yet
  • switch some group members role in seeding
  • who can make a user joining a group
    • the user themselfs in case of groups of type public and closed
    • the admin/owner with an invite code in case of groups of type hidden
      • we decided that a hidden group can not be joined
        • !!! we decide a hidden group can only be joined by ChangeGroupMemberRole by an owner (no admin)
  • cleanup: search Wolle

@Tirokk Tirokk self-assigned this Aug 17, 2022
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Aug 17, 2022
@Tirokk Tirokk changed the title Implement 'GroupMember' resolver, a first step feat: [WIP] 🍰 Implement ÈnterGroup, GroupMember` Resolvers Aug 17, 2022
@Tirokk Tirokk marked this pull request as draft August 17, 2022 16:56
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement ÈnterGroup, GroupMember` Resolvers feat: [WIP] 🍰 Implement EnterGroup, GroupMember Resolvers Aug 17, 2022
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement EnterGroup, GroupMember Resolvers feat: [WIP] 🍰 Implement JoinGroup, GroupMember Resolvers Aug 19, 2022
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement JoinGroup, GroupMember Resolvers feat: [WIP] 🍰 Implement JoinGroup, GroupMember, SwitchGroupMemberRole Resolvers Aug 19, 2022
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good unit tests! Very detailed and good to read. I prefer to see the expected after the API call. I read the API call and the see the expected result. Now I see the expected result, then I see the API call and I have to scroll up again to see the expected.
We should discuss some details

@Tirokk Tirokk closed this Aug 23, 2022
@Tirokk Tirokk deleted the 5188-query-members-of-group branch August 23, 2022 02:52
@Tirokk
Copy link
Member Author

Tirokk commented Aug 23, 2022

Sorry @Mogge !
I renamed the branch and this PR automatically got closed.

I opened an other PR #5199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants