replace human_readable_timestamp with a rust-g formatter #6540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
Process: do not merge
This was referenced May 3, 2025
This was referenced May 5, 2025
This was referenced May 5, 2025
Closed
This was referenced May 6, 2025
… human-readable-timestamp-sucks-ass
… human-readable-timestamp-sucks-ass
… human-readable-timestamp-sucks-ass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
this replaces the awful slow
/datum/log_holder/proc/human_readable_timestamp()proc with a rust-g implementation of time formatting, seen here: tgstation/rust-g#214i also made both it and
unix_timestamp_stringjust use defines instead of procs, to reduce overhead in these hot procs. also made them useload_extrust_g.dllbinary from https://github.com/Absolucy/rust-g/actions/runs/14797092310Why It's Good For The Game
these are hot procs and they can be slow.
Changelog
no player-facing changes.