Skip to content

PDA Alert level #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025
Merged

PDA Alert level #6454

merged 4 commits into from
May 12, 2025

Conversation

notghosti
Copy link
Collaborator

@notghosti notghosti commented Apr 23, 2025

About The Pull Request

Ports alert levels will showing on PDAS from #89173
The intensity will also change depending on how relevant it is to the users access.
Screenshot 2025-04-23 020611

Why It's Good For The Game

Visual communication of ongoing levels is great. Also lets me know if I can slip a security officer for having a gun out on green alert.

Changelog

🆑
qol: Alert levels now show on pda's
/:cl:

@Kitsunemitsu Kitsunemitsu added the Feature: enhancement New feature or request label Apr 23, 2025
Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link and credit the original PR you ported, please.

@Absolucy Absolucy added Code: TGUI Involves TGUI in some way, shape or form QoL improves quality of life labels Apr 26, 2025
@notghosti
Copy link
Collaborator Author

link and credit the original PR you ported, please.

Ah sorry, I had found the code raw so hadn't considered looking for it.
Should be included now I do believe

#define ALERT_RELEVANCY_SAFE 0 /// * 0: User is not in immediate danger and not needed for some station-critical task.
#define ALERT_RELEVANCY_WARN 1 /// * 1: Danger is around, but the user is not directly needed to handle it.
#define ALERT_RELEVANCY_PERTINENT 2 /// * 2: Danger is around and the user is responsible for handling it.
/obj/item/modular_computer/proc/get_security_level_relevancy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngl I'd prefer these checks be a part of /datum/security_level instead

Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly i'll refactor in a later PR, this has been TM'd long enough

@Absolucy Absolucy merged commit b7bd6e8 into Monkestation:master May 12, 2025
51 checks passed
github-actions bot added a commit that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: TGUI Involves TGUI in some way, shape or form Feature: enhancement New feature or request QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants