Blocks the clone pod from creating MOB_ROBOTIC mobs #6031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
requested changes
Mar 27, 2025
We do: Monkestation2.0/monkestation/code/game/machinery/computer/cloning.dm Lines 535 to 538 in 93927db But we don't check the brain: Monkestation2.0/monkestation/code/game/machinery/computer/cloning.dm Lines 540 to 541 in 93927db Because the brain doesn't have a mob attached we can't check that. At beast I might be able to see if we scan for ORGAN_ROBOTIC on the brain. But I would still want to make sure we're not printing MOB_ROBOTICS from the pod to make double sure. |
This was referenced Mar 30, 2025
This was referenced Mar 30, 2025
Open
Ziiro
commented
Mar 30, 2025
| @@ -133,10 +133,14 @@ | |||
|
|
|||
| //Start growing a human clone in the pod! | |||
| /obj/machinery/clonepod/proc/growclone(clonename, ui, mutation_index, mindref, blood_type, datum/species/mrace, list/features, factions, list/quirks, datum/bank_account/insurance, list/traumas, empty) | |||
| var/mob/living/carbon/human/H = new /mob/living/carbon/human(src) | |||
| H.hardset_dna(ui, mutation_index, null, clonename, blood_type, mrace, features) | |||
tired-wired
pushed a commit
that referenced
this pull request
Mar 31, 2025
Reverts #6031 this was implemented in a way that could cause IMMENSE lag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Seems a bit silly that the clone pod can clone MOB_ROBOTIC, this fixes that
Why It's Good For The Game
Fixes a bit of a bug/oversight - while you technically can't scan an IPC body, you can scan the brain. And if you do a clone from a brain scan it can spit out an IPC body. This fixes that.
Changelog
🆑
fix: Clone pods can no longer create MOB_ROBOTIC bodies
/:cl: