-
Notifications
You must be signed in to change notification settings - Fork 345
IPC body construction & other fixes #5781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some strange interaction when putting the posibrain into a fully functional body causes the client to be temporarily sent to the shadow realm
Other than that it mostly seems to work. This has highlighted that I also need to do something about re-attaching IPC antenna - because it's an external organ. |
my name is edwin |
No longer sends them to the shadow realm thanks to INVOKE_ASYNC, however now it just runtimes at the completion of spec_revival.
|
Tinkering around further, the "Shadow realm" bug is repeatable in live as follows:
The INVOKE_ASYNC solution that was tried previously kicked the can a different direction by turning it into a runtime rather than this error. However I'm still not sure where this is coming from. It's nothing I've done here, but I intend to fix it here. |
thought I'd get around #5956 by making it so the brain doesn't auto revive but it turns out the revival surgery also trips that bug |
438d1e7
to
cfb1c6f
Compare
I'm going to have to atomize this out into separate PRs because it's gotten too big. |
About The Pull Request
Why It's Good For The Game
Changelog
🆑
add: IPC Bodies can now be printed at the mechafab after completing the required research!
add: Moves IPC related objects to its own category in the mechafab under cybernetics
add: Two new surgeries have been added to clear Oxy and Toxin damage types from dead IPCs.
balance: Cloning pods may no longer create bodies that are MOB_ROBOTIC (like IPCs)
balance: IPCs will no longer re-activate automatically when the brain is inserted and must be rebooted manually
balance: IPCs will no longer be stuck in crit limbo and will take burn damage when in crit until they die
fix: IPC activate_monitor and BSOD procs now check to make sure the IPC has a head
fix: IPC Posibrains are now a vital organ and they will die without them
fix: Removed duplicated code in _bodyparts regarding TRAIT_REVIVES_BY_HEALING
/:cl: