Fix some IPC and loadout prefs #5823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
Process: do not merge
Absolucy
commented
Mar 6, 2025
| @@ -61,8 +61,13 @@ | |||
| return values | |||
|
|
|||
| /datum/preference/choiced/ipc_chassis/apply_to_human(mob/living/carbon/human/target, value) | |||
| target.dna.features["ipc_chassis"] = value | |||
| target.regenerate_icons() | |||
There was a problem hiding this comment.
the worst part is that this didn't even WORK
This was referenced Mar 6, 2025
Closed
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This place is not a place of honor...
No highly esteemed deed is commemorated here... nothing valued is here.
What is here was dangerous and repulsive to us. This message is a warning about danger.
i fixed some shitcode with prefs, especially IPC prefs - which should fix some performance issues. and made changing the IPC chassis actually update the character preview in the process.
Why It's Good For The Game
less lag, AND making stuff work better. win-win. code's still yuck tho.
Changelog
🆑
fix: Fixed some performance issues related to character customization.
fix: Changing the IPC chassis in preferences now properly updates the preview.
/:cl: