Skip to content

March Bug FIx Bday Bash #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2025
Merged

March Bug FIx Bday Bash #5789

merged 9 commits into from
Mar 5, 2025

Conversation

Coll6
Copy link
Contributor

@Coll6 Coll6 commented Mar 3, 2025

About The Pull Request

Another grouping of bug fixes. This one addresses the dark sabre. Currently still needs hand icons but otherwise is now visible and missing icons use base sabre icons in world. Gary's runtime for going to things is hopefully silenced. A runtime was created with the wt550m9 trying to spawn with a max ammo of 0. Now a proper spawn in empty is made for this ammo and properly placed in world. One of the map helpers for air alarms was run timing due to trying to send its target when the target was already checked to be null. This now sends the proper area location. Finally due to a recent change to the smgm45 or the cr20 ammo broke its icons. A proper offset equation is applied to make its new ammo count match the current icons.

Why It's Good For The Game

More bug fixes to help make the game better for everyone. For the most part shouldn't have any issues with the main game and just applies proper checks to where they should be.

Changelog

🆑Siro
qol: Dark Sabre Sheath Icons partially restored. fixes #5692
fix: Fixed the pathology incubator and analyzer so they don't break making the machine inoperable
fix: magazine/smgm45 icons now display properly in world.
bal: Slasher machette when thrown does 5 damage till light mechanic fixed.
map: Placed proper empty wt550m9 in ezhall and office1 ruin locations
code: IS_SLASHER macro made which also silenced multiple runtimes.
code: Silenced Gary's go to target pick from null list runtime.
code: Silenced map helper for air alarms for null target.
code: Silenced divide by 0 runtime with proper starts_empty proc for the wt550m
code: Applied proper ammo offset compensate for ammo changes from: #5212
/:cl:

@Veth-s Veth-s added Code: Fix fix da bug Approval: admin approved PR is approved by admins labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approval: admin approved PR is approved by admins Code: Fix fix da bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ornate Sheathe is still invisible
4 participants