March Bug FIx Bday Bash (#5789)

## About The Pull Request

Another grouping of bug fixes. This one addresses the dark sabre.
Currently still needs hand icons but otherwise is now visible and
missing icons use base sabre icons in world. Gary's runtime for going to
things is hopefully silenced. A runtime was created with the wt550m9
trying to spawn with a max ammo of 0. Now a proper spawn in empty is
made for this ammo and properly placed in world. One of the map helpers
for air alarms was run timing due to trying to send its target when the
target was already checked to be null. This now sends the proper area
location. Finally due to a recent change to the smgm45 or the cr20 ammo
broke its icons. A proper offset equation is applied to make its new
ammo count match the current icons.

## Why It's Good For The Game

More bug fixes to help make the game better for everyone. For the most
part shouldn't have any issues with the main game and just applies
proper checks to where they should be.

## Changelog
:cl:Siro
qol: Dark Sabre Sheath Icons partially restored. fixes #5692
fix: Fixed the pathology incubator and analyzer so they don't break
making the machine inoperable
fix: magazine/smgm45 icons now display properly in world.
bal: Slasher machette when thrown does 5 damage till light mechanic
fixed.
map: Placed proper empty wt550m9 in ezhall and office1 ruin locations
code: IS_SLASHER macro made which also silenced multiple runtimes.
code: Silenced Gary's go to target pick from null list runtime.
code: Silenced map helper for air alarms for null target.
code: Silenced divide by 0 runtime with proper starts_empty proc for the
wt550m
code: Applied proper ammo offset compensate for ammo changes from: #5212
/:cl:

Author: Coll6

_maps/RandomRuins/SpaceRuins/abandonedunknownsite1.dmm

@@ -6986,10 +6986,7 @@
 /area/ruin/space/has_grav/abandonedscpsite/ezhall)
 "zQ" = (
 /obj/effect/mapping_helpers/broken_floor,
-/obj/item/ammo_box/magazine/wt550m9{
-	max_ammo = 0;
-	icon_state = "46x30mmt-0"
-	},
+/obj/item/ammo_box/magazine/wt550m9/starts_empty,
 /obj/effect/decal/cleanable/blood/gibs/core,
 /obj/structure/extinguisher_cabinet/directional/east,
 /obj/effect/decal/cleanable/dirt,
@@ -8704,10 +8701,7 @@
 /obj/machinery/atmospherics/pipe/smart/manifold4w/scrubbers/hidden/layer2,
 /obj/structure/cable,
 /obj/effect/decal/cleanable/blood,
-/obj/item/ammo_box/magazine/wt550m9{
-	max_ammo = 0;
-	icon_state = "46x30mmt-0"
-	},
+/obj/item/ammo_box/magazine/wt550m9/starts_empty,
 /obj/effect/decal/cleanable/dirt,
 /turf/open/floor/catwalk_floor/iron_dark,
 /area/ruin/space/has_grav/abandonedscpsite/hczhall)
@@ -10295,10 +10289,7 @@
 /obj/structure/cable,
 /obj/machinery/atmospherics/pipe/smart/manifold4w/scrubbers/hidden/layer2,
 /obj/effect/mapping_helpers/broken_floor,
-/obj/item/ammo_box/magazine/wt550m9{
-	max_ammo = 0;
-	icon_state = "46x30mmt-0"
-	},
+/obj/item/ammo_box/magazine/wt550m9/starts_empty,
 /obj/effect/decal/cleanable/dirt,
 /turf/open/floor/catwalk_floor/iron_dark,
 /area/ruin/space/has_grav/abandonedscpsite/hczhall)

code/__DEFINES/~monkestation/antagonists.dm

@@ -5,6 +5,9 @@
 ///Whether a mob is a Monster Hunter
 #define IS_MONSTERHUNTER(mob) (mob?.mind?.has_antag_datum(/datum/antagonist/monsterhunter))
 
+/// Checks if the given mob is a slasher.
+#define IS_SLASHER(mob) (mob?.mind?.has_antag_datum(/datum/antagonist/slasher))
+
 /// List of areas blacklisted from area based traitor objectives
 #define TRAITOR_OBJECTIVE_BLACKLISTED_AREAS list(/area/station/engineering/hallway, \
 		/area/station/engineering/lobby, \

code/modules/mapping/mapping_helpers.dm

@@ -265,7 +265,7 @@
 
 	var/obj/machinery/airalarm/target = locate(/obj/machinery/airalarm) in loc
 	if(isnull(target))
-		var/area/target_area = get_area(target)
+		var/area/target_area = get_area(src)
 		log_mapping("[src] failed to find an air alarm at [AREACOORD(src)] ([target_area.type]).")
 	else
 		payload(target)

code/modules/mob/living/living_defense.dm

@@ -212,8 +212,18 @@
 				emote("scream", intentional=FALSE)
 			//MONKESTATION EDIT END
 			return
+
 		var/armor = run_armor_check(zone, MELEE, "Your armor has protected your [parse_zone(zone)].", "Your armor has softened hit to your [parse_zone(zone)].", thrown_item.armour_penetration, "", FALSE, thrown_item.weak_against_armour)
-		apply_damage(thrown_item.throwforce, thrown_item.damtype, zone, armor, sharpness = thrown_item.get_sharpness(), wound_bonus = (nosell_hit * CANT_WOUND))
+		//MONKESTATION EDIT START
+		if(istype(AM, /obj/item/slasher_machette))
+			if(istype(thrown_by) && IS_SLASHER(thrown_by)) // Must be slasher must have a mind and slasher antag datum.
+				apply_damage(5, thrown_item.damtype, zone, armor, sharpness = thrown_item.get_sharpness(), wound_bonus = (nosell_hit * CANT_WOUND))
+			else
+				return // Cancels the damage. Hope this works and doesn't cause a runtime.
+		else
+			apply_damage(thrown_item.throwforce, thrown_item.damtype, zone, armor, sharpness = thrown_item.get_sharpness(), wound_bonus = (nosell_hit * CANT_WOUND))
+		//MONKESTATION EDIT END
+
 		if(QDELETED(src)) //Damage can delete the mob.
 			return
 		if(body_position == LYING_DOWN) // physics says it's significantly harder to push someone by constantly chucking random furniture at them if they are down on the floor.

code/modules/projectiles/boxes_magazines/external/smg.dm

@@ -6,6 +6,11 @@
 	caliber = CALIBER_46X30MM
 	max_ammo = 20
 
+//MONKESTATION ADDITION START
+/obj/item/ammo_box/magazine/wt550m9/starts_empty
+	start_empty = TRUE
+//MONKESTATION ADDITION END
+
 /obj/item/ammo_box/magazine/wt550m9/update_icon_state()
 	. = ..()
 	icon_state = "[base_icon_state]-[round(ammo_count(), 4)]"
@@ -84,7 +89,14 @@
 
 /obj/item/ammo_box/magazine/smgm45/update_icon_state()
 	. = ..()
-	icon_state = "[base_icon_state]-[round(ammo_count(), 2)]"
+	//monke edit start
+	var/old_ammo = 24 // From the old 24 ammo count.
+	var/icon_steps = 2 // Number of steps each icon changed. If 2 with 24 ammo then 24->22->20 etc
+	var/scaled_ammo = round((ammo_count() / max_ammo) * old_ammo, icon_steps) // Required offest without altering icons.
+	if(ammo_count() > 0 && ammo_count() < 2) // Force last bullet icon till the last bullet is actually used.
+		scaled_ammo = icon_steps // icon_steps is usually also your last icon before 0
+	icon_state = "[base_icon_state]-[scaled_ammo]"
+	//monke edit end
 
 /obj/item/ammo_box/magazine/smgm45/ap
 	name = "SMG magazine (Armour Piercing .45)"

monkestation/code/modules/blood_for_the_blood_gods/slasher/abilities/recall_machette.dm

@@ -19,7 +19,7 @@
 		return
 	if(!stored_machette || QDELETED(stored_machette))
 		stored_machette = new /obj/item/slasher_machette
-		var/datum/antagonist/slasher/slasherdatum = owner.mind.has_antag_datum(/datum/antagonist/slasher)
+		var/datum/antagonist/slasher/slasherdatum = IS_SLASHER(owner)
 		if(!slasherdatum)
 			return
 		slasherdatum.linked_machette = stored_machette
@@ -66,7 +66,7 @@
 /obj/item/slasher_machette/proc/pre_throw(obj/item/source, list/arguments)
 	SIGNAL_HANDLER
 	var/mob/living/thrower = arguments[4]
-	if(!istype(thrower) || !thrower.mind.has_antag_datum(/datum/antagonist/slasher))
+	if(!istype(thrower) || !IS_SLASHER(thrower))
 		// Just in case our thrower isn't actually a slasher (somehow). This shouldn't ever come up,
 		// but if it does, then we just prevent the throw.
 		return COMPONENT_CANCEL_THROW
@@ -102,27 +102,27 @@
 			living_user.adjustBruteLoss(force)
 			to_chat(user, span_warning("You scream out in pain as you hold the [src]!"))
 			return FALSE
-	var/datum/antagonist/slasher/slasherdatum = user.mind?.has_antag_datum(/datum/antagonist/slasher)
+	var/datum/antagonist/slasher/slasherdatum = IS_SLASHER(user)
 	if(slasherdatum?.active_action && istype(slasherdatum.active_action, /datum/action/cooldown/slasher/soul_steal))
 		return FALSE // Blocks the attack
 	return ..() // Proceeds with normal attack if no soul steal is active
 
 /obj/item/slasher_machette/attack(mob/living/target_mob, mob/living/user, params)
 	if(isliving(user))
 		var/mob/living/living_user = user
-		if(!user.mind.has_antag_datum(/datum/antagonist/slasher))
+		if(!IS_SLASHER(user))
 			forceMove(get_turf(user))
 			user.emote("scream")
 			living_user.adjustBruteLoss(force)
 			to_chat(user, span_warning("You scream out in pain as you hold the [src]!"))
 			return
-	var/datum/antagonist/slasher/slasherdatum = user.mind?.has_antag_datum(/datum/antagonist/slasher)
+	var/datum/antagonist/slasher/slasherdatum = IS_SLASHER(user)
 	if(slasherdatum?.active_action)
 		return TRUE // Blocks the attack
 	return ..()
 
 /obj/machinery/door/airlock/proc/attack_slasher_machete(atom/target, mob/living/user)
-	if(!user.mind.has_antag_datum(/datum/antagonist/slasher))
+	if(!IS_SLASHER(user))
 		return
 	if(isElectrified() && shock(user, 100)) //Mmm, fried slasher!
 		add_fingerprint(user)

monkestation/code/modules/clothing/~donator/clothing.dm

@@ -410,7 +410,7 @@
 	righthand_file = 'monkestation/icons/donator/mob/inhands/donator_right.dmi'
 
 /obj/item/toy/darksabre/get_belt_overlay()
-	return mutable_appearance('monkestation/icons/donator/obj/custom.dmi', "darksheath-darksabre")
+	return mutable_appearance('monkestation/icons/donator/obj/custom.dmi', "darksheath-sabre")
 
 // Donation reward for inferno707
 /obj/item/storage/belt/sabre/darksabre
@@ -420,6 +420,9 @@
 	worn_icon = 'monkestation/icons/donator/mob/clothing/custom_w.dmi'
 	icon_state = "darksheath"
 	worn_icon_state = "darksheath"
+	inhand_icon_state = "darksheath"
+	lefthand_file = 'monkestation/icons/donator/mob/inhands/donator_left.dmi'
+	righthand_file = 'monkestation/icons/donator/mob/inhands/donator_right.dmi'
 
 /obj/item/storage/belt/sabre/darksabre/Initialize(mapload)
 	. = ..()

monkestation/code/modules/ranching/chickens/ai/gary/gary_behaviours.dm

@@ -192,7 +192,7 @@
 			continue
 		mobs += mob
 
-	controller.blackboard[BB_TRAVEL_DESTINATION] = pick(mobs)
+	controller.blackboard[BB_TRAVEL_DESTINATION] = (length(mobs) > 0) ? pick(mobs) : null //pick() cries if theres nothing in the list.
 	controller.blackboard[BB_GARY_WANDER_COOLDOWN] = world.time + 5 MINUTES
 	. = ..()
 

monkestation/code/modules/virology/machines/analyzer.dm

@@ -113,10 +113,17 @@
 
 	if(do_after(user, 5 SECONDS, src))
 		if(machine_stat & (BROKEN|NOPOWER))
+			processing = FALSE // Make sure to return the machine to normal operation if power outage
+			update_appearance()
+			scanner = null
 			return
 		if(!istype(dish.contained_virus, /datum/disease/acute))
 			QDEL_NULL(dish)
 			say("ERROR:Bad Pathogen detected PURGING")
+			processing = FALSE // Make sure to return the machine to normal operation after purge
+			update_appearance()
+			scanner = null
+			return
 		if (dish.contained_virus.addToDB())
 			say("Added new pathogen to database.")
 		var/datum/data/record/v = GLOB.virusDB["[dish.contained_virus.uniqueID]-[dish.contained_virus.subID]"]

monkestation/code/modules/virology/machines/incubator.dm

@@ -253,7 +253,8 @@
 
 		var/list/symptom_data = list()
 		var/obj/item/weapon/virusdish/dish = dish_datum.dish
-		for(var/datum/symptom/symptom in dish.contained_virus.symptoms)
+		dish_ui_datum["contains_disease"] = istype(dish.contained_virus) ? TRUE : FALSE
+		for(var/datum/symptom/symptom in dish.contained_virus?.symptoms)
 			if(!(dish.contained_virus.disease_flags & DISEASE_ANALYZED))
 				symptom_data += list(list("name" = "Unknown", "desc" = "Unknown", "strength" = symptom.multiplier, "max_strength" = symptom.max_multiplier, "chance" = symptom.chance, "max_chance" = symptom.max_chance, "stage" = symptom.stage))
 				continue

monkestation/icons/donator/mob/clothing/custom_w.dmi

@@ -144,8 +144,21 @@ export const DiseaseIncubator = (props) => {
                       ))}
                     </LabeledList>
                   </Collapsible>
+                ) : dish.inserted ? (
+                  dish.contains_disease ? (
+                    Array.isArray(dish.symptom_data) &&
+                    !dish.symptom_data.length > 0 && (
+                      <NoticeBox info>
+                        Disease does not contain any symptoms.
+                      </NoticeBox>
+                    )
+                  ) : (
+                    <NoticeBox warning>
+                      Dish does not contain a viable disease!
+                    </NoticeBox>
+                  )
                 ) : (
-                  <NoticeBox warn>No symptom data available.</NoticeBox>
+                  <NoticeBox danger>Please insert a growth dish!</NoticeBox>
                 )}
               </Section>
             ))}