[PORT] Dropdowns v2; plus, dropdowns now highlight their selected element #5731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete rewrite of dropdowns to use popper elements that are injected at the body level. This means they are now horribly overcomplicated and also suck a lot less  Also ported `Icon` to typescript for a reason that didn't end up making it in the PR   :cl: add: good tgui dropdowns del: tgui dropdown suck qol: tgui dropdowns suck less balance: buffed tgui dropdowns /:cl:
## About The Pull Request This PR makes selected elements in Dropdowns to be highlighted. Without this:  With this:  ## Why It's Good For The Game It's convenient to have this kind of selection indication, especially in long lists. ## Changelog :cl: qol: Made selected elements highlighted in TGUI Dropdowns /:cl:
## About The Pull Request If dropdown not receive `selected` prop, buttons will be change value to first(when press next) or last element(when press back) ## Changelog :cl: fix: Fixed dropdown buttons empty selected case /:cl:
LikeLakers2
added
Code: Fix
This was referenced Mar 3, 2025
|
I was notified that this caused the Chromosome selection on the Genetics console to look a little weird. It looks a bit like this: I was able to replicate this on tgstation, but only after reverting to a pre-react commit (I chose tgstation/tgstation@84ba2dc). So Absolucy and I believe this to be an issue with us still being pre-react. However, I was able to find a temporary solution (which we will want to try to revert once the react port is done), and have implemented it in 4b0e68d. Now it looks like this, as it should:
|
LikeLakers2
force-pushed
the
project/port/tg-75164-dropdowns-v2
branch
from
fe6170a to
4b0e68d
Compare
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR ports the following PRs from tgstation:
Here's how dropdowns looked before this PR:
and after:
Why It's Good For The Game
Code improvements, and the highlighting dropdowns makes it easier to know what you selected, especially in long lists.
Changelog
🆑MichiRecRoom, actioninja, lebedev, KoJIT2009
refactor: TGUI dropdowns have been refactored; please let me know if you spot any broken dropdowns!
qol: (lebedev) Made selected elements highlighted in TGUI Dropdowns
/:cl: