Custom Shoe Sounds fix. #5388
Merged
Custom Shoe Sounds fix. #5388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Elements and components aren't easily explained. I made an oops thinking I could make this an element. Caused anything using this element to share the same settings. This changes it to a component and fixes this "quantum locking" issue.
Fixes #5365
Why It's Good For The Game
Shoe sounds are supposed to be instanced on each shoe its applied to not shared between each shoe. Defeats the purpose of custom shoe sounds. This refactor fixes it.
Changelog
🆑 Siro
fix: Fixed all jackboots being quantum entangled - toggling the noisemaker for one pair of jackboots no longer changes it for every other pair of jackboots too.
/:cl: