Phobias should not prevent forced says #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Jan 21, 2025
Closed
This was referenced Jan 22, 2025
LikeLakers2
deleted the
project/bug-fix/phobia-should-not-prevent-forced-say
branch
LikeLakers2
added a commit
to LikeLakers2/Monkestation2.0
that referenced
this pull request
Jan 24, 2025
This reverts commit f671b8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I found that phobias could prevent a character from being forced to say something. For example, the anime phobia would prevent a character from yelling "ANIME" even if the yell was forced by something else (i.e. a spell).
This PR fixes this, preventing forced says from being blocked by phobias... in exchange for making them freak out anyways.
Note that this is currently not an issue in tgstation's codebase, as none of the phobias appear to overlap with things that characters can be forced to say, but I am sending in a PR anyways, in the event that downstream forks are affected by this.
Why It's Good For The Game
Bug fixes. Give me some good coder cookies, please?
Changelog
🆑 MichiRecRoom
add: Being forced to say something (i.e. through Tourettes) that would normally be blocked by your phobia will now cause your character to freak out.
fix: Your phobias can no longer prevent you from being forced to say something by an admin.
/:cl: