Skip to content

Finishes NebulaStation from TG #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from
Closed

Conversation

dwasint
Copy link
Collaborator

@dwasint dwasint commented Jun 4, 2024

About The Pull Request

This PR aims to finish off KikoWen0's NebulaStation from /TG/Station as I really like the looks of it

Why It's Good For The Game

Changelog

🆑 KikoWen0, Dwasint
add: New map Nebula Station
/:cl:

@LikeLakers2
Copy link
Collaborator

LikeLakers2 commented Jun 6, 2024

https://github.com/Monkestation/Monkestation2.0/actions/runs/9396236823/job/25879217931?pr=2156#step:7:42

 07- map json naming
_maps/NebulaStation.json

ERROR: Uppercase in a map .JSON file detected, these must be all lowercase.
 08- map json sanity

ERROR: Found an invalid file reference to _maps/map_files/nebulastation/nebulastation.dmm in _maps/_maps/NebulaStation.json 

fix the linting problems, ya nerd

@github-actions github-actions bot added the Merge Conflict DO NOT RENAME THIS LABEL label Jun 24, 2024
@KnigTheThrasher
Copy link
Contributor

Are you still interested in doing this? It's fully merged on tg for around 2 weeks.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Apr 9, 2025
@github-actions github-actions bot closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict DO NOT RENAME THIS LABEL Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants