Skip to content

Add support for null values on some built-in equality checks #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2021
Merged

Add support for null values on some built-in equality checks #15

merged 3 commits into from
Dec 8, 2021

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Dec 7, 2021 •
edited
Loading

Extends a few of the built-in equality checks to also accept null and undefined as values. It is not uncommon for selectors or maps to have "optional" return values. So having it supported in the built-in checks makes them available to be used in more situations.

Added new the checks:

  • nullableShallowObjectEqualityCheck
  • nullableShallowObjectArrayEqualityCheck
  • nullableShallowArrayEqualityCheck

TODO:

  • After merging we will need to update the documentation pages

@pirelenito pirelenito requested review from dderg and xaviervia December 7, 2021 14:08
@pirelenito pirelenito merged commit 6df2b6c into main Dec 8, 2021
@pirelenito pirelenito deleted the nullable-equality-checks branch December 8, 2021 09:49
pirelenito added a commit that referenced this pull request Dec 10, 2021
@pirelenito
Update documentation after #15 and #14
a69a979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviervia xaviervia xaviervia approved these changes

@dderg dderg Awaiting requested review from dderg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirelenito @xaviervia