Add support for multiple facets in useFacetCallback and useFacetEffect #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates the useRemoteFacetPropSetter to accept a remoteFacet instead of a facet.
|
Chatted with @xaviervia and he suggested we extend this API modification to the |
pirelenito
changed the title
|
It is ready for review again 🎉 |
dderg
reviewed
Dec 8, 2021
dderg
reviewed
Dec 8, 2021
…g/ore-ui into use-facet-callback-multiple-facets
dderg
approved these changes
Dec 8, 2021
xaviervia
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was been motivated by internal use-cases that relied on adding extra
useFacetMapsto achieve the same goal. This should have a lower overhead with the added benefit that now all of our hooks share the same API (facets are arrays).Also updates the
useRemoteFacetPropSetterto accept aremoteFacetinstead of a facet, making the API more consistent. I did this update as I needed to touch the implementation.I would like special attention from reviewers on the types inside the
useFacetCallbackimplementation. Any suggestion for improvements (specially on handling the unknowns) will be very welcome.TODO: