Skip to content

feat: 12.17.3 #32637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2025
Merged

feat: 12.17.3 #32637

merged 10 commits into from
May 13, 2025

Conversation

metamaskbot
Copy link
Collaborator

This is the release candidate for version 12.17.3. The changelog will be found in another PR chore/12.17.3-Changelog.

Team sign-off checklist

  • team-accounts
  • team-assets
  • team-confirmations
  • team-design-system
  • team-notifications
  • team-platform
  • team-security
  • team-snaps-platform
  • team-sdk
  • team-stake
  • team-tiger
  • team-wallet-framework

Reference

@metamaskbot metamaskbot added the team-bot Bot team (for MetaMask Bot) label May 7, 2025
@Gudahtt
Copy link
Member

Gudahtt commented May 7, 2025

…#32674)

Cherry-pick: #32583
In a recent PR we [made the `Dapp Viewed` event
anonymous](#32207).
More recently we've learned that this was not sufficient to unblock
release on Firefox: see

[here](https://consensys.slack.com/archives/CTQAGKY5V/p1746542727192369?thread_ts=1745413333.736539&cid=CTQAGKY5V).

So here we're completely excluding emission of the `Dapp Viewed` event
in Firefox builds

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32674?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Alex Donesky <[email protected]>
@DDDDDanica DDDDDanica changed the base branch from main to master May 8, 2025 12:44
Copy link
Contributor

github-actions bot commented May 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…Chrome 109 and Firefox 102 cp-12.17.3 (#32639)

- chore: update minimum browser versions to Chrome 109 and Firefox 102
(#32520)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

[Documented extension browser support

is](https://github.com/MetaMask/metamask-extension/blob/dc7325148c1ac03f050422e07156087b53af92d2/docs/browser-support.md):

* The last two years of Chrome stable releases
* The current and previous Firefox Extended Support Release

This PR updates our minimum supported Chrome version to Chrome 109, and
our minimum supported Firefox version to Firefox 102.

* Chrome 109
  * released January 2023
  * Over two years? ✅ 
 * Firefox 102
   * released June 28, 2022.
   * Current and Previous ESR? ✅ 
* there are actually _two_ more up to date Firefox releases: 115 ESR and
128 ESR. So we will be supporting 3 versions.

The _actual_ minimum browsers we _can_ update to, per policy, are:

 * Chrome 113 (released Apr 26, 2023)
 * Firefox 115 ESR (because 128 ESR is available)
  
The reason this PR does NOT update directly to those versions is because
we must `update the OUTDATED_BROWSER_VERSIONS` constant in the release
prior to the minimum version bump. This PR does that. After one release
we can further bump our minimum supported versions to Chrome 113 and
Firefox 115.
 
Notes:

* Firefox 140 ESR will be released June 24 2025, meaning we can then
drop Firefox 115 ESR support and update our minimum supported version to
Firefox 128 at that time.
* This PR does *not* update our compilation targets, because our browser
tools don't support all of the new JavaScript syntax available in these
newer browsers.


[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32520?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Ensure that the extension still works on versions equal to or above
the new minimum versions.


## **Screenshots/Recordings**
If you install on an "old" version, like Firefox 102.0 as I did here,
you'll see a warning like this:



![image](https://github.com/user-attachments/assets/e9c2627e-558f-450c-8085-c237f00a04ff)


<!--
### **Before**



### **After**

-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[f9a31f5](f9a31f5)

Co-authored-by: David Murdoch <[email protected]>
Co-authored-by: Danica Shen <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [c4b37b4]
UI Startup Metrics (1254 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1254113915375812981329
load10899701246561139974
domContentLoaded10839631240551136979
domInteractive17136471730
firstPaint65685117943925085
backgroundConnect7427379
firstReactRender21147482138
getState14537868
initialActions001001
loadScripts83471097655874913
setupStore8523379
WebpackHomeuiStartup22091673271419723242499
load17501277222417418342138
domContentLoaded17431274222017218192120
domInteractive16125791442
firstPaint162663976023485
backgroundConnect309299313688
firstReactRender168543691126294
getState16418019599
initialActions318145
loadScripts17381272221816818162089
setupStore26620038309
FirefoxBrowserifyHomeuiStartup13781179174411714401648
load12391060161411613001499
domContentLoaded12391060161311612991499
domInteractive10139182258997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19135062027
firstReactRender23195652332
getState7459579
initialActions005101
loadScripts12221047159811612841477
setupStore6436467
WebpackHomeuiStartup15721406220313716181874
load13681217190912914271645
domContentLoaded13671217190912914271645
domInteractive8838191208897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21147972127
firstReactRender34286053647
getState8441589
initialActions001011
loadScripts13491199188912814121630
setupStore8535489

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
Cherry-pick #32635
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution? -->
- Excludes the MetaMetrics ID when the `PhishingPageDisplayed` event is
emitted and also won't emit `PhishingPageDisplayed` when on Firefox.
- Excludes the MetaMetrics ID when the `ProceedAnywayClicked` event is
emitted and also won't emit `ProceedAnywayClicked` when on Firefox.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32635?quickstart=1)

Fixes: MetaMask/MetaMask-planning#4842

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32675?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: imblue <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [2f7740c]
UI Startup Metrics (1242 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1242114514216112851361
load10839511239601136961
domContentLoaded10789431235601141988
domInteractive18136691634
firstPaint741971175426225952
backgroundConnect6414279
firstReactRender22166982138
getState13534778
initialActions003001
loadScripts83170398058872912
setupStore9534479
WebpackHomeuiStartup21511743259918622932456
load17111295222516417932007
domContentLoaded17061289222016317841998
domInteractive16125381442
firstPaint151623145624790
backgroundConnect2499215359
firstReactRender14152357956195
getState11334779
initialActions316135
loadScripts17011285221816017811971
setupStore286375583759
FirefoxBrowserifyHomeuiStartup14231220178611414691696
load12721090161010513251455
domContentLoaded12721090161010513251455
domInteractive10638214308997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2314119132345
firstReactRender23203832531
getState9440789
initialActions005101
loadScripts12511072159010413091431
setupStore7453668
WebpackHomeuiStartup16111402217615416721961
load14001211187514214771689
domContentLoaded14001210187514214771688
domInteractive9240202218996
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21157672228
firstReactRender36296063850
getState9431579
initialActions102111
loadScripts13811196185814214611670
setupStore8531489

…of approve row in simulations section (#32741)

- fix: cp-12.17.3 fix repeated re-rendering of approve row in
simulations section (#32658)

## **Description**
Fix repeated re-rendering of approve row in simulations section

## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4836

## **Manual testing steps**

1. Go to https://jumper.exchange/
2. Submit a swap
3. Ensure that approve row does not repeatedly re-renders

## **Screenshots/Recordings**
<img width="398" alt="Screenshot 2025-05-08 at 11 06 58 AM"

src="https://github.com/user-attachments/assets/1b91ccfb-cf9f-4e91-adfe-ffe47b865df1"
/>


## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[4b38599](4b38599)

Co-authored-by: Jyoti Puri <[email protected]>
@metamaskbot
Copy link
Collaborator Author

metamaskbot commented May 9, 2025

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • app/scripts/lib/transaction/metrics.test.ts
  • app/scripts/lib/transaction/metrics.ts
  • ui/pages/confirmations/components/confirm/footer/upgrade-cancel-modal/upgrade-cancel-modal.test.tsx
  • ui/pages/confirmations/components/confirm/info/approve/edit-spending-cap-modal/__snapshots__/edit-spending-cap-modal.test.tsx.snap
  • ui/pages/confirmations/components/confirm/info/approve/edit-spending-cap-modal/edit-spending-cap-modal.test.tsx

@metamaskbot
Copy link
Collaborator Author

Builds ready [ef69ba1]
UI Startup Metrics (1260 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1260113214035412951360
load10989611216571147974
domContentLoaded10929541206571142969
domInteractive18136581732
firstPaint7911371214424229969
backgroundConnect7421279
firstReactRender20145462033
getState14538879
initialActions001001
loadScripts84170395255877913
setupStore8423378
WebpackHomeuiStartup22551767264219623972562
load17971336230918518772139
domContentLoaded17901332230518318692116
domInteractive171388111546
firstPaint159653415925591
backgroundConnect28981153760
firstReactRender176533641176086
getState1942423169
initialActions318136
loadScripts17851331230417918662087
setupStore27732148409
FirefoxBrowserifyHomeuiStartup13981230171010414521630
load1249106315189413051439
domContentLoaded1249106315189413041439
domInteractive10537283278997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214129132232
firstReactRender24195042432
getState952032089
initialActions001001
loadScripts1229104814979312831417
setupStore6422368
WebpackHomeuiStartup16271415208514917271908
load14121225187813414901660
domContentLoaded14121224187813414891660
domInteractive9735184239097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24158192540
firstReactRender37296673947
getState9536589
initialActions102111
loadScripts13911207185913414621639
setupStore9529489

… cherry-pick (#32830)

Cherry-pick: #32733

Include Permit2 approvals in batch simulation changes.

In addition:

- Fix incorrect `Unlimited` label.
- Show loader in `Edit Spending Cap Modal` to prevent temporary token ID
display.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32733?quickstart=1)

Fixes:
[#4847](MetaMask/MetaMask-planning#4847)
[#4846](MetaMask/MetaMask-planning#4846)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32830?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Matthew Walsh <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [374792f]
UI Startup Metrics (1232 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1232111214585512631334
load10749541300591119984
domContentLoaded10689491288591130997
domInteractive1813143141628
firstPaint7281471297420239966
backgroundConnect7416279
firstReactRender2314142162045
getState14536879
initialActions001001
loadScripts823704104858855910
setupStore8420378
WebpackHomeuiStartup21791736267118422942430
load17341335215315917832077
domContentLoaded17251332214815317752053
domInteractive171258111453
firstPaint164653165524578
backgroundConnect29924126399
firstReactRender160533401066195
getState1541921969
initialActions318135
loadScripts17201331214515017742025
setupStore29631959339
FirefoxBrowserifyHomeuiStartup13361166165211113901602
load12031040153510812631404
domContentLoaded12031040153510812621404
domInteractive10039206318397
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2112117151936
firstReactRender21184432227
getState8436578
initialActions001001
loadScripts11831026152010812461375
setupStore842112166
WebpackHomeuiStartup15641404208114316401865
load13571186182713214401640
domContentLoaded13571186182713214401639
domInteractive9164331278895
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20144162139
firstReactRender34285253646
getState1143333389
initialActions102111
loadScripts13391167181213214251622
setupStore8530479

…jection of smart account update by user (#32854)

- fix: cp-12.17.3 Adding metrics to check rejection of smart account
update by user (#32737)

## **Description**

Adding metrics to check rejection of smart account update by user

## **Related issues**

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4845

## **Manual testing steps**

1. Go to test dapp and submit request 5792
2. Reject the request on splash page
3. Ensure that metrics event is recorded for the rejection

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[186b99b](186b99b)

Co-authored-by: Jyoti Puri <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [cbd0de0]
UI Startup Metrics (1224 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1224109513845712591325
load10729341235611153992
domContentLoaded10679261230611160988
domInteractive17135861629
firstPaint6791341240435218971
backgroundConnect6418279
firstReactRender2115131131934
getState13542779
initialActions001000
loadScripts82568897759868928
setupStore8527478
WebpackHomeuiStartup21681782264119923032412
load17211373213515117712047
domContentLoaded17131369209514817642036
domInteractive161257101445
firstPaint162613345824580
backgroundConnect289242263079
firstReactRender149533701036095
getState12358979
initialActions317135
loadScripts17081368206614317622007
setupStore26630747349
FirefoxBrowserifyHomeuiStartup14101236197312814671659
load12631089179812213161468
domContentLoaded12621089179812213161467
domInteractive10837289359196
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21135672134
firstReactRender24193732629
getState8430489
initialActions002001
loadScripts12451072178412213061452
setupStore842082067
WebpackHomeuiStartup16061423203314517011918
load13971228179913815001692
domContentLoaded13971227179913815001691
domInteractive9238237288695
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155782443
firstReactRender35294943745
getState9531688
initialActions002111
loadScripts13781210177913914771671
setupStore9551689

…pick (#32871)

Cherry-pick: #32697
Delete preference to persist user rejection of upgrade.

Fixes: MetaMask/MetaMask-planning#4840

1. Go to test dapp
2. Click 5792 upgrade request and reject it on splash screen
3. Click 5792 update again, you should be able to proceed with the
update

Uploading Screen Recording 2025-05-08 at 9.34.26 PM.mov…

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32871?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Jyoti Puri <[email protected]>
Co-authored-by: Matthew Walsh <[email protected]>
@metamaskbot
Copy link
Collaborator Author

Builds ready [275afe7]
UI Startup Metrics (1284 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1284116714816113241398
load111596412656111671265
domContentLoaded110995912586111601258
domInteractive19136791737
firstPaint790821211436196299
backgroundConnect7413289
firstReactRender231564102249
getState154781179
initialActions001001
loadScripts84970699759896945
setupStore8522389
WebpackHomeuiStartup21781677270619923132442
load17411311220517918222085
domContentLoaded17341305220017718122059
domInteractive171267111449
firstPaint152663866024078
backgroundConnect2810189223457
firstReactRender13653354926194
getState12438769
initialActions317136
loadScripts17291302219817518072031
setupStore2363033869
FirefoxBrowserifyHomeuiStartup1396118916499514581603
load1256106714889313171431
domContentLoaded1256106714879313171431
domInteractive11239302408897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201393102032
firstReactRender24196062535
getState7426289
initialActions001001
loadScripts1238105414709313001407
setupStore6418267
WebpackHomeuiStartup16301425199913917181946
load14191242180413714911722
domContentLoaded14181241180413714901721
domInteractive9438240298797
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22154862438
firstReactRender36296553846
getState9531589
initialActions002111
loadScripts13991225178913714751701
setupStore8531489

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32680?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <[email protected]>
@Gudahtt Gudahtt marked this pull request as ready for review May 13, 2025 20:19
@Gudahtt Gudahtt requested a review from a team as a code owner May 13, 2025 20:19
@metamaskbot
Copy link
Collaborator Author

Builds ready [61015c8]
UI Startup Metrics (1231 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231110614116112721350
load10829761257591130985
domContentLoaded10769721252581144981
domInteractive16135151628
firstPaint74798126443021398
backgroundConnect7426378
firstReactRender19153841931
getState12569979
initialActions001000
loadScripts831729100157858938
setupStore7516278
WebpackHomeuiStartup22121769261517723352502
load17631369222715718212057
domContentLoaded17561365222415518152045
domInteractive16125991441
firstPaint155653315825780
backgroundConnect299221253876
firstReactRender169534151086093
getState1742342859
initialActions316145
loadScripts17511363222215218132017
setupStore24629740288
FirefoxBrowserifyHomeuiStartup14071228176911114751650
load12631097161011013201501
domContentLoaded12621097161011013201501
domInteractive10638217329099
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2112121122136
firstReactRender23204842429
getState9443789
initialActions005101
loadScripts12441082159010913061486
setupStore7449667
WebpackHomeuiStartup15591389205314016071892
load13561201180412614051636
domContentLoaded13551201180412614051636
domInteractive9042141188894
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221581112243
firstReactRender34287663644
getState9429579
initialActions002111
loadScripts13371185179112613891620
setupStore8530579

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fix typo found during 12.17.3 testing. Migration version was set to the
latest on main instead of to 152.2.

Same PR on main:
#32881

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32883?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator Author

Builds ready [841cf4a]
UI Startup Metrics (1262 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1262113215206212961369
load10949481344641142979
domContentLoaded10889411339641145977
domInteractive18136381729
firstPaint7001201201444215973
backgroundConnect7423378
firstReactRender2416106132356
getState1761321568
initialActions001001
loadScripts839697107362871933
setupStore8527479
WebpackHomeuiStartup21771740259918823212437
load17281351225015617962031
domContentLoaded17211348224615517872018
domInteractive1812183191447
firstPaint159723925923880
backgroundConnect279224243677
firstReactRender161534161046093
getState1633203158
initialActions317145
loadScripts17161346224515217821994
setupStore21630037329
FirefoxBrowserifyHomeuiStartup1360117816559414131555
load1225106215339712841417
domContentLoaded1225106215339712831416
domInteractive10539297348697
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2012116121942
firstReactRender22195152427
getState7419289
initialActions001001
loadScripts1207104915179812691402
setupStore6434467
WebpackHomeuiStartup16001402217914816831939
load13931218198814514711702
domContentLoaded13921217198814514711702
domInteractive9036166198897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414299282331
firstReactRender34294943744
getState9431589
initialActions102111
loadScripts13711202197414514511683
setupStore1152952989

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I didn't manually test, but @bschorchit and @cryptotavares did extensive manual testing. @bschorchit has signed off on the release on Slack.

@Gudahtt Gudahtt merged commit 51b253c into master May 13, 2025
536 of 545 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-bot Bot team (for MetaMask Bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants