fix: cp-12.17.3 Remove upgrade rejection persistence #32697

jpuri · 2025-05-08T16:06:25Z

Description

Delete preference to persist user rejection of upgrade.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4840

Manual testing steps

Go to test dapp
Click 5792 upgrade request and reject it on splash screen
Click 5792 update again, you should be able to proceed with the update

Screenshots/Recordings

Uploading Screen Recording 2025-05-08 at 9.34.26 PM.mov…

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-08T16:06:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-05-08T16:08:35Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/components/confirm/splash/smart-account-update/smart-account-update.test.tsx
ui/pages/confirmations/hooks/useSmartAccountActions.test.ts
ui/pages/confirmations/hooks/useSmartAccountActions.ts

metamaskbot · 2025-05-08T16:55:36Z

Builds ready [cad9473]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1090	1428	63	1248	1330
			load	1063	958	1188	56	1099	1169
			domContentLoaded	1056	944	1177	56	1094	1164
			domInteractive	17	13	48	5	16	25
			firstPaint	689	82	1197	430	1083	1158
			backgroundConnect	8	4	55	6	8	21
			firstReactRender	19	15	51	4	20	24
			getState	14	6	51	8	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	814	698	933	54	851	913
			setupStore	8	5	19	2	8	13
	Webpack	Home	uiStartup	2123	1664	2598	183	2253	2400
			load	1650	1285	2118	143	1730	1850
			domContentLoaded	1643	1282	2110	141	1724	1825
			domInteractive	15	11	43	8	13	37
			firstPaint	165	62	327	56	186	289
			backgroundConnect	27	10	132	16	32	53
			firstReactRender	160	51	360	98	281	343
			getState	16	4	273	31	12	34
			initialActions	3	1	6	1	3	5
			loadScripts	1638	1281	2104	140	1721	1813
			setupStore	20	6	263	32	19	38
Firefox	Browserify	Home	uiStartup	1360	1149	1671	117	1440	1604
			load	1207	1029	1530	105	1272	1411
			domContentLoaded	1207	1029	1529	105	1272	1410
			domInteractive	96	38	180	27	106	158
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	12	235	24	22	57
			firstReactRender	23	19	58	5	23	27
			getState	12	4	208	28	8	31
			initialActions	0	0	1	0	0	1
			loadScripts	1186	1016	1508	102	1254	1384
			setupStore	12	4	227	34	6	23
	Webpack	Home	uiStartup	1544	1376	2152	153	1583	1921
			load	1319	1185	1703	119	1374	1620
			domContentLoaded	1318	1185	1703	119	1374	1620
			domInteractive	79	52	137	16	89	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	82	12	24	41
			firstReactRender	35	29	53	5	39	48
			getState	10	5	35	7	9	30
			initialActions	0	0	2	1	1	1
			loadScripts	1298	1168	1683	119	1356	1599
			setupStore	15	5	343	45	8	42

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 42 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 25ms
Sum of all benchmark exceeds: 34ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -1012 Bytes (-0.02%)
ui: -38 Bytes (0%)
common: -120 Bytes (0%)

metamaskbot · 2025-05-09T07:31:28Z

Builds ready [d664488]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1218 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1100	1562	71	1259	1330
			load	1066	964	1280	60	1105	1156
			domContentLoaded	1059	938	1247	61	1099	1152
			domInteractive	17	13	44	5	16	24
			firstPaint	719	130	1195	418	1078	1134
			backgroundConnect	8	3	38	6	8	24
			firstReactRender	19	15	41	4	19	27
			getState	13	5	32	7	18	25
			initialActions	0	0	1	0	0	1
			loadScripts	819	710	986	59	862	916
			setupStore	7	4	14	2	8	12
	Webpack	Home	uiStartup	2175	1706	2525	187	2321	2460
			load	1690	1312	2211	152	1797	1874
			domContentLoaded	1684	1309	2205	151	1793	1870
			domInteractive	16	11	49	9	13	44
			firstPaint	161	62	350	66	186	323
			backgroundConnect	31	9	380	38	35	64
			firstReactRender	173	53	367	108	283	349
			getState	17	4	264	32	16	41
			initialActions	3	1	7	1	3	6
			loadScripts	1679	1307	2203	152	1788	1869
			setupStore	26	6	287	42	24	153
Firefox	Browserify	Home	uiStartup	1362	1179	1696	117	1430	1647
			load	1216	1052	1576	113	1271	1458
			domContentLoaded	1216	1052	1576	113	1271	1458
			domInteractive	99	40	216	29	114	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	58	6	21	30
			firstReactRender	23	19	55	7	23	34
			getState	8	4	26	4	8	13
			initialActions	0	0	6	1	0	1
			loadScripts	1199	1038	1554	113	1257	1441
			setupStore	9	4	182	24	6	12
	Webpack	Home	uiStartup	1562	1380	2244	152	1589	1865
			load	1342	1179	1865	137	1381	1657
			domContentLoaded	1342	1179	1864	137	1381	1656
			domInteractive	77	40	158	18	82	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	54	7	24	38
			firstReactRender	36	29	65	6	38	47
			getState	9	5	31	5	9	26
			initialActions	0	0	2	1	1	1
			loadScripts	1322	1159	1818	135	1362	1637
			setupStore	9	5	106	11	8	26

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2461 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 153 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1637 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 108ms
Sum of all benchmark exceeds: 109ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -212 Bytes (0%)
ui: 4.27 KiB (0.06%)
common: 218 Bytes (0%)

app/scripts/migrations/157.test.ts

metamaskbot · 2025-05-09T10:12:03Z

Builds ready [2d3821f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1080	1516	64	1258	1309
			load	1058	963	1310	61	1109	1146
			domContentLoaded	1051	959	1304	61	1100	1140
			domInteractive	16	13	27	3	16	24
			firstPaint	721	83	1180	416	1068	1138
			backgroundConnect	8	4	41	6	8	23
			firstReactRender	20	15	52	6	20	31
			getState	15	5	73	10	21	33
			initialActions	0	0	1	0	0	1
			loadScripts	809	717	1062	61	857	898
			setupStore	8	5	25	3	8	12
	Webpack	Home	uiStartup	2213	1779	2544	168	2318	2434
			load	1712	1378	2092	139	1811	1878
			domContentLoaded	1704	1374	2088	138	1804	1868
			domInteractive	16	12	70	11	13	47
			firstPaint	164	62	595	76	176	297
			backgroundConnect	29	10	73	14	40	56
			firstReactRender	205	54	360	105	302	340
			getState	17	4	322	32	18	27
			initialActions	3	1	8	1	4	6
			loadScripts	1699	1372	2086	138	1800	1866
			setupStore	22	6	199	26	24	39
Firefox	Browserify	Home	uiStartup	1339	1160	1720	113	1396	1594
			load	1199	1040	1549	108	1260	1415
			domContentLoaded	1199	1040	1548	108	1259	1415
			domInteractive	101	40	178	28	114	155
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	73	8	20	30
			firstReactRender	24	19	55	8	23	51
			getState	9	4	225	22	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1183	1028	1534	107	1246	1399
			setupStore	6	4	34	4	6	10
	Webpack	Home	uiStartup	1550	1359	2030	134	1618	1845
			load	1325	1171	1739	116	1393	1557
			domContentLoaded	1325	1171	1739	116	1393	1557
			domInteractive	79	44	139	16	86	116
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	291	28	24	44
			firstReactRender	37	29	56	6	40	48
			getState	11	5	52	8	10	29
			initialActions	0	0	2	1	1	1
			loadScripts	1302	1156	1723	114	1370	1538
			setupStore	12	5	294	29	8	21

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2214 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1712 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1705 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1700 exceeds gate value 1699 for chrome webpack home mean loadScripts
Sum of mean exceeds: 26ms | Sum of p95 exceeds: 5ms
Sum of all benchmark exceeds: 31ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -164 Bytes (0%)
ui: 4.31 KiB (0.06%)
common: 218 Bytes (0%)

metamaskbot · 2025-05-09T12:05:41Z

Builds ready [b1a3647]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1095	1421	71	1288	1377
			load	1084	959	1265	70	1126	1225
			domContentLoaded	1078	949	1256	70	1121	1219
			domInteractive	17	13	31	4	17	26
			firstPaint	781	149	1261	417	1101	1226
			backgroundConnect	8	4	28	4	8	15
			firstReactRender	21	16	66	7	21	35
			getState	16	6	80	11	20	33
			initialActions	0	0	1	0	0	1
			loadScripts	833	709	1015	68	871	967
			setupStore	8	5	17	2	8	13
	Webpack	Home	uiStartup	2170	1768	2614	159	2267	2398
			load	1690	1343	2279	142	1753	1859
			domContentLoaded	1684	1340	2275	142	1749	1855
			domInteractive	16	12	56	10	14	49
			firstPaint	163	60	395	63	184	314
			backgroundConnect	27	10	164	18	31	48
			firstReactRender	178	54	395	110	298	364
			getState	12	4	43	7	15	29
			initialActions	3	1	8	1	4	6
			loadScripts	1679	1338	2274	143	1745	1854
			setupStore	21	7	314	34	20	41
Firefox	Browserify	Home	uiStartup	1334	1171	1644	113	1380	1620
			load	1196	1042	1524	110	1248	1439
			domContentLoaded	1196	1042	1524	110	1248	1439
			domInteractive	102	40	293	34	111	177
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	18	13	65	6	19	24
			firstReactRender	23	19	67	7	22	49
			getState	8	4	62	7	8	14
			initialActions	0	0	2	0	0	1
			loadScripts	1179	1026	1510	109	1231	1419
			setupStore	6	4	34	4	6	14
	Webpack	Home	uiStartup	1655	1459	2181	148	1746	1993
			load	1415	1251	1933	141	1517	1752
			domContentLoaded	1414	1250	1933	141	1517	1752
			domInteractive	81	37	138	18	90	117
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	63	7	27	39
			firstReactRender	39	30	52	5	42	49
			getState	10	5	31	5	10	21
			initialActions	0	0	2	1	1	1
			loadScripts	1393	1231	1912	142	1493	1738
			setupStore	10	5	51	6	9	25

cc: @HowardBraham
Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1085 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1078 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1378 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1225 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1219 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1227 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 967 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 1656 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1415 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1393 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1993 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1752 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1752 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1738 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 191ms | Sum of p95 exceeds: 511ms
Sum of all benchmark exceeds: 702ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -210 Bytes (0%)
ui: 4.42 KiB (0.06%)
common: 218 Bytes (0%)

app/scripts/migrations/157.ts

metamaskbot · 2025-05-09T15:33:56Z

Builds ready [5cd15af]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1183 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1183	1090	1356	60	1215	1297
			load	1037	946	1156	51	1070	1138
			domContentLoaded	1030	935	1151	52	1064	1132
			domInteractive	16	13	34	3	16	24
			firstPaint	700	130	1168	416	1053	1141
			backgroundConnect	8	4	26	5	7	24
			firstReactRender	18	15	32	3	18	23
			getState	14	5	56	8	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	791	702	915	48	823	893
			setupStore	7	4	17	2	7	9
	Webpack	Home	uiStartup	2165	1710	2504	181	2295	2433
			load	1678	1351	2011	137	1770	1866
			domContentLoaded	1671	1345	2007	136	1763	1859
			domInteractive	16	11	58	11	13	47
			firstPaint	172	65	553	72	186	323
			backgroundConnect	34	10	325	42	38	72
			firstReactRender	182	55	354	110	307	349
			getState	12	4	37	7	16	27
			initialActions	3	1	7	1	3	5
			loadScripts	1666	1343	1984	136	1759	1840
			setupStore	19	6	179	18	22	35
Firefox	Browserify	Home	uiStartup	1368	1166	1763	116	1424	1605
			load	1226	1042	1614	115	1289	1469
			domContentLoaded	1225	1041	1614	115	1289	1469
			domInteractive	107	35	363	40	116	163
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	132	13	20	32
			firstReactRender	23	19	68	7	22	30
			getState	8	4	38	5	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1207	1028	1594	113	1270	1451
			setupStore	6	4	55	6	6	11
	Webpack	Home	uiStartup	1603	1417	2121	144	1650	1931
			load	1365	1224	1815	126	1420	1628
			domContentLoaded	1364	1224	1815	126	1420	1627
			domInteractive	79	33	142	18	87	114
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	71	9	26	46
			firstReactRender	39	30	59	6	42	53
			getState	11	5	40	7	11	32
			initialActions	0	0	1	0	1	1
			loadScripts	1342	1199	1788	125	1401	1598
			setupStore	12	5	322	31	9	13

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 10ms
Sum of all benchmark exceeds: 11ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -145 Bytes (0%)
ui: 4.49 KiB (0.06%)
common: 1016 Bytes (0.01%)

metamaskbot · 2025-05-13T06:02:56Z

Builds ready [b2fff02]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1174 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1174	1056	1501	57	1204	1257
			load	1025	932	1308	50	1048	1105
			domContentLoaded	1019	928	1302	50	1043	1099
			domInteractive	16	13	25	3	16	24
			firstPaint	675	99	1312	409	1036	1083
			backgroundConnect	7	3	25	3	7	15
			firstReactRender	19	15	51	5	20	33
			getState	13	5	30	7	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	782	701	1064	50	803	869
			setupStore	7	4	17	2	8	10
	Webpack	Home	uiStartup	2163	1715	2534	151	2273	2383
			load	1676	1314	1948	105	1749	1822
			domContentLoaded	1668	1311	1941	104	1742	1817
			domInteractive	16	11	59	10	13	45
			firstPaint	163	65	366	63	186	302
			backgroundConnect	29	9	197	23	35	64
			firstReactRender	182	54	350	105	303	342
			getState	16	4	307	30	16	26
			initialActions	3	1	7	1	3	5
			loadScripts	1664	1310	1918	104	1739	1816
			setupStore	19	6	311	30	20	30
Firefox	Browserify	Home	uiStartup	1353	1156	1835	120	1398	1596
			load	1205	1028	1539	104	1271	1405
			domContentLoaded	1204	1028	1538	104	1271	1405
			domInteractive	102	36	289	38	112	172
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	67	9	22	42
			firstReactRender	24	19	58	8	23	50
			getState	13	4	256	34	8	24
			initialActions	0	0	1	0	0	1
			loadScripts	1186	1011	1523	104	1255	1373
			setupStore	6	4	22	3	6	12
	Webpack	Home	uiStartup	1560	1371	2132	142	1628	1838
			load	1334	1175	1806	119	1395	1560
			domContentLoaded	1333	1175	1805	119	1395	1559
			domInteractive	82	44	205	22	87	131
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	76	9	22	44
			firstReactRender	35	29	61	5	37	43
			getState	12	4	334	33	9	22
			initialActions	0	0	2	1	1	1
			loadScripts	1315	1157	1790	118	1372	1543
			setupStore	8	5	35	4	8	18

Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 0ms
Sum of all benchmark exceeds: 2ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -426 Bytes (-0.01%)
ui: -35 Bytes (0%)
common: -117 Bytes (0%)

app/scripts/migrations/158.ts

metamaskbot · 2025-05-13T13:14:15Z

Builds ready [da803bb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1102	1546	67	1216	1318
			load	1035	902	1300	64	1065	1142
			domContentLoaded	1028	897	1291	64	1058	1134
			domInteractive	16	13	30	3	16	24
			firstPaint	723	95	1174	400	1052	1112
			backgroundConnect	7	4	31	4	8	16
			firstReactRender	20	14	56	6	20	32
			getState	15	5	45	8	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	788	662	1049	62	815	882
			setupStore	8	5	18	3	8	16
	Webpack	Home	uiStartup	2141	1714	2530	169	2276	2339
			load	1667	1255	1949	141	1763	1856
			domContentLoaded	1661	1248	1934	140	1755	1848
			domInteractive	16	11	59	10	13	46
			firstPaint	184	60	1729	174	192	316
			backgroundConnect	27	9	237	25	31	59
			firstReactRender	142	54	397	94	150	339
			getState	13	4	173	17	15	25
			initialActions	3	1	6	1	3	4
			loadScripts	1657	1245	1910	140	1753	1846
			setupStore	23	6	391	48	18	40
Firefox	Browserify	Home	uiStartup	1440	1231	2009	146	1494	1732
			load	1278	1085	1724	129	1351	1522
			domContentLoaded	1278	1084	1724	129	1350	1522
			domInteractive	111	37	290	36	127	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	70	8	23	38
			firstReactRender	26	21	67	8	25	54
			getState	11	5	207	20	9	25
			initialActions	0	0	1	0	0	1
			loadScripts	1259	1069	1699	127	1328	1506
			setupStore	11	4	292	29	7	37
	Webpack	Home	uiStartup	1522	1349	2049	124	1566	1805
			load	1299	1170	1750	103	1340	1525
			domContentLoaded	1299	1169	1750	103	1340	1524
			domInteractive	77	37	136	16	84	114
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	290	27	24	34
			firstReactRender	35	28	53	5	38	47
			getState	11	5	33	8	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1279	1147	1726	102	1321	1501
			setupStore	8	5	39	6	8	23

Benchmark value 1440 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1279 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1279 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 1260 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1732 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1522 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1522 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1506 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Sum of mean exceeds: 144ms | Sum of p95 exceeds: 168ms
Sum of all benchmark exceeds: 312ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -481 Bytes (-0.01%)
ui: 1.6 KiB (0.02%)
common: 62 Bytes (0%)

metamaskbot · 2025-05-13T14:02:13Z

Builds ready [69837ca]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1211	1097	1369	59	1248	1321
			load	1060	957	1203	54	1087	1162
			domContentLoaded	1053	952	1197	55	1082	1155
			domInteractive	17	13	46	4	16	25
			firstPaint	714	137	1168	423	1068	1149
			backgroundConnect	8	4	29	5	8	23
			firstReactRender	21	15	49	7	21	40
			getState	13	5	40	8	18	30
			initialActions	0	0	1	0	0	1
			loadScripts	810	722	961	54	845	905
			setupStore	7	5	20	3	8	14
	Webpack	Home	uiStartup	2218	1707	2549	191	2351	2475
			load	1732	1334	2197	168	1831	1943
			domContentLoaded	1725	1331	2192	168	1827	1932
			domInteractive	16	12	60	9	14	42
			firstPaint	174	66	335	64	203	320
			backgroundConnect	33	9	234	28	36	82
			firstReactRender	180	56	406	110	295	353
			getState	14	4	40	8	18	33
			initialActions	3	1	7	1	4	6
			loadScripts	1718	1329	2191	163	1825	1921
			setupStore	25	7	326	40	24	43
Firefox	Browserify	Home	uiStartup	1338	1156	1844	125	1379	1565
			load	1202	1032	1697	125	1247	1440
			domContentLoaded	1201	1032	1697	125	1247	1440
			domInteractive	107	40	379	53	112	191
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	215	20	19	32
			firstReactRender	23	19	58	8	22	50
			getState	7	4	35	3	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1183	1018	1671	120	1230	1414
			setupStore	6	4	35	4	6	7
	Webpack	Home	uiStartup	1552	1388	2017	126	1600	1855
			load	1327	1188	1772	116	1384	1573
			domContentLoaded	1326	1188	1772	116	1384	1573
			domInteractive	78	36	236	24	81	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	15	302	29	24	43
			firstReactRender	36	29	56	5	39	46
			getState	10	5	68	7	10	18
			initialActions	0	0	2	1	1	1
			loadScripts	1304	1169	1753	111	1360	1535
			setupStore	11	5	276	27	8	26

Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2219 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1733 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1726 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1718 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2475 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Sum of mean exceeds: 91ms | Sum of p95 exceeds: 26ms
Sum of all benchmark exceeds: 117ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -481 Bytes (-0.01%)
ui: 1.6 KiB (0.02%)
common: 62 Bytes (0%)

Gudahtt · 2025-05-13T16:44:09Z

Force-merged to get past flaky test failures in the queue, to unblock release preparation.

Remove upgrade rejection persistence

c902774

jpuri requested a review from a team as a code owner May 8, 2025 16:06

jpuri added the team-confirmations Push issues to confirmations team label May 8, 2025

jpuri added 3 commits May 8, 2025 21:49

update

2f57318

update

f5843e4

update

cad9473

update

d664488

matthewwalsh0 previously approved these changes May 9, 2025

View reviewed changes

app/scripts/migrations/157.test.ts Outdated Show resolved Hide resolved

update

2d3821f

jpuri dismissed matthewwalsh0’s stale review via 2d3821f May 9, 2025 09:39

jpuri added 2 commits May 9, 2025 16:42

update

0458ff4

update

b1a3647

jpuri requested a review from matthewwalsh0 May 9, 2025 12:55

cryptotavares reviewed May 9, 2025

View reviewed changes

app/scripts/migrations/157.ts Outdated Show resolved Hide resolved

vpintorico added the release-12.17.3 label May 9, 2025

update

5cd15af

jpuri requested a review from cryptotavares May 9, 2025 16:14

jpuri added 2 commits May 13, 2025 10:57

update

9538c5b

merge

b2fff02

pedronfigueiredo reviewed May 13, 2025

View reviewed changes

app/scripts/migrations/158.ts Outdated Show resolved Hide resolved

Gudahtt reviewed May 13, 2025

View reviewed changes

app/scripts/migrations/158.ts Outdated Show resolved Hide resolved

update

da803bb

pedronfigueiredo previously approved these changes May 13, 2025

View reviewed changes

matthewwalsh0 previously approved these changes May 13, 2025

View reviewed changes

jpuri enabled auto-merge May 13, 2025 12:51

update

69837ca

jpuri dismissed stale reviews from matthewwalsh0 and pedronfigueiredo via 69837ca May 13, 2025 13:29

pedronfigueiredo approved these changes May 13, 2025

View reviewed changes

matthewwalsh0 approved these changes May 13, 2025

View reviewed changes

jpuri added this pull request to the merge queue May 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025

DDDDDanica added this pull request to the merge queue May 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025

Gudahtt merged commit 3762a22 into main May 13, 2025
273 of 276 checks passed

Gudahtt deleted the remove_disable_upgrade_preference branch May 13, 2025 16:33

github-actions bot locked and limited conversation to collaborators May 13, 2025

metamaskbot added the release-12.19.0 label May 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cp-12.17.3 Remove upgrade rejection persistence #32697

fix: cp-12.17.3 Remove upgrade rejection persistence #32697

jpuri commented May 8, 2025

github-actions bot commented May 8, 2025

metamaskbot commented May 8, 2025

metamaskbot commented May 8, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 13, 2025

metamaskbot commented May 13, 2025

metamaskbot commented May 13, 2025

Gudahtt commented May 13, 2025

fix: cp-12.17.3 Remove upgrade rejection persistence #32697

fix: cp-12.17.3 Remove upgrade rejection persistence #32697

Conversation

jpuri commented May 8, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented May 8, 2025

metamaskbot commented May 8, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented May 8, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 9, 2025

metamaskbot commented May 13, 2025

metamaskbot commented May 13, 2025

metamaskbot commented May 13, 2025

Gudahtt commented May 13, 2025