fix: use `to` and `from` to check if transaction is a batch transaction cp-12.18.0 #32190

vinistevam · 2025-04-23T13:09:10Z

Description

This PR aims to verify to and from to check if the transaction is a batch transaction.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4752

Manual testing steps

Go to test dapp
Under EIP 5792, click on Send Calls
See pill with Includes x transactions under the confirmation title

Screenshots/Recordings

interact.with.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-23T13:09:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-23T13:11:18Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/components/confirm/info/shared/transaction-details/__snapshots__/transaction-details.test.tsx.snap
ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.test.tsx
ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

…atch-check

metamaskbot · 2025-04-24T05:14:17Z

Builds ready [cc14916]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1210 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1210	1101	1480	71	1243	1329
			load	1046	947	1271	63	1087	1165
			domContentLoaded	1040	942	1260	62	1081	1159
			domInteractive	18	13	63	8	16	28
			firstPaint	725	81	1269	408	1063	1141
			backgroundConnect	7	4	24	3	8	12
			firstReactRender	21	15	45	6	21	36
			getState	13	5	33	8	19	28
			initialActions	0	0	1	0	0	1
			loadScripts	804	709	1018	59	847	922
			setupStore	7	4	14	2	8	13
	Webpack	Home	uiStartup	2070	1555	2465	178	2193	2310
			load	1605	1238	2003	142	1699	1835
			domContentLoaded	1598	1232	2000	141	1692	1817
			domInteractive	15	11	57	11	13	49
			firstPaint	172	67	574	69	201	277
			backgroundConnect	25	9	181	21	24	59
			firstReactRender	183	54	383	117	311	358
			getState	11	3	49	6	13	20
			initialActions	3	1	6	1	3	4
			loadScripts	1593	1230	1998	142	1689	1816
			setupStore	18	6	287	28	19	30
Firefox	Browserify	Home	uiStartup	1349	1157	1686	99	1418	1540
			load	1204	1032	1521	106	1272	1387
			domContentLoaded	1204	1031	1521	106	1271	1387
			domInteractive	108	35	352	44	123	167
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	103	11	21	41
			firstReactRender	22	19	35	3	23	28
			getState	7	4	15	2	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1185	1014	1492	107	1258	1367
			setupStore	6	4	24	3	6	10
	Webpack	Home	uiStartup	1495	1277	1918	121	1547	1798
			load	1280	1113	1654	108	1334	1553
			domContentLoaded	1280	1113	1654	108	1334	1553
			domInteractive	79	33	290	27	85	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	82	13	22	58
			firstReactRender	35	29	62	5	36	44
			getState	8	4	26	4	9	19
			initialActions	1	0	2	1	1	1
			loadScripts	1259	1103	1641	106	1318	1535
			setupStore	9	5	45	7	8	25

Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 9ms
Sum of all benchmark exceeds: 9ms

metamaskbot · 2025-04-24T15:51:51Z

Builds ready [6c32825]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1277 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1277	1137	1536	73	1318	1410
			load	1102	987	1340	72	1136	1241
			domContentLoaded	1095	944	1334	73	1127	1233
			domInteractive	19	14	72	8	18	33
			firstPaint	726	84	1339	443	1106	1231
			backgroundConnect	9	4	138	13	8	18
			firstReactRender	23	16	73	9	22	42
			getState	14	4	45	9	19	33
			initialActions	0	0	1	0	0	1
			loadScripts	846	693	1089	69	885	978
			setupStore	9	5	23	3	9	15
	Webpack	Home	uiStartup	2109	1705	2390	167	2239	2350
			load	1638	1333	1840	122	1739	1806
			domContentLoaded	1631	1329	1814	120	1732	1797
			domInteractive	15	11	80	10	13	42
			firstPaint	178	69	576	82	219	328
			backgroundConnect	25	10	81	15	27	60
			firstReactRender	201	55	379	118	323	359
			getState	12	4	85	10	14	26
			initialActions	3	1	7	1	3	5
			loadScripts	1626	1328	1810	120	1729	1794
			setupStore	19	7	291	28	20	32
Firefox	Browserify	Home	uiStartup	1329	1151	1817	124	1387	1618
			load	1188	1013	1690	128	1242	1502
			domContentLoaded	1187	1012	1690	128	1242	1502
			domInteractive	102	35	172	24	114	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	120	16	20	55
			firstReactRender	22	18	53	6	22	31
			getState	10	4	203	25	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1167	997	1662	131	1222	1488
			setupStore	5	3	10	1	6	7
	Webpack	Home	uiStartup	1521	1323	2008	131	1595	1773
			load	1308	1124	1730	123	1372	1577
			domContentLoaded	1307	1124	1730	123	1371	1576
			domInteractive	86	37	164	24	97	142
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	75	9	23	38
			firstReactRender	35	29	63	5	36	44
			getState	9	5	34	5	9	22
			initialActions	0	0	1	0	1	1
			loadScripts	1287	1103	1702	120	1346	1530
			setupStore	7	5	31	3	8	11

cc: @HowardBraham
Benchmark value 1278 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1103 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1095 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 846 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1411 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1241 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1234 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1231 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 978 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 1502 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1502 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1488 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Sum of mean exceeds: 127ms | Sum of p95 exceeds: 267ms
Sum of all benchmark exceeds: 394ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -998 Bytes (-0.02%)
ui: 742 Bytes (0.01%)
common: 1.07 KiB (0.01%)

metamaskbot · 2025-04-25T14:24:26Z

Builds ready [00af427]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1201 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1201	1088	1404	60	1241	1325
			load	1040	940	1221	57	1075	1151
			domContentLoaded	1034	936	1195	56	1070	1146
			domInteractive	18	13	67	10	17	33
			firstPaint	669	133	1231	421	1053	1168
			backgroundConnect	7	4	21	2	7	10
			firstReactRender	20	16	35	3	20	28
			getState	13	5	32	7	19	25
			initialActions	0	0	1	0	0	1
			loadScripts	799	712	951	55	834	900
			setupStore	7	4	17	2	8	13
	Webpack	Home	uiStartup	2127	1701	2616	173	2252	2352
			load	1650	1327	2096	138	1738	1917
			domContentLoaded	1641	1323	2020	131	1728	1876
			domInteractive	15	11	64	10	13	42
			firstPaint	180	64	462	68	228	303
			backgroundConnect	29	9	234	33	27	71
			firstReactRender	204	54	366	118	334	358
			getState	16	4	255	35	13	25
			initialActions	3	1	7	1	4	5
			loadScripts	1637	1322	1996	129	1726	1867
			setupStore	17	6	45	8	22	32
Firefox	Browserify	Home	uiStartup	1346	1149	1685	112	1394	1609
			load	1205	1008	1567	115	1269	1441
			domContentLoaded	1205	1008	1567	115	1269	1441
			domInteractive	101	38	220	30	113	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	79	8	19	27
			firstReactRender	22	18	55	6	22	30
			getState	7	4	27	3	7	10
			initialActions	0	0	1	0	0	1
			loadScripts	1189	995	1551	114	1252	1425
			setupStore	6	4	25	3	6	8
	Webpack	Home	uiStartup	1460	1301	1815	114	1527	1710
			load	1253	1126	1568	101	1327	1463
			domContentLoaded	1253	1126	1567	101	1327	1463
			domInteractive	76	35	139	16	84	110
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	128	17	22	44
			firstReactRender	34	28	71	5	36	43
			getState	10	4	48	8	9	32
			initialActions	1	0	2	1	1	1
			loadScripts	1231	1111	1554	98	1314	1426
			setupStore	8	5	27	4	8	18

Bundle size diffs

background: 0 Bytes (0%)
ui: 22 Bytes (0%)
common: 0 Bytes (0%)

vinistevam and others added 21 commits April 10, 2025 06:57

feat: add nested transactions tag

ea7878c

fix: lint

3404ee4

fix: locales

000e618

Merge branch 'main' into feat/nested-transaction-tag

bf64839

Merge branch 'main' into feat/nested-transaction-tag

7c7b0bc

fix: applied suggestions

3e02eaa

Merge branch 'main' into feat/nested-transaction-tag

c38a6e4

fix: lint

3429c8c

fix: add comment

cb1b826

Merge branch 'main' into feat/nested-transaction-tag

2265af8

feat: add info alert to account type smart account

fc1a3a8

fix: display Interacting with in transaction details section

28102bc

fix: pipeline

0c3ccb5

fix: lint

c826a2c

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

0cc7bc9

fix: clean up

f3f6cfd

fix: apply suggestions

7078eb1

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

8183ff3

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

01f3657

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

be0d0e3

fix: check to and from to verify isBatch

61e2909

vinistevam added the team-confirmations Push issues to confirmations team label Apr 23, 2025

vinistevam marked this pull request as ready for review April 23, 2025 13:38

vinistevam requested a review from a team as a code owner April 23, 2025 13:38

vinistevam added 3 commits April 23, 2025 14:38

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

a5433db

Merge branch 'feat/add-info-account-type-upgrade-alert' into fix/is-b…

cc14916

…atch-check

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

4809419

vinistevam dismissed stale reviews from matthewwalsh0, jpuri, and pedronfigueiredo via 6c32825 April 24, 2025 14:51

pedronfigueiredo previously approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into fix/is-batch-check

16de010

matthewwalsh0 previously approved these changes Apr 24, 2025

View reviewed changes

OGPoyraz previously approved these changes Apr 24, 2025

View reviewed changes

vinistevam enabled auto-merge April 24, 2025 17:05

jpuri previously approved these changes Apr 24, 2025

View reviewed changes

Merge branch 'main' into fix/is-batch-check

0ce95ab

vinistevam dismissed stale reviews from jpuri, OGPoyraz, matthewwalsh0, and pedronfigueiredo via 0ce95ab April 25, 2025 06:45

jpuri previously approved these changes Apr 25, 2025

View reviewed changes

OGPoyraz previously approved these changes Apr 25, 2025

View reviewed changes

check isUpgrade or isDowngrade

37e81c3

vinistevam dismissed stale reviews from OGPoyraz and jpuri via 37e81c3 April 25, 2025 12:52

Merge branch 'main' into fix/is-batch-check

00af427

OGPoyraz approved these changes Apr 28, 2025

View reviewed changes

jpuri approved these changes Apr 28, 2025

View reviewed changes

vinistevam added this pull request to the merge queue Apr 28, 2025

Merged via the queue into main with commit a8e2598 Apr 28, 2025
169 checks passed

vinistevam deleted the fix/is-batch-check branch April 28, 2025 08:12

github-actions bot locked and limited conversation to collaborators Apr 28, 2025

DDDDDanica changed the title ~~fix: use to and from to check if transaction is a batch transaction~~ fix: use to and from to check if transaction is a batch transaction cp-12.18.0 Apr 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use `to` and `from` to check if transaction is a batch transaction cp-12.18.0 #32190

fix: use `to` and `from` to check if transaction is a batch transaction cp-12.18.0 #32190

vinistevam commented Apr 23, 2025 •

edited

Loading

github-actions bot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025 •

edited

Loading

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 25, 2025

fix: use to and from to check if transaction is a batch transaction cp-12.18.0 #32190

fix: use to and from to check if transaction is a batch transaction cp-12.18.0 #32190

Conversation

vinistevam commented Apr 23, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 25, 2025

fix: use `to` and `from` to check if transaction is a batch transaction cp-12.18.0 #32190

fix: use `to` and `from` to check if transaction is a batch transaction cp-12.18.0 #32190

vinistevam commented Apr 23, 2025 •

edited

Loading

metamaskbot commented Apr 23, 2025 •

edited

Loading