Skip to content

Commit a8e2598

Browse files
authored
fix: use to and from to check if transaction is a batch transaction (#32190)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR aims to verify `to` and `from` to check if the transaction is a batch transaction. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32190?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#4752 ## **Manual testing steps** 1. Go to test dapp 2. Under EIP 5792, click on Send Calls 3. See pill with Includes x transactions under the confirmation title ## **Screenshots/Recordings** [interact with.webm](https://github.com/user-attachments/assets/a81d242e-92c3-4cd1-8757-a84b7596571e) ![image](https://github.com/user-attachments/assets/d63dd4d3-37c4-482b-920c-b39ea4e2adb4) ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent a420c18 commit a8e2598

File tree

3 files changed

+231
-155
lines changed

3 files changed

+231
-155
lines changed

ui/pages/confirmations/components/confirm/info/shared/transaction-details/__snapshots__/transaction-details.test.tsx.snap

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`<TransactionDetails /> does not render component for transaction details 1`] = `
3+
exports[`Transaction Details <TransactionDetails /> does not render component for transaction details 1`] = `
44
<div>
55
<div
66
class="mm-box mm-box--margin-bottom-4 mm-box--padding-2 mm-box--background-color-background-default mm-box--rounded-md"
@@ -9,7 +9,7 @@ exports[`<TransactionDetails /> does not render component for transaction detail
99
</div>
1010
`;
1111

12-
exports[`<TransactionDetails /> renders component for transaction details 1`] = `
12+
exports[`Transaction Details <TransactionDetails /> renders component for transaction details 1`] = `
1313
<div>
1414
<div
1515
class="mm-box mm-box--margin-bottom-4 mm-box--padding-2 mm-box--background-color-background-default mm-box--rounded-md"

0 commit comments

Comments
 (0)