Skip to content

chore: adds solana banner to carousel #32000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 23, 2025
Merged

chore: adds solana banner to carousel #32000

merged 14 commits into from
Apr 23, 2025
+126 −4

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Apr 15, 2025 •
edited
Loading

Description

This PR adds the solana banner/slide to the existing carousel, to the 1st position.
For users that don't have a solana account, it will invite you to create one when clicked.
For Users that already have a solana account it will just focus on it.

Screenshot 2025-04-15 at 15 11 09

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-solana PRs from the Solana snap team label Apr 15, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/account-overview/account-overview-layout.tsx
  • ui/components/multichain/carousel/carousel.tsx

@metamaskbot

This comment was marked as outdated.

Sign in to view
@zone-live zone-live mentioned this pull request Apr 15, 2025
Merged
7 tasks
@metamaskbot

This comment was marked as outdated.

Sign in to view
@zone-live zone-live marked this pull request as ready for review April 17, 2025 09:53
@zone-live zone-live requested a review from a team as a code owner April 17, 2025 09:53
@metamaskbot
Copy link
Collaborator

Builds ready [093e35f]
UI Startup Metrics (1203 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1203110213835712331319
load104194812405610771140
domContentLoaded103594512335610711135
domInteractive17136161627
firstPaint72178120540510621145
backgroundConnect64202710
firstReactRender21144652136
getState1253381728
initialActions002001
loadScripts79771699853832890
setupStore75172810
WebpackHomeuiStartup21421744256417022722385
load16471343199513217531829
domContentLoaded16401339197313117471821
domInteractive161158111350
firstPaint1826746772236332
backgroundConnect251065122953
firstReactRender22557375117338357
getState1243561521
initialActions317136
loadScripts16361338195013217451819
setupStore247299392237
FirefoxBrowserifyHomeuiStartup13551191163611314301584
load12011008151211712731456
domContentLoaded12011007151211712731456
domInteractive1033718528117157
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213132162051
firstReactRender23196662329
getState9421120710
initialActions001001
loadScripts1181995149611912511440
setupStore8416716612
WebpackHomeuiStartup14781296185611015481675
load12721126159010313371477
domContentLoaded12721126159010313371476
domInteractive81311492493139
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313291282139
firstReactRender33285143539
getState84305823
initialActions002111
loadScripts1251111215699913161455
setupStore84475817

@metamaskbot
Copy link
Collaborator

Builds ready [04a53ca]
UI Startup Metrics (1223 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1223110213516212791322
load105895611955510961157
domContentLoaded105294811905510921152
domInteractive18136181737
firstPaint711134120241610651162
backgroundConnect74213813
firstReactRender21164662135
getState1454681932
initialActions001001
loadScripts81271795454846913
setupStore85152812
WebpackHomeuiStartup21671759261218922782442
load16671363206114717831921
domContentLoaded16591359204914517771879
domInteractive161162101445
firstPaint1807735366219324
backgroundConnect339339443279
firstReactRender21655392121343365
getState154179191628
initialActions317145
loadScripts16541358202414417731870
setupStore247303392436
FirefoxBrowserifyHomeuiStartup17651443245319018872207
load15651273229218516571930
domContentLoaded15631272229218616561930
domInteractive1444164273163241
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect44172514437172
firstReactRender27214032835
getState165215251155
initialActions001001
loadScripts15251253227118416201832
setupStore95505912
WebpackHomeuiStartup15431353187511816321808
load13231160160510514101543
domContentLoaded13231160160510514091543
domInteractive85511922699147
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22146182240
firstReactRender35285853644
getState85314812
initialActions002111
loadScripts13041146158710513851526
setupStore10528928818

vinnyhoward
vinnyhoward previously approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [5a45599]
UI Startup Metrics (1228 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1228108114556412681339
load106095611755310911163
domContentLoaded105495311675210871156
domInteractive18136791734
firstPaint70691117442410751148
backgroundConnect74313710
firstReactRender24165792542
getState1454692134
initialActions001001
loadScripts81671892750847911
setupStore952231014
WebpackHomeuiStartup20611716254618221792346
load15981333203313717051824
domContentLoaded15921329200713516991814
domInteractive161148101346
firstPaint1798434759221293
backgroundConnect2610247262569
firstReactRender19754376121322355
getState133206201324
initialActions316135
loadScripts15871328198213416961812
setupStore1674772033
FirefoxBrowserifyHomeuiStartup13571193163710014291560
load12091049149510412841432
domContentLoaded12091049149510412841432
domInteractive1063626737122174
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211396102145
firstReactRender22195342227
getState942162179
initialActions001001
loadScripts11911023147210312651391
setupStore64354611
WebpackHomeuiStartup15251354206413416021774
load13041146175211713661536
domContentLoaded13041146175111713651536
domInteractive83452512891141
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231580102438
firstReactRender36295653846
getState94386926
initialActions102111
loadScripts12841126173011613471519
setupStore95669813
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 1ms
Sum of all benchmark exceeds: 2ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 127 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [175470e]
UI Startup Metrics (1242 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1242113916097512811377
load107597413926811071198
domContentLoaded106996613876711021192
domInteractive18146571729
firstPaint732136141342510821201
backgroundConnect74182810
firstReactRender21155662235
getState1353781829
initialActions001001
loadScripts827725111264863947
setupStore84193912
WebpackHomeuiStartup21951783249215623002399
load17021401195812517991897
domContentLoaded16951397193512317911882
domInteractive151261101347
firstPaint1826353673231310
backgroundConnect2810176203362
firstReactRender22054380118325368
getState184274321843
initialActions318135
loadScripts16901395191112317881877
setupStore267290472437
FirefoxBrowserifyHomeuiStartup14041209168910214721585
load12511079153710613191454
domContentLoaded12511078153710613191454
domInteractive1053826335120172
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201310792128
firstReactRender24205142429
getState84172813
initialActions001001
loadScripts12321063152010413021414
setupStore649167
WebpackHomeuiStartup14881335184711515641715
load1272115415479713161492
domContentLoaded1272115315479713151492
domInteractive79371502184136
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221382102242
firstReactRender35295353745
getState94557923
initialActions003111
loadScripts1253113715299612941464
setupStore85355824
cc: @HowardBraham
Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1377 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1202 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 948 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2195 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1251 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts
Sum of mean exceeds: 47ms | Sum of p95 exceeds: 62ms
Sum of all benchmark exceeds: 109ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 127 Bytes (0%)

vinnyhoward
vinnyhoward approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aganglada aganglada added this pull request to the merge queue Apr 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2025
@zone-live @aganglada
chore: adds solana banner to carousel (#32000)
accf0ba 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR adds the solana banner/slide to the existing carousel, to the
1st position.
For users that don't have a solana account, it will invite you to create
one when clicked.
For Users that already have a solana account it will just focus on it.

![Screenshot 2025-04-15 at 15 11
09](https://github.com/user-attachments/assets/bc251df0-e3f3-440e-8a70-367395b9cadb)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alejandro Garcia Anglada <[email protected]>
Merged via the queue into main with commit d05765a Apr 23, 2025
169 checks passed
@aganglada aganglada deleted the SOL-277-solana-banner branch April 23, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aganglada aganglada aganglada approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

Assignees
No one assigned
Labels
team-solana PRs from the Solana snap team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zone-live @metamaskbot @aganglada @vinnyhoward