Skip to content

chore: cherry-pick to v12.17.0 Solana snap update #32004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Apr 15, 2025

Description

No conflicts.

Cherry picks commit 09fe1c5072cfb6354ae048680cbe2e7b508cd176
Reference PR: #31976

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates the solana snap version

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@zone-live zone-live added the team-solana PRs from the Solana snap team label Apr 15, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title chore: cherry-pick to v12.17.0 Solana snap update (#31976) chore: cherry-pick to v12.17.0 Solana snap update Apr 15, 2025
Copy link

socket-security bot commented Apr 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​solana-wallet-snap@​1.19.0 ⏵ 1.21.094 +510085 +1100 +1100

View full report

@metamaskbot
Copy link
Collaborator

Builds ready [721a3ab]
UI Startup Metrics (1234 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1234112613745712821322
load10789731206521136981
domContentLoaded10739701201511132997
domInteractive18136291731
firstPaint6481441205434229294
backgroundConnect7422378
firstReactRender21163842232
getState156961279
initialActions001001
loadScripts82673994049867909
setupStore8521378
WebpackHomeuiStartup22071755269820023312651
load17221402216015418062057
domContentLoaded17141398213215018012017
domInteractive16126291442
firstPaint167654545822985
backgroundConnect289104183576
firstReactRender213553791205989
getState1742492559
initialActions317136
loadScripts17091397210214617971987
setupStore266255452558
FirefoxBrowserifyHomeuiStartup13841199171510614441585
load12391046159711013131442
domContentLoaded12391046159611013121441
domInteractive10644202298797
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313211222131
firstReactRender23195652330
getState7431479
initialActions001011
loadScripts12181032158211012931387
setupStore6337467
WebpackHomeuiStartup15761349216814316621833
load13631156189813314361609
domContentLoaded13621156189813314361609
domInteractive10445318358895
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20146262130
firstReactRender35294943743
getState8431589
initialActions102111
loadScripts13441145188013314171587
setupStore8534389

@dbrans dbrans merged commit ea3c792 into Version-v12.17.0 Apr 16, 2025
160 checks passed
@dbrans dbrans deleted the SOL-cherry-pick-12.17.0-solana-snap-version branch April 16, 2025 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-solana PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants