feat: add info alert linked to account type #31840

vinistevam · 2025-04-10T13:45:38Z

Description

This PR aims to:

add an info alert linked to the Account type row.
Change Type to Account Type for batch transactions.
Hide Account row for batch transactions.
Hide Interacting with from TransactionDetails and show in TransactionAccountDetails for batch transactions.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4660

Manual testing steps

Go to test dapp
Under EIP 5792, click on Send Calls
See pill with Includes x transactions under the confirmation title

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-10T13:54:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-11T13:22:29Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/components/confirm/info/batch/transaction-account-details/transaction-account-details.test.tsx
ui/pages/confirmations/components/confirm/info/batch/transaction-account-details/transaction-account-details.tsx
ui/pages/confirmations/components/confirm/info/batch/transaction-account-details/transasction-account-details.test.tsx
ui/pages/confirmations/components/confirm/info/hooks/useNestedTransactionLabels.ts
ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.test.tsx
ui/pages/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx
ui/pages/confirmations/components/transactions/nested-transaction-tag/nested-transaction-tag.tsx
ui/pages/confirmations/hooks/alerts/transactions/AccountTypeMessage.tsx
ui/pages/confirmations/hooks/alerts/transactions/useAccountTypeUpgrade.test.ts
ui/pages/confirmations/hooks/alerts/transactions/useAccountTypeUpgrade.ts
ui/pages/confirmations/hooks/useConfirmationAlerts.ts

metamaskbot · 2025-04-11T16:07:54Z

Builds ready [0c3ccb5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1213	1091	1430	67	1254	1332
			load	1061	943	1280	66	1189	990
			domContentLoaded	1055	936	1275	66	1275	990
			domInteractive	17	13	60	6	17	29
			firstPaint	680	105	1157	416	246	980
			backgroundConnect	7	4	49	6	7	8
			firstReactRender	20	15	45	6	20	34
			getState	15	5	59	10	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	816	690	1018	65	849	926
			setupStore	8	5	18	2	7	9
	Webpack	Home	uiStartup	2181	1736	2681	186	2298	2452
			load	1715	1278	2140	155	1789	2018
			domContentLoaded	1707	1272	2136	152	1781	2009
			domInteractive	18	12	86	14	14	62
			firstPaint	172	66	390	63	263	85
			backgroundConnect	28	10	182	22	30	61
			firstReactRender	188	54	368	108	57	88
			getState	16	4	310	30	7	9
			initialActions	3	1	7	1	3	4
			loadScripts	1701	1270	2106	149	1777	1979
			setupStore	23	6	385	46	30	9
Firefox	Browserify	Home	uiStartup	1336	1157	1778	107	1380	1578
			load	1198	1031	1635	107	1252	1436
			domContentLoaded	1198	1031	1634	107	1251	1435
			domInteractive	98	38	198	28	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	86	11	20	44
			firstReactRender	22	19	55	5	23	28
			getState	7	4	25	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1179	1018	1616	107	1233	1398
			setupStore	7	4	70	8	6	7
	Webpack	Home	uiStartup	1517	1324	1822	118	1594	1763
			load	1305	1133	1567	108	1389	1517
			domContentLoaded	1304	1133	1567	108	1389	1516
			domInteractive	92	38	176	19	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	74	7	21	32
			firstReactRender	34	28	62	5	36	44
			getState	8	4	36	6	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1286	1117	1550	108	1372	1501
			setupStore	9	5	55	8	7	9

metamaskbot · 2025-04-21T11:30:02Z

Builds ready [b6f4539]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1099	1446	62	1257	1329
			load	1058	950	1267	60	1087	1176
			domContentLoaded	1052	945	1257	59	1085	1165
			domInteractive	18	13	64	10	17	31
			firstPaint	698	133	1273	426	1064	1161
			backgroundConnect	7	4	12	2	8	10
			firstReactRender	21	16	41	5	21	33
			getState	13	5	45	8	19	28
			initialActions	0	0	2	0	0	1
			loadScripts	815	719	990	56	847	920
			setupStore	8	5	21	3	8	12
	Webpack	Home	uiStartup	2078	1693	2510	183	2223	2333
			load	1597	1295	2046	136	1709	1783
			domContentLoaded	1591	1292	2042	136	1705	1776
			domInteractive	15	11	59	10	13	45
			firstPaint	196	64	1543	150	231	324
			backgroundConnect	24	9	66	13	28	57
			firstReactRender	200	54	413	119	326	363
			getState	11	4	58	7	12	22
			initialActions	3	1	7	1	3	5
			loadScripts	1586	1290	2020	136	1702	1775
			setupStore	19	6	286	28	20	33
Firefox	Browserify	Home	uiStartup	1360	1163	1724	113	1397	1605
			load	1215	1030	1584	118	1262	1481
			domContentLoaded	1215	1030	1584	118	1262	1481
			domInteractive	114	39	253	40	128	199
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	105	15	19	39
			firstReactRender	22	19	50	4	22	28
			getState	7	4	28	3	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1196	1014	1570	117	1247	1465
			setupStore	8	4	209	20	6	7
	Webpack	Home	uiStartup	1464	1308	1758	105	1529	1662
			load	1251	1119	1569	94	1317	1446
			domContentLoaded	1251	1119	1568	93	1316	1446
			domInteractive	82	35	327	33	89	135
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	102	11	22	44
			firstReactRender	34	28	65	5	36	44
			getState	9	4	42	6	9	25
			initialActions	0	0	2	1	1	1
			loadScripts	1231	1101	1547	92	1294	1424
			setupStore	9	5	43	6	8	25

Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 4ms
Sum of all benchmark exceeds: 8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 3.58 KiB (0.05%)
common: 295 Bytes (0%)

metamaskbot · 2025-04-21T14:14:03Z

Builds ready [f3f6cfd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1090	1410	64	1226	1307
			load	1033	941	1233	57	1058	1144
			domContentLoaded	1027	935	1229	57	1053	1135
			domInteractive	17	13	69	8	16	27
			firstPaint	721	131	1185	397	1047	1139
			backgroundConnect	7	4	22	3	8	12
			firstReactRender	20	15	44	5	21	32
			getState	12	5	43	8	15	29
			initialActions	0	0	1	0	0	1
			loadScripts	793	707	974	54	819	897
			setupStore	8	5	24	3	8	11
	Webpack	Home	uiStartup	2088	1706	2464	164	2179	2337
			load	1609	1335	2005	121	1713	1772
			domContentLoaded	1602	1331	1993	120	1705	1765
			domInteractive	16	11	57	10	13	47
			firstPaint	190	64	602	87	219	338
			backgroundConnect	23	9	76	13	25	53
			firstReactRender	215	54	365	116	322	353
			getState	10	3	28	5	13	19
			initialActions	3	1	5	1	3	5
			loadScripts	1597	1330	1971	119	1701	1762
			setupStore	21	7	293	37	19	31
Firefox	Browserify	Home	uiStartup	1338	1154	1728	106	1381	1538
			load	1194	1022	1591	113	1256	1398
			domContentLoaded	1194	1022	1591	113	1255	1398
			domInteractive	110	34	350	43	115	198
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	185	18	20	40
			firstReactRender	22	19	50	4	23	27
			getState	7	4	37	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1174	977	1574	114	1236	1381
			setupStore	6	4	21	2	6	8
	Webpack	Home	uiStartup	1487	1343	1963	115	1554	1732
			load	1269	1133	1764	103	1330	1452
			domContentLoaded	1269	1132	1764	103	1330	1452
			domInteractive	76	42	147	19	81	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	112	12	22	39
			firstReactRender	35	28	61	6	37	47
			getState	9	4	32	5	9	23
			initialActions	0	0	2	1	1	1
			loadScripts	1248	1119	1713	101	1292	1429
			setupStore	11	5	304	30	8	20

Benchmark value 339 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 198 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 8ms
Sum of all benchmark exceeds: 9ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 3.58 KiB (0.05%)
common: 295 Bytes (0%)

jpuri

The changes look good, but it conflict with my PR: #32034

jpuri · 2025-04-22T05:31:21Z

shared/lib/transactions.utils.ts

+  nestedTransactions: NestedTransactionMetadata[] | undefined,
+): boolean {
+  return Boolean(nestedTransactions?.length);
+}


Is it possible to use the check: transaction.type === TransactionType.Batch

That was my first approach, but in a previous PR, Matthew said that we may have other batch transaction types in future, so safer to do it using the length of the nestedTransactions.

jpuri · 2025-04-22T05:32:20Z

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

+
+  const isBatch =
+    Boolean(nestedTransactions?.length) &&
+    to?.toLowerCase() === from.toLowerCase();


Utility fn can be used here

Pushed the utility function here

link led to merge commit. isBatchTransaction added in the commit before 7078eb1

digiwand

Lgtm!

metamaskbot · 2025-04-23T14:34:17Z

Builds ready [a5433db]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1202	1075	1545	68	1235	1306
			load	1042	936	1358	64	1073	1142
			domContentLoaded	1037	925	1339	62	1066	1134
			domInteractive	17	13	63	6	16	29
			firstPaint	675	80	1349	419	1052	1106
			backgroundConnect	7	4	19	2	7	10
			firstReactRender	23	16	59	8	25	42
			getState	13	5	51	9	18	32
			initialActions	0	0	1	0	0	1
			loadScripts	801	701	1093	60	831	902
			setupStore	7	4	19	2	8	13
	Webpack	Home	uiStartup	2227	1819	2653	187	2360	2573
			load	1734	1392	2230	153	1831	1988
			domContentLoaded	1727	1387	2225	152	1822	1981
			domInteractive	16	12	68	11	14	48
			firstPaint	198	71	497	77	250	329
			backgroundConnect	34	11	348	43	35	73
			firstReactRender	218	59	377	122	335	368
			getState	15	4	99	13	18	33
			initialActions	3	1	7	1	4	6
			loadScripts	1722	1386	2223	150	1819	1957
			setupStore	21	7	192	25	25	37
Firefox	Browserify	Home	uiStartup	1362	1185	1717	117	1402	1625
			load	1214	1059	1598	119	1260	1496
			domContentLoaded	1214	1059	1598	119	1260	1495
			domInteractive	112	42	383	45	126	185
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	178	21	20	58
			firstReactRender	23	19	58	6	23	36
			getState	7	4	52	5	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1193	1027	1584	120	1234	1480
			setupStore	7	4	48	6	6	9
	Webpack	Home	uiStartup	1455	1272	1819	104	1520	1626
			load	1245	1104	1554	94	1307	1425
			domContentLoaded	1244	1104	1554	94	1307	1425
			domInteractive	78	31	151	22	84	131
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	56	7	21	35
			firstReactRender	34	28	75	6	35	43
			getState	9	4	36	6	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1226	1091	1529	93	1289	1406
			setupStore	8	5	46	5	8	19

cc: @HowardBraham
Benchmark value 2227 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1735 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1728 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1722 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2573 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1480 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Sum of mean exceeds: 108ms | Sum of p95 exceeds: 125ms
Sum of all benchmark exceeds: 233ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 3.93 KiB (0.06%)
common: 295 Bytes (0%)

metamaskbot · 2025-04-24T07:48:20Z

Builds ready [6e39fb1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1181 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1181	1087	1399	58	1211	1304
			load	1026	936	1186	54	1053	1139
			domContentLoaded	1020	932	1178	53	1048	1133
			domInteractive	17	13	61	9	16	34
			firstPaint	739	130	1186	397	1044	1121
			backgroundConnect	7	4	35	4	7	12
			firstReactRender	20	16	41	5	21	31
			getState	12	5	28	7	17	27
			initialActions	0	0	1	0	0	1
			loadScripts	784	699	933	52	813	892
			setupStore	7	5	14	2	7	11
	Webpack	Home	uiStartup	2101	1690	2468	174	2230	2365
			load	1632	1315	2003	146	1736	1914
			domContentLoaded	1626	1311	1998	145	1731	1902
			domInteractive	16	11	55	10	13	46
			firstPaint	185	66	662	78	222	306
			backgroundConnect	24	11	63	12	25	55
			firstReactRender	222	54	392	122	339	358
			getState	13	4	216	22	14	23
			initialActions	3	1	6	1	3	5
			loadScripts	1621	1309	1975	143	1729	1871
			setupStore	15	6	40	6	18	31
Firefox	Browserify	Home	uiStartup	1259	1110	1718	116	1301	1522
			load	1122	982	1544	110	1173	1330
			domContentLoaded	1121	981	1544	110	1173	1330
			domInteractive	96	42	222	29	106	164
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	108	10	20	31
			firstReactRender	21	18	57	5	22	29
			getState	7	4	23	3	7	10
			initialActions	0	0	1	0	0	1
			loadScripts	1104	964	1528	111	1158	1311
			setupStore	8	3	174	17	6	22
	Webpack	Home	uiStartup	1468	1313	1986	114	1523	1723
			load	1253	1115	1727	104	1303	1510
			domContentLoaded	1253	1115	1726	104	1303	1510
			domInteractive	83	47	285	31	86	134
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	56	7	21	32
			firstReactRender	35	29	65	5	36	45
			getState	8	4	44	6	8	17
			initialActions	1	0	2	1	1	1
			loadScripts	1235	1100	1703	103	1284	1493
			setupStore	8	5	36	5	8	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 3.93 KiB (0.06%)
common: 295 Bytes (0%)

vinistevam and others added 5 commits April 10, 2025 06:57

feat: add nested transactions tag

ea7878c

fix: lint

3404ee4

fix: locales

000e618

Merge branch 'main' into feat/nested-transaction-tag

bf64839

Merge branch 'main' into feat/nested-transaction-tag

7c7b0bc

vinistevam added the team-confirmations Push issues to confirmations team label Apr 10, 2025

vinistevam changed the base branch from main to feat/nested-transaction-tag April 10, 2025 13:45

vinistevam force-pushed the feat/add-info-account-type-upgrade-alert branch from fece23e to bb47510 Compare April 10, 2025 13:46

vinistevam and others added 7 commits April 11, 2025 08:25

fix: applied suggestions

3e02eaa

Merge branch 'main' into feat/nested-transaction-tag

c38a6e4

fix: lint

3429c8c

fix: add comment

cb1b826

Merge branch 'main' into feat/nested-transaction-tag

2265af8

feat: add info alert to account type smart account

fc1a3a8

fix: display Interacting with in transaction details section

28102bc

vinistevam force-pushed the feat/add-info-account-type-upgrade-alert branch from bb47510 to 28102bc Compare April 11, 2025 13:20

vinistevam marked this pull request as ready for review April 11, 2025 13:21

vinistevam requested a review from a team as a code owner April 11, 2025 13:21

fix: pipeline

0c3ccb5

vinistevam force-pushed the feat/add-info-account-type-upgrade-alert branch from 8b153cd to 0c3ccb5 Compare April 11, 2025 15:28

fix: lint

c826a2c

Base automatically changed from feat/nested-transaction-tag to main April 16, 2025 10:33

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

0cc7bc9

fix: clean up

f3f6cfd

vinistevam force-pushed the feat/add-info-account-type-upgrade-alert branch from b6f4539 to f3f6cfd Compare April 21, 2025 13:37

jpuri previously approved these changes Apr 22, 2025

View reviewed changes

jpuri reviewed Apr 22, 2025

View reviewed changes

vinistevam added 2 commits April 22, 2025 10:38

fix: apply suggestions

7078eb1

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

8183ff3

vinistevam dismissed jpuri’s stale review via 8183ff3 April 22, 2025 09:43

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

01f3657

jpuri approved these changes Apr 22, 2025

View reviewed changes

digiwand approved these changes Apr 22, 2025

View reviewed changes

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

be0d0e3

vinistevam enabled auto-merge April 23, 2025 08:46

vinistevam disabled auto-merge April 23, 2025 12:21

vinistevam enabled auto-merge April 23, 2025 12:42

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

a5433db

vinistevam added this pull request to the merge queue Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

4809419

vinistevam enabled auto-merge April 24, 2025 04:37

Merge branch 'main' into feat/add-info-account-type-upgrade-alert

6e39fb1

vinistevam added this pull request to the merge queue Apr 24, 2025

Merged via the queue into main with commit 913ffa3 Apr 24, 2025
168 of 169 checks passed

vinistevam deleted the feat/add-info-account-type-upgrade-alert branch April 24, 2025 08:18

github-actions bot locked and limited conversation to collaborators Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add info alert linked to account type #31840

feat: add info alert linked to account type #31840

vinistevam commented Apr 10, 2025 •

edited

Loading

github-actions bot commented Apr 10, 2025

metamaskbot commented Apr 11, 2025 •

edited

Loading

metamaskbot commented Apr 11, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

jpuri left a comment

jpuri Apr 22, 2025

vinistevam Apr 22, 2025

jpuri Apr 22, 2025

vinistevam Apr 22, 2025

digiwand Apr 22, 2025

digiwand left a comment

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 24, 2025

feat: add info alert linked to account type #31840

feat: add info alert linked to account type #31840

Conversation

vinistevam commented Apr 10, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 10, 2025

metamaskbot commented Apr 11, 2025 • edited Loading

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 11, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

jpuri left a comment

Choose a reason for hiding this comment

jpuri Apr 22, 2025

Choose a reason for hiding this comment

vinistevam Apr 22, 2025

Choose a reason for hiding this comment

jpuri Apr 22, 2025

Choose a reason for hiding this comment

vinistevam Apr 22, 2025

Choose a reason for hiding this comment

digiwand Apr 22, 2025

Choose a reason for hiding this comment

digiwand left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 24, 2025

vinistevam commented Apr 10, 2025 •

edited

Loading

metamaskbot commented Apr 11, 2025 •

edited

Loading