fix: pipeline

Author: vinistevam

shared/lib/transactions.utils.test.ts

@@ -0,0 +1,21 @@
+import { NestedTransactionMetadata } from '@metamask/transaction-controller';
+import { isBatchTransaction } from './transactions.utils';
+
+describe('Transactions utils', () => {
+  describe('isBatchTransaction', () => {
+    it('returns true when nestedTransactions has items', () => {
+      const nested: NestedTransactionMetadata[] = [
+        { to: '0x1', data: '0x' },
+      ];
+      expect(isBatchTransaction(nested)).toBe(true);
+    });
+
+    it('returns false when nestedTransactions is empty', () => {
+      expect(isBatchTransaction([])).toBe(false);
+    });
+
+    it('returns false when nestedTransactions is undefined', () => {
+      expect(isBatchTransaction(undefined)).toBe(false);
+    });
+  });
+});

shared/lib/transactions.utils.ts

@@ -0,0 +1,14 @@
+import { NestedTransactionMetadata } from "@metamask/transaction-controller";
+
+/**
+ * Determines if a transaction is a batch transaction.
+ *
+ * @param nestedTransactions - An array of nested transaction.
+ * @returns A boolean indicating whether the transaction is a batch transaction.
+ */
+export function isBatchTransaction(
+  nestedTransactions: NestedTransactionMetadata[] | undefined,
+): boolean {
+  return Boolean(nestedTransactions?.length)
+  ;
+}

ui/pages/confirmations/hooks/alerts/transactions/AccountTypeMessage.tsx

@@ -20,7 +20,7 @@ export function AccountTypeMessage() {
           rel="noreferrer noopener"
           color={TextColor.primaryDefault}
         >
-          {t('learnMore')}
+          {t('learnMoreUpperCaseWithDot')}
         </ButtonLink>,
       ])}
     </Text>

ui/pages/confirmations/hooks/alerts/transactions/useAccountTypeUpgrade.test.ts

@@ -9,12 +9,13 @@ import { getMockConfirmStateForTransaction } from '../../../../../../test/data/c
 import { renderHookWithConfirmContextProvider } from '../../../../../../test/lib/confirmations/render-helpers';
 import { AccountTypeMessage } from './AccountTypeMessage';
 import { useAccountTypeUpgrade } from './useAccountTypeUpgrade';
+import { isBatchTransaction } from '../../../../../../shared/lib/transactions.utils';
 
 jest.mock('../../../../../../shared/lib/transactions.utils');
 
 const FROM_MOCK = '0x1234567890abcdef1234567890abcdef12345678';
 const TO_MOCK = '0x1234567890abcdef1234567890abcdef12345678';
-const NESTED_TRANSACTIONS_MOCK = [{ data: '0x', to: TO_MOCK, from: FROM_MOCK }];
+const NESTED_TRANSACTIONS_MOCK = [{ data: '0x', to: TO_MOCK }];
 const ACCOUNT_ADDRESS_MOCK = '0x0dcd5d886577d5081b0c52e242ef29e70be3e7bc';
 const TRANSACTION_ID_MOCK = '123-456';
 
@@ -48,6 +49,7 @@ function runHook({
 }
 
 describe('useAccountTypeUpgrade', () => {
+  const isBatchTransactionMock = jest.mocked(isBatchTransaction);
   beforeEach(() => {
     jest.resetAllMocks();
   });
@@ -57,6 +59,7 @@ describe('useAccountTypeUpgrade', () => {
   });
 
   it('returns an alert when the transaction is a batch transaction', () => {
+    isBatchTransactionMock.mockReturnValue(true)
     expect(
       runHook({
         currentConfirmation: {

ui/pages/confirmations/hooks/alerts/transactions/useAccountTypeUpgrade.ts

@@ -6,13 +6,14 @@ import { Alert } from '../../../../../ducks/confirm-alerts/confirm-alerts';
 import { RowAlertKey } from '../../../../../components/app/confirm/info/row/constants';
 import { Severity } from '../../../../../helpers/constants/design-system';
 import { AccountTypeMessage } from './AccountTypeMessage';
+import { isBatchTransaction } from '../../../../../../shared/lib/transactions.utils';
 
 export function useAccountTypeUpgrade(): Alert[] {
   const t = useI18nContext();
   const { currentConfirmation } = useConfirmContext<TransactionMeta>();
   const { nestedTransactions } = currentConfirmation ?? {};
 
-  const isBatch = Boolean(nestedTransactions?.length);
+  const isBatch = isBatchTransaction(nestedTransactions);
 
   return useMemo(() => {
     if (!isBatch) {